Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1305360rdb; Fri, 1 Dec 2023 12:18:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+ci2oj/oqMEbATpGXZrMAnqhAmxytQfYJmd1kT6TTpu+RWsrpbNQfCExFDuzpzH97EBDQ X-Received: by 2002:a17:90b:38c7:b0:286:65a2:a040 with SMTP id nn7-20020a17090b38c700b0028665a2a040mr194615pjb.27.1701461920312; Fri, 01 Dec 2023 12:18:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701461920; cv=none; d=google.com; s=arc-20160816; b=Lk520ybCItm7/jKLnTvc3ttW6k39IP7klkLQDkoVF5PPmjK6TipooSd1a93IBVoyGB AUWtho8gyKbHjrR/FoUKl/SVUuz4Ce4fMH3B5KDXoBYS4yCYVIeug+EBTckrXFtBgbgs qbtoBI5EeR8QoRs8NsXzXk8WiGQd6zXLPJDSLqpkkUU6gECqwaBUqC4G8wHN6JPnWhrN XsFOWsEW7uuTVl8mWeW7jqLkf5I4zHBeYZrUp+Xnlfow7+l9VMe7fHuH++E0CUut5kTk fAWxeoBlUvr4m3iCUrssavJL3bmfi9CbT3w0VCKoBBlcy7HEOQUavQ2huAeeKAgSAkz5 xXiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:autocrypt:from:references:cc:to:content-language :subject:user-agent:mime-version:date:message-id:dkim-signature; bh=qD5gq9we1e/BtziJPqZE+7iSPDN3dSftBDjUKyOY1uU=; fh=0FTHTU5ch0f14er3xNsZqJratbT4Nsdbk00nWIhalws=; b=AzSiyY+p8GK5HO5TqpJb3lVYAhfYpbpeemtJXx5A/FMS7PPsc1/GldqVItxCSkEYWa yxSeS/OPxa9N6jexbnMdv/onu0Udn+NKz54OddhmSKLVSq58s7lvrGoxNZBWm7JDyDgC FbaUpEkpQ8pEmJOi47EZNjtI6M+4//LIDuJSgXjl2oKkg+8NTnc9vbJa83sngVsH23Tb WQojkvvNCcFdUSL1b3edds7mEdJCrotuNxY7pNxDYN+Fg2uzL+O3LDGcu0ukbPqoHW3s tveW3Y4pGRyHXbjpoAJan8hd4pB+NMCw6Fgl2/ZUFU1lHCVQ2ppk/7UnnXmIYzVuHIOk tkuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aF3b9wkP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id jx24-20020a17090b46d800b00285e7d660a6si5854559pjb.125.2023.12.01.12.18.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 12:18:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=aF3b9wkP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E6EAF8275354; Fri, 1 Dec 2023 12:18:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229562AbjLAUSW (ORCPT + 99 others); Fri, 1 Dec 2023 15:18:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjLAUSU (ORCPT ); Fri, 1 Dec 2023 15:18:20 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F5C1A0 for ; Fri, 1 Dec 2023 12:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701461906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=qD5gq9we1e/BtziJPqZE+7iSPDN3dSftBDjUKyOY1uU=; b=aF3b9wkPfm+z+XfiyyCKItk/cX2sWTpA+x40/pcOrCJKbz8+jnSNNmWNflKQOoKmmLaYZW uxj1+EqxZlycs/bhfXbG473gF+VbeajXVCtf39cdYPDUwj5+R9INPNhYF8WT7ZEp2X4AkP Wro6G6Ma3Uzu/FXWyUAjlMJmWd4yuAc= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-297-VxB_hdU0O2aaMJoDNUQENw-1; Fri, 01 Dec 2023 15:18:24 -0500 X-MC-Unique: VxB_hdU0O2aaMJoDNUQENw-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-50bc42e2bffso3065831e87.1 for ; Fri, 01 Dec 2023 12:18:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701461902; x=1702066702; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qD5gq9we1e/BtziJPqZE+7iSPDN3dSftBDjUKyOY1uU=; b=erhdiK7zaqf7Q/uH9d/2Q8iFi0jIjh/ZbIrh8Z86HsVO++nXTTMkSIjY81vPqOFGNi m/bne3rjoq3v3C0HC11bek6E6qmRwCx9YosVhKfL2dGUNc9OVQwozLyw1aQC8Rt9n93j BqxHrVM48Jcel9SG/B/FUkl+VTvtq5M/L2CvHW49TcOGFBVJsIFT8CTp4u72jTOOYn3b qs9x6gMOcZ8wtkPC6Af1vU+k06GNHFC8ZAH0aYNkIohf+uU+7Imoku3tphsAwJ328mTS GqeQ/L52nu9qRlQrO5C4QBY6ZNFd2/a73tQxBdZum9pLJtCoTIr3a1QU2d+VFP3yI7Sk 65TQ== X-Gm-Message-State: AOJu0YxJ6fF3N/C6xmT7rQ0+f4uJDXOHtR5G+kU8PjhfX4OR85TwiI9t z4xSxTcehc2u9i54VcA5xJWFeHwLbrpg1px+KDUjDWNApbbEZdeOshrIusXxykPjB1ojbynHv+P nlPNMTHcIJxA0rayTCsb+Lt5z X-Received: by 2002:ac2:5303:0:b0:509:1033:c53e with SMTP id c3-20020ac25303000000b005091033c53emr1118386lfh.62.1701461902596; Fri, 01 Dec 2023 12:18:22 -0800 (PST) X-Received: by 2002:ac2:5303:0:b0:509:1033:c53e with SMTP id c3-20020ac25303000000b005091033c53emr1118384lfh.62.1701461902171; Fri, 01 Dec 2023 12:18:22 -0800 (PST) Received: from ?IPV6:2003:d8:2f28:7800:30d7:645a:7306:e437? (p200300d82f28780030d7645a7306e437.dip0.t-ipconnect.de. [2003:d8:2f28:7800:30d7:645a:7306:e437]) by smtp.gmail.com with ESMTPSA id o18-20020a05600c511200b004064e3b94afsm10022155wms.4.2023.12.01.12.18.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Dec 2023 12:18:21 -0800 (PST) Message-ID: Date: Fri, 1 Dec 2023 21:18:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/rmap: Fix misplaced parenthesis of a likely() Content-Language: en-US To: Steven Rostedt Cc: LKML , linux-mm@kvack.org, Vlastimil Babka , Andrew Morton References: <20231201145936.5ddfdb50@gandalf.local.home> <2d691c11-fa97-4f56-a4c4-c7f466c81d3a@redhat.com> <20231201151535.06c7aaaf@gandalf.local.home> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231201151535.06c7aaaf@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 01 Dec 2023 12:18:38 -0800 (PST) On 01.12.23 21:15, Steven Rostedt wrote: > On Fri, 1 Dec 2023 21:06:22 +0100 > David Hildenbrand wrote: > >> But >> >>> Cc: stable@vger.kernel.org >> >> stable, really? Why? >> >>> Fixes:fb3d824d1a46c ("mm/rmap: split page_dup_rmap() into page_dup_file_rmap() and page_try_dup_anon_rmap()") >> >> and does it even fix a real bug? > > As a performance person, who measures likely and unlikely results (the > ftrace ring buffer was sped up by over 50% with strategically placed > likely/unlikely annotation). I find this to be a real bug, and something I > would want backported to the kernels we maintain in ChromeOS (which uses > upstream stable kernels). Okay, I don't care that much about a "Fixes" annotation. But I am *pretty* sure that this is not stable material, looking once again at the stable rules. Anyhow, thanks for catching this! -- Cheers, David / dhildenb