Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20230602194513.1589179-1-namhyung@kernel.org> <c5a40920-0b14-b9b5-19ee-48c965bd12e3@amd.com>
 <ZV9lfJyyC7xawHBC@kernel.org> <3d70b52f-2042-328c-6dc7-37fcbb3510a2@amd.com>
 <ZWSombzfCkxHc7lC@kernel.org> <fc2390cf-bdf9-590e-d078-4bb616d5feb6@amd.com> <ZWiIB0AURxL7qb5e@kernel.org>
In-Reply-To: <ZWiIB0AURxL7qb5e@kernel.org>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Fri, 1 Dec 2023 12:23:16 -0800
Message-ID: <CAM9d7chHWovp7W+e6KBaeZh3pBZTuHBe0hRH=6WW9-XBp0SQaw@mail.gmail.com>
Subject: Re: [PATCH] perf/x86/amd: Reject branch stack for IBS events
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Stephane Eranian <eranian@google.com>,
        Ingo Molnar <mingo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Thu, Nov 30, 2023 at 5:03 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Thu, Nov 30, 2023 at 11:58:15AM +0530, Ravi Bangoria escreveu:
> > On 27-Nov-23 8:02 PM, Arnaldo Carvalho de Melo wrote:
> > > Em Fri, Nov 24, 2023 at 09:30:37AM +0530, Ravi Bangoria escreveu:
> > >> On 23-Nov-23 8:15 PM, Arnaldo Carvalho de Melo wrote:
> > >>> Em Tue, Jun 06, 2023 at 10:08:43AM +0530, Ravi Bangoria escreveu:
> > >>>> On 03-Jun-23 1:15 AM, Namhyung Kim wrote:
> > >>>>> The AMD IBS PMU doesn't handle branch stacks, so it should not accept
> > >>>>> events with brstack.
>
> > >>>>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > >>>> Reviewed-by: Ravi Bangoria <ravi.bangoria@amd.com>
>
> > >>> It seems this patch was not merged, can you please check?
>
> > >> Right. And it does not apply cleanly on peterz/queue.git/perf/core, since
> > >> surrounding code has changed.
>
> > > Can you please refresh it if PeterZ has nothing against?
>
> > Posted v2: https://lore.kernel.org/r/20231130062246.290-1-ravi.bangoria@amd.com
>
> Peter, can you please consider this one?

The v2 is already in the tip tree.  Thanks Ravi for doing this!
Namhyung