Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Fri, 1 Dec 2023 13:32:37 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        "Linus Torvalds" <torvalds@linux-foundation.org>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH 2/2] x86/microcode: Rework early revisions reporting
Message-ID: <ZWpQ9Wbb7u4ss0mt@a4bf019067fa.jf.intel.com>
References: <20231115210212.9981-1-bp@alien8.de>
 <20231115210212.9981-3-bp@alien8.de>
 <ZWjVt5dNRjbcvlzR@a4bf019067fa.jf.intel.com>
 <20231201163928.GCZWoMQNAAQSA9U12D@fat_crate.local>
 <ZWpDHgNjhQKLodF6@a4bf019067fa.jf.intel.com>
 <20231201204146.GGZWpFCqodLUPS27tJ@fat_crate.local>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231201204146.GGZWpFCqodLUPS27tJ@fat_crate.local>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YpTcu7Ilpw7gUAp0732X6D1pLvCHs3CBD5NFuoMcdzpsAr9fH8tW9MbiqPTL?=
 =?us-ascii?Q?3bUYXvic+Mm6BHuZypA2wJigTnA361dXQzar6mSZG+aGZ9txNoS8k0DqWM0q?=
 =?us-ascii?Q?hB8ms64rW7Uumr9/AIhEbrg4Caljzo4d1K9nCSlm5yK5lheK5gSnCx1H2B3z?=
 =?us-ascii?Q?G6h8fCakY50RNg46/QY7BnHH8X+dazAvu93ou0F1dHuKDFZcWcrP9bzC902u?=
 =?us-ascii?Q?HKFEhDHq7zgrGU5z5YNYCm4ZpaJXqzHESDlR4VWPoLnXtY4cDlKFIGKDQ4uA?=
 =?us-ascii?Q?eboP8AtXaL6DBeNGXSfW82qfmCMxaRTc9GuAhHUek9gfjBvz8JH3SePKALm7?=
 =?us-ascii?Q?N2HToCJ8YWgSXGWcRIapcrQjdiAmaWrRfsYcORqA0Jvy+wds61jETCLFTDi1?=
 =?us-ascii?Q?uAXxDbFikZvdZbHu6z28H4bUgJrpXkO9s5kIBR6Qy03rsK/VezE3cG2LrWoz?=
 =?us-ascii?Q?o78z5G7bfTeK0tMBQw2YteGe7BSDQ8ysKJyxm4wig9B/9kz4/haF/AO2NJFA?=
 =?us-ascii?Q?s8YkcJPhUKiHMGc+jYrx9TGnNqF+BvcdeocjR9j5SfHcovIYOGqEJFO7BElu?=
 =?us-ascii?Q?1Rj5Ir7+C7Yh1L0637DiBmdxngvU4ghuHmWNJ92xNFOQPxYkS5++N4ZwTCQt?=
 =?us-ascii?Q?b+XNW1TVLx8sfVCZlh9XFhcynsUE1XIEXisyHrd/AwWI6752H4XHLuDlH1YP?=
 =?us-ascii?Q?igXOL3DRAPrj9I/2c1pF/xVCbQhcR6F8xBsfw+DhJZb4Ne9Ayn7wnzwwO2cu?=
 =?us-ascii?Q?Kska217JQDlKq/0LkqpuGLOY1z2rlDpe6A6jtvfz7o6uRRin5FUE1e761J+D?=
 =?us-ascii?Q?wCgJyuXpk7Sd2RZ7wWn7OdKKjrnsNPfs4D1D35bHWzDH2O10918RoCOeswuU?=
 =?us-ascii?Q?Kz/Apmwij/yJP5ZA5WNu5o1Zpsr1N6du9FBWfaMxqbR1tXZYUEQuSq+J4Htx?=
 =?us-ascii?Q?nGqT21FvgFquek095pk7tCgP4rPfcCIXp55/P+ZCvZ7l/XNe+5/YZRg0sGzo?=
 =?us-ascii?Q?3EiScPUd3IoLbmUIobMR1dpSv2NuWw/jh9GrsaEEe5MsHOWk/cV1S6MK8I+j?=
 =?us-ascii?Q?5c8xLIvQC14/7UoAaPqrFHuw89nyG+Ukot8YLc0hSMdcIirWY2ia0tjpxYwT?=
 =?us-ascii?Q?DgL//kmv4v2q1Jz3Yv10o4iCAO1vgjQDinxwgBgK8b2lKxDgLoBgUePL+f2C?=
 =?us-ascii?Q?g3OvEZs76UsUGSo+RLwyJNmjsfBtrObpsxW7TFLDOXx7AbZ89dNpS3Q1fz1p?=
 =?us-ascii?Q?hYw2xvJEJE3/rsmLC4JZhutwl86FhDy9fFYVVmwgkPZhjind5/oVOBXhopOi?=
 =?us-ascii?Q?FXENGODMppbjZhX0AETYB/PHMwtfhkJBqaBMhHOHIej5cJNJPq2u8fcHI4Gx?=
 =?us-ascii?Q?GRFm2Ly6sRKAr8LjQ11qmd5sUyVwrBpqa8+miCz8Pwl7OyiyD/UtpDLToeS7?=
 =?us-ascii?Q?roqWsM2ZoBAHqiKLtC3cJCIgc6RTXwO0aMd7RnnamO9CQ2anGDZ24+13fGHq?=
 =?us-ascii?Q?ZKNF3r+p8zT+vC+Fu9mDj00X+sGrAVwVT/5OtgnU8lby8uKYFr5bc431LGC1?=
 =?us-ascii?Q?G4EW428hnsY5iLshLfUi79rZReGcoLNZnjXutJTr?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cb12ac81-68c9-489e-50c7-08dbf2b50cf4
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2023 21:32:42.5757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yiSP/QQUEK0BwAYpNzHfl7wyfZGN2YfEBHTLudMfX3n/Qe1FvnlsXrC5V9aawOpy7re62m7kJXf2lrBWZIm0Vw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4587
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 01 Dec 2023 13:33:00 -0800 (PST)

On Fri, Dec 01, 2023 at 09:41:46PM +0100, Borislav Petkov wrote:
> On Fri, Dec 01, 2023 at 12:33:34PM -0800, Ashok Raj wrote:
> > I'll get a dmesg shortly once i get my test system back.
> 
> Thanks.
> 

dmesg for the microcode part here below:

https://paste.debian.net/hidden/e911dffc/

> > What I meant was 
> 
> I know what you meant. Did you see the diff I sent you?
> 
> It has the fix already:
> 
> @@ -410,13 +421,19 @@ void __init load_ucode_intel_bsp(struct early_load_data *ed)
>  {
>         struct ucode_cpu_info uci;
> 
> -       ed->old_rev = intel_get_microcode_revision();
> -
>         uci.mc = get_microcode_blob(&uci, false);
> -       if (uci.mc && apply_microcode_early(&uci) == UCODE_UPDATED)
> +       ed->old_rev = uci.cpu_sig.rev;
> +
> +       uc_dbg("old_rev: 0x%x", ed->old_rev);
> +
> +       if (uci.mc && apply_microcode_early(&uci) == UCODE_UPDATED) {
>                 ucode_patch_va = UCODE_BSP_LOADED;
> +               ed->new_rev = uci.cpu_sig.rev;
> +
> +               uc_dbg("updated, new_rev: 0x%x", ed->new_rev);
> +       }
> ^^^^^^^^^^^^^
> 
> The assignment is now inside the UCODE_UPDATED conditional.

The first patch I tried was exactly this, but assumed having the fix  in
core.c would help both AMD/Intel.

Assuming if the same loaded patch was also present in initrd, 

load_ucode_amd_bsp()
   early_apply_microcode()
      __apply_microcode_amd()

old_rev will still be non-zero.