Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1366222rdb; Fri, 1 Dec 2023 14:32:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGRNk1JkrhuYwfx+ihgvbtAxhHuFUawGRPSEBjwT/2KsNv0YnGR24eJVkmIJstDy2nqbqI+ X-Received: by 2002:a17:903:447:b0:1d0:5302:4642 with SMTP id iw7-20020a170903044700b001d053024642mr300913plb.16.1701469939066; Fri, 01 Dec 2023 14:32:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701469939; cv=none; d=google.com; s=arc-20160816; b=bR7xu+4avJzKtYepeZjEyl7wW6VZKJHd9tTiK0TbRaHhRCXGVujKifQXAdUkus+awb 193euyWYxILkPC38MvVJje8rF2pxKHf4b6N0ad656atzqCVszp8hxmxx148Mrx4jLRCs 6C6KU3M+LX8I7Uyl6c4lA5iaM9NJMrJ7DLClm/rIYGWpGpLrGBqAfany0eGlX84X86xw MlC2hX21+wbJYYtQpvVHjzjeWhGk3EKkDdHqPEwcnn4bTsCzygK2DWUM+PwMLsXibgKf jo9iHlKuM4Vx2DUmbQawj9qIz4vgOEu8pxLJwuHWfE/KzxiGkI6WGWQPELmt776nKmty 6Qng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=3tkYsMWbKQfh7kgu+7rruDUDrB2QAfkIq4Km6a5Mvvo=; fh=dTtrAcGs2K0uRyVUqjRkO1Is4PnzkiHWJaMmpc6Zsfo=; b=Q3mtCI+8MeH3HY0jZ4HmlCHAzppR244muH+lLrHL3uqCi8dsaaoRT/HkLyo8aUkAGc uK6TgdwWvkE3J9IpLsfCyTa2zfzDZ3HZs7yI3Zy/5r3qfskshTo3XQBuC4NCo3DfbiNe MykNzmwtzXJuOJ/1Ce6wZUD87ZP3YjvZNPncK68NFqq3Y6eFj6QSc2hTRVN/4wdxiD7Y JYkkDqeJtq38IRybEqaRQYfmc+dLj3JvylQHdkuLaqyKeyG1UrkBqaC0sabyr4vg6YS5 BaTSLMEfiqensqRQspjj4YPuruVQuWazEjo+h0UjfgHNnQm5uY3/SYw10SapZM60N64V oLvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm3 header.b=LOjQ9wXj; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b="fT/Riyrg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id j21-20020a170902759500b001cfc6492730si3768303pll.80.2023.12.01.14.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 14:32:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm3 header.b=LOjQ9wXj; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b="fT/Riyrg"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 6EA03831AE98; Fri, 1 Dec 2023 14:32:16 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229590AbjLAWcC (ORCPT + 99 others); Fri, 1 Dec 2023 17:32:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjLAWcA (ORCPT ); Fri, 1 Dec 2023 17:32:00 -0500 Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EC9712A; Fri, 1 Dec 2023 14:32:07 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 8617A2B00344; Fri, 1 Dec 2023 17:32:02 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Fri, 01 Dec 2023 17:32:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1701469922; x=1701477122; bh=3t kYsMWbKQfh7kgu+7rruDUDrB2QAfkIq4Km6a5Mvvo=; b=LOjQ9wXjw4VM9J3b9P rwSsQ+E+CzZ6OSUJx0CMjinOlbgQZN3Rhh1SJW/C2qpjTTJcV7Y+psEN4lY2G+Ub qpGbWjkTy99IlUAjtuReYp/hb2z+Hq4SFun44JxlvFte/V+pxdserNMsR95EHsTH /lMg9fM6tkV9gj4XUH56gCj9ZiEV2uuI5n+KoxVjioItGbME3DZFaDYVS60hLZ7w HpwO2Zydt6ay0ZpmkaMh0hVbeFgoxn3NY3qvG24Fm5Y6jPWU+FQoWJuZMrR+LHM5 7HHF+bSWwBqCq4VjDhf4GUyVdZe33/fxGK+L2/XF5+TEipW/Ow52/jc8fWYzPVEd 9IMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701469922; x=1701477122; bh=3tkYsMWbKQfh7 kgu+7rruDUDrB2QAfkIq4Km6a5Mvvo=; b=fT/RiyrgsZhWtJbhIUhKOFxdnURkA Wzkzu5sR5UiNAkhrL0ERyd5vMBWhFdzekf4ELeQnJ7lYImJ8haAJD2uk7gv1A1Ge 13VazCKbT3mmQFPTWbLgkI02mKMsuTQJKpu9nBCbZEicb+6UuFy0nihReEOvArw2 1Jd9xk2bZ+4E8RvgGpxlajNbjG6fe6VugiorVf8/cfKYW5lYtPm3Lo5/OWU7DOKa 1D1FjPx/sAGznqapbZJH0EZEXUBzNXxV6TSzCzehMU6lpysGAsVCpwHREDdqv6IN Mg98p9ms6N5A0A8s7a/YqbFnJz5o0emQn8tvN+Zxtv1usJGkKXue90m3g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeiledgudeiudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdet rhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrg htthgvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedt keetffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0EF3BB60089; Fri, 1 Dec 2023 17:32:01 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 MIME-Version: 1.0 Message-Id: <375165a6-e748-495e-9f74-81bb6496ac7e@app.fastmail.com> In-Reply-To: <90423946a0dbdcdb7cb3c93b3897683ce07c5e69.camel@redhat.com> References: <20231201121622.16343-1-pstanner@redhat.com> <20231201121622.16343-3-pstanner@redhat.com> <32552a65-b540-4baa-9180-e04a278f0ca6@app.fastmail.com> <90423946a0dbdcdb7cb3c93b3897683ce07c5e69.camel@redhat.com> Date: Fri, 01 Dec 2023 23:31:36 +0100 From: "Arnd Bergmann" To: "Philipp Stanner" , "Bjorn Helgaas" , "Andrew Morton" , "Dan Williams" , "Jonathan Cameron" , "Jakub Kicinski" , "Dave Jiang" , "Uladzislau Koshchanka" , "Neil Brown" , "Niklas Schnelle" , "John Sanpe" , "Kent Overstreet" , "Masami Hiramatsu" , "Kees Cook" , "David Gow" , "Yury Norov" , "wuqiang.matt" , "Jason Baron" , "Kefeng Wang" , "Ben Dooks" , "Danilo Krummrich" Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Linux-Arch Subject: Re: [PATCH v2 2/4] lib: move pci-specific devres code to drivers/pci/ Content-Type: text/plain X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Fri, 01 Dec 2023 14:32:16 -0800 (PST) On Fri, Dec 1, 2023, at 20:00, Philipp Stanner wrote: > > The devres functions have different compile rules than the iomap > functions have. > > I would dislike it very much to need yet another preprocessor > instruction, especially if we're talking about #ifdef PCI within the > very PCI driver. Ah right, I had forgotten about s390 zpci being special here, otherwise we wouldn't need an #ifdef here. Arnd