Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1390528rdb; Fri, 1 Dec 2023 15:31:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWXfJXODljmMUNhf8Vyumh8zNSNhkkv4sWd8um6PPbsEoR62hEYUAt6X9uXDUFiURPjahl X-Received: by 2002:a05:6808:1897:b0:3b8:b063:9b50 with SMTP id bi23-20020a056808189700b003b8b0639b50mr376759oib.66.1701473462385; Fri, 01 Dec 2023 15:31:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701473462; cv=none; d=google.com; s=arc-20160816; b=DBjy+MqUUVrPn6jcYBKQBpm2msuws8sfOL1yvIcGX1Crpx9+XdZDFmRCoW7NHJgnaw pCO+0HvEmaoGW5xYTQ7bHgJSpB6qf9G29noPpSq4bewsvbG7cSptFJ9Y8slTXO7yNqao +qH8RLgQlU6QBW7dc3XaGDW8Loi8VGmrqshARQv3zubvD6INy7CeJ6oebFDBx9Odfm74 V08WwNOjCzbYh0C5fG5J9t7soExoN9atkLOrEDVN6RN9C0P7UcChK/pEneHk4lj2f89q JVTX/wL0zhkUlqDqJE4/ydD834bva1MTlKF6FKivNOV6GGb5U9hy8f222IH2EIngzYSe /AzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=pFtKRJPt7zxEv0tffHLPtKUpr/5KbMlnf6dTP8uAgt0=; fh=9PerlfblsiZbka2l+XenpfAK7K3pRuIpMvYKsjgbH0w=; b=Fr/SnxOO0rPS83CCMCE8AaVVL4aSGAF+iaBM4upJmdl6RTDuhx1Ac5tV8G1gf2o5i3 ScIi28qYSPtPHamnB/DtFwRw+KcSdqNxvtctL3qL6MLUxiVqA9xjp/gw3aVNXmpVrVh3 NGwVhrkD8HLTzatQOfvUPZYPS4cd9yDKJz01gzVn33nnU7X5QHswwrZMz2nhmIdVcXZs AVxv9vvHbr/d/dv6vgeqc9nesfuL896AeFRAHIbZeJ79ySDXr1CuzsYY36yEhHSogQBB veiKhOdya7/I7HOimgcS45h9az0uZnmXDSPQfZ0glYPRE9n87HMkXA6R6z5hgqArc6ao qlCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=V9lJelFV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id 72-20020a63014b000000b005c21c4a46ddsi4063444pgb.356.2023.12.01.15.31.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 15:31:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=V9lJelFV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 980A68079C9B; Fri, 1 Dec 2023 15:30:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235256AbjLAXaj (ORCPT + 99 others); Fri, 1 Dec 2023 18:30:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbjLAXah (ORCPT ); Fri, 1 Dec 2023 18:30:37 -0500 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E73D01AD for ; Fri, 1 Dec 2023 15:30:41 -0800 (PST) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5d1b2153ba1so45057467b3.2 for ; Fri, 01 Dec 2023 15:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701473441; x=1702078241; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=pFtKRJPt7zxEv0tffHLPtKUpr/5KbMlnf6dTP8uAgt0=; b=V9lJelFVfAuMQvXoED5BRlK0yRV7Q6YtuMUejP5T5kSVcloGibl/w6DnhFyiAqkJJU CBPlK8ygcuRKI2ASo2D3ctXvp3PuYvmBLO4ijkqb3rIMY00mE2hMD0RJhE7v39+7UtoB pnmHVCtFhzB1mXCMjy+JslGJOXf2K8F9TDq/4UrEutHtLEKjs/q2e7xtzqrlwKoHm4O0 uQ8bCkPl2RKbVL7NDPXrEO+LYcq1y+/yM2rsIJENQw7h0fB92LBvK7rDkrM4O2Pk1JFe qkRbvOmeB0Sc1ai2TYkH5ELdEm20fcH8m/OsjvB4xsyMTRjezEuDc5Z/U6oSfnE3uzXY 9Fvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701473441; x=1702078241; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pFtKRJPt7zxEv0tffHLPtKUpr/5KbMlnf6dTP8uAgt0=; b=eQOn8ez64RWbyNZaUB2hPTfDSnaauMQ3lZac6pvmnt58+HBFZXQ2uGjvlWYW/2uIgE xUZdSfxI9n9e2sgyksS1uZRCs93SQsuR5d8nqtOfIf+Wi6S9UtI02rPHPkLx+SfFqDA8 gGM90WKh/UKu4yC1XvTQ2FWPZsWw0q1dKevkJqdFPBTRqnYTmLOgB5lhXWKdRwHAz9Ja pGCBLXfDO7ev6tkYTpT9PAKGQZBhuqDOym36R6ob3BOQ5H6CLDkl9BbgVUKKFd0txpOt QiQe83QS24fhdYGGsgYvb+TP8jM6ZP8L0EEbqZgGc048EZPLtzXq+CGY8LBV3e9o8JZC b6Iw== X-Gm-Message-State: AOJu0YxiVn8/q0MgKIVFcN7Vatbole+oGAElJpWN48mLLdjbcMPlFyj1 8nraCR5bhnrcfuX7f/EAtDnOE9674Pc= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:d40f:0:b0:59b:e684:3c7a with SMTP id w15-20020a0dd40f000000b0059be6843c7amr886798ywd.4.1701473441225; Fri, 01 Dec 2023 15:30:41 -0800 (PST) Date: Fri, 1 Dec 2023 15:30:33 -0800 In-Reply-To: <20231007064019.17472-1-likexu@tencent.com> Mime-Version: 1.0 References: <20231007064019.17472-1-likexu@tencent.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Message-ID: <170144728224.840084.5797440525158883360.b4-ty@google.com> Subject: Re: [PATCH] KVM: x86/xsave: Remove 'return void' expression for 'void function' From: Sean Christopherson To: Sean Christopherson , Like Xu Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Fri, 01 Dec 2023 15:30:59 -0800 (PST) On Sat, 07 Oct 2023 14:40:19 +0800, Like Xu wrote: > The requested info will be stored in 'guest_xsave->region' referenced by > the incoming pointer "struct kvm_xsave *guest_xsave", thus there is no need > to explicitly use return void expression for a void function "static void > kvm_vcpu_ioctl_x86_get_xsave(...)". The issue is caught with [-Wpedantic]. > > Applied to kvm-x86 fixes, thanks! [1/1] KVM: x86/xsave: Remove 'return void' expression for 'void function' https://github.com/kvm-x86/linux/commit/ef8d89033c3f -- https://github.com/kvm-x86/linux/tree/next