Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <6ab5bc0f-3945-43be-ab66-439402ca9a81@infradead.org>
Date:   Fri, 1 Dec 2023 16:53:22 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: drivers/pinctrl/pinctrl-mcp23s08.c:1: warning: no structured
 comments found
Content-Language: en-US
To:     kernel test robot <lkp@intel.com>,
        Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc:     oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        Linus Walleij <linus.walleij@linaro.org>
References: <202311220421.xKye7ZRO-lkp@intel.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <202311220421.xKye7ZRO-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi lkp,

On 11/21/23 13:12, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   98b1cc82c4affc16f5598d4fa14b1858671b2263
> commit: d8f4494e70ae5fef159719bfbb6abedc53619bf1 pinctrl: mcp23s08: drop comment about missing irq support
> date:   7 years ago
> config: i386-randconfig-002-20231120 (https://download.01.org/0day-ci/archive/20231122/202311220421.xKye7ZRO-lkp@intel.com/config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231122/202311220421.xKye7ZRO-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202311220421.xKye7ZRO-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>    drivers/pinctrl/pinctrl-mcp23s08.c: In function 'mcp_pinconf_set':
>    drivers/pinctrl/pinctrl-mcp23s08.c:282:6: warning: variable 'val' set but not used [-Wunused-but-set-variable]
>      u16 val;
>          ^~~
>    drivers/pinctrl/pinctrl-mcp23s08.c:281:11: warning: variable 'mask' set but not used [-Wunused-but-set-variable]
>      u32 arg, mask;
>               ^~~~
>>> drivers/pinctrl/pinctrl-mcp23s08.c:1: warning: no structured comments found
> 
> 
> vim +1 drivers/pinctrl/pinctrl-mcp23s08.c
> 
>    > 1	/* MCP23S08 SPI/I2C GPIO driver */
>      2	


What is the issue here?
I fail to see a problem.

I cannot reproduce the $Subject warning message.

-- 
~Randy