Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   "Song, Xiongwei" <Xiongwei.Song@windriver.com>
To:     Kees Cook <keescook@chromium.org>,
        "sxwjean@me.com" <sxwjean@me.com>
CC:     "vbabka@suse.cz" <vbabka@suse.cz>,
        "42.hyeyoo@gmail.com" <42.hyeyoo@gmail.com>,
        "cl@linux.com" <cl@linux.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "penberg@kernel.org" <penberg@kernel.org>,
        "rientjes@google.com" <rientjes@google.com>,
        "iamjoonsoo.kim@lge.com" <iamjoonsoo.kim@lge.com>,
        "roman.gushchin@linux.dev" <roman.gushchin@linux.dev>,
        "corbet@lwn.net" <corbet@lwn.net>, "arnd@arndb.de" <arnd@arndb.de>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with
 "slab_$param"
Thread-Topic: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with
 "slab_$param"
Thread-Index: AQHaJAS7NylgWPHDL0CTsOtYEw3Wl7CUtO0AgACxhYA=
Date:   Sat, 2 Dec 2023 04:23:29 +0000
Message-ID: <PH0PR11MB51923F916D8FB7D94270BBA7EC80A@PH0PR11MB5192.namprd11.prod.outlook.com>
References: <20231201031505.286117-1-sxwjean@me.com>
 <20231201031505.286117-3-sxwjean@me.com> <202312010945.7C5DB1FBB@keescook>
In-Reply-To: <202312010945.7C5DB1FBB@keescook>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?76AUCfCGZJ6Ycz0kpWYnTrnz3LoT2wh6bzSxwffKOMTop9d/KHMjno1zRCHq?=
 =?us-ascii?Q?FhFyGsLPJp3wfWQoqqfaBwppjUz0XetVHY7oWEXuoKLxuxKR4TDJ0D0Di/Dt?=
 =?us-ascii?Q?BBWesJbfTVDJWyYI5n7h3xk4bCB87P+cRsLMras0/NSlb8UGRIjYZMC2NvFr?=
 =?us-ascii?Q?MTQM9ApDoJalWhVAgxKRe7tL24SSHOb/3k9fe+kQ2qCyCA1a8ua8bRSbLR0p?=
 =?us-ascii?Q?JgJbIAtHZx09KEYFiSs4HdP3aI3pH8h+33/YsI2jpk5eJxnLnyAoeBub6IQU?=
 =?us-ascii?Q?IqmQAfhiRWgjvKGRH9ipSCsPQkwXJRS4d1G7pdjJBLalPIvPnJBwi52S3Ipu?=
 =?us-ascii?Q?m8w5vU/xSddJdm/jTUA0uUl2h8i5SEZCgqHeTS8rFCUpohJczDrpbknUCJFo?=
 =?us-ascii?Q?GoNGFtgRuFvf++9Zz4fxuqyIWZBM6qf8SqxzvzkRdHfHg8PVp20vyPVztY0b?=
 =?us-ascii?Q?LGwuV+QyDNcIwZVqhHx/DxVkgP2vXyktSv141YvJnUoFLcPCSLqU1BLPlFJL?=
 =?us-ascii?Q?WHXu9dTMqXeRMAKgASKwQuTpI01TD7vMYnsCOgDNc6lBuAMJTADivbFSpjd4?=
 =?us-ascii?Q?oDUPxq4zBgbBWqPZUeMMx23Oq3rqVriXAWjZiJNoNUrWFt0JzYGio0N4qTU3?=
 =?us-ascii?Q?cpAPTSBhNeghEO5vs+KFLu2WpRQUPNpFnrVXGtcy14jFdGJiChoWgYHfTlMt?=
 =?us-ascii?Q?30nGvjYIDxZyrgPENxuvyPycaEgYBfMVrYTInVPgW72JBd9VOj7NTvCG+aWw?=
 =?us-ascii?Q?vKo94PNwJvsM6QNGGFEd18qcI8Rsp1fFdeiFTTcQ8djjcimMkOsKsV3G0qP0?=
 =?us-ascii?Q?YGweIBjVbv16FnzZFxVmXg9u7wMcbGp1eYbgMRgn9NhzUUGEhlLc02ModU9m?=
 =?us-ascii?Q?kKmKrYcTphEKW1/iLiBjFELYHLRrE2DtjNxKraRi9Vdn+HJXdoKFwxn79AN0?=
 =?us-ascii?Q?FsEMU5qJo/BUkEgRMCuqoDa7y8kovnKOqoeOqrS+u+jmP7qSGVc5BPBV/HuH?=
 =?us-ascii?Q?dYiriOfz8mgOT5LXY61eHBI87CFZGoRYgrVgcWRylGK+mhAqTl6g4taABug+?=
 =?us-ascii?Q?38wfkWF27jVYqrrlDsr60Mbcwa6r3zneouq3lr9/D208Ylipvnk5rVJt0fea?=
 =?us-ascii?Q?O1OJcXPJUfqhQnBVY12cr/yKw1aE55tm9sOYBtbNhI4WE30F64outnJqs0ma?=
 =?us-ascii?Q?um/cXXIF7r9sGsWL6HMW8/gIA7IE+qsoGpP5kbIeXO700HMH30IR7v63miCa?=
 =?us-ascii?Q?O8vnuPdxttAs2uefvBvT8Kip6ZOkYPSfmftjHGJxya6mQlM0ZYJAYOQon371?=
 =?us-ascii?Q?bIkfiKGc06GNMtsMGnX9U81sQcwyIOaj8VTIB7/EuCb2efH3klzeSpkOLIom?=
 =?us-ascii?Q?NW+BKKoS3kra4sPmT5b3DKadYLeRHdAU/KnQi0B1Pc+9hJxWkt3x+R9Se5TE?=
 =?us-ascii?Q?RGXWSs2l5XAIg5VqvEHM0+qaR6QnGYo8dHBa7P+XO6AiQYEQ9ctLuRUc7AlW?=
 =?us-ascii?Q?6gerJrKx1SI4fT9KECGSmGOg9tOYB4obEiVhp9a5Rd0N4WIhxTjDwG6ER5S4?=
 =?us-ascii?Q?jGnVrOLhWlFR0DKvdjvTiAzXeehStZ5GT3YBWDKeoLfc8VEOLBzWLUblWJ99?=
 =?us-ascii?Q?jXO00NGAknLDJmyL/sZvysX0k67BBAfpbhHhbJQ1H6F+5i+Q+pnfugmzQ0yB?=
 =?us-ascii?Q?ASFqBQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5192.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1fab227f-8695-4ac8-6bfd-08dbf2ee6fd1
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2023 04:23:29.4593
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cmFZQLCN4Td6bxVYR6T5Wgd0kEzJW7kBCfGzOhfGZnb21/ZktPYflRejUHkfUCRh7rtMnuUC0FlE293sKYizmq56pH/x2opTTGEgcUJpMZY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6522
X-Proofpoint-GUID: etungtlaxaBYQuD8-aVLbFQfCNSEJRPY
X-Proofpoint-ORIG-GUID: etungtlaxaBYQuD8-aVLbFQfCNSEJRPY
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-16_25,2023-11-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0
 priorityscore=1501 spamscore=0 impostorscore=0 lowpriorityscore=0
 bulkscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2311060001 definitions=main-2312020031
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Fri, 01 Dec 2023 20:24:27 -0800 (PST)


> -----Original Message-----
> From: Kees Cook <keescook@chromium.org>
> Sent: Saturday, December 2, 2023 1:48 AM
> To: sxwjean@me.com
> Cc: vbabka@suse.cz; 42.hyeyoo@gmail.com; cl@linux.com; linux-mm@kvack.org=
;
> penberg@kernel.org; rientjes@google.com; iamjoonsoo.kim@lge.com;
> roman.gushchin@linux.dev; corbet@lwn.net; arnd@arndb.de; akpm@linux-
> foundation.org; gregkh@linuxfoundation.org; linux-doc@vger.kernel.org; li=
nux-
> kernel@vger.kernel.org; Song, Xiongwei <Xiongwei.Song@windriver.com>
> Subject: Re: [RFC PATCH 2/3] mm/slub: unify all sl[au]b parameters with "=
slab_$param"
>=20
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender an=
d know the
> content is safe.
>=20
> On Fri, Dec 01, 2023 at 11:15:04AM +0800, sxwjean@me.com wrote:
> > From: Xiongwei Song <xiongwei.song@windriver.com>
> >
> > Since the SLAB allocator has been removed, so we need to clean up the
> > sl[au]b_$params. However, the "slab/SLAB" terms should be keep for
> > long-term rather than "slub/SLUB". Hence, we should use "slab_$param"
> > as the primary prefix, which is pointed out by Vlastimil Babka. For mor=
e
> > information please see [1].
> >
> > This patch is changing the following slab parameters
> > - slub_max_order
> > - slub_min_order
> > - slub_min_objects
> > - slub_debug
> > to
> > - slab_max_order
> > - slab_min_order
> > - slab_min_objects
> > - slab_debug
> > as the primary slab parameters in
> > Documentation/admin-guide/kernel-parameters.txt and source, and rename =
all
> > setup functions of them too. Meanwhile, "slub_$params" can also be pass=
ed
> > by command line, which is to keep backward compatibility. Also mark all
> > "slub_$params" as legacy.
>=20
> *If* we do this, I think the old names need to be recognized, perhaps
> with a boot pr_warn() about their deprecation/renaming for several
> releases (likely across LTSes). I think it's not a good idea to
> wholesale rename these with no warning. That's going to cause a lot of
> surprises and broken userspace...

Oh, yes, that's a good idea. Will update.

Regards,
Xiongwei
>=20
> --
> Kees Cook