Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <523f0517-fdbf-488b-87d1-f611c97ef810@gmail.com>
Date:   Sat, 2 Dec 2023 12:53:24 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [mm-unstable v4 5/5] mm: memcg: restore subtree stats flushing
Content-Language: en-US
To:     Waiman Long <longman@redhat.com>,
        Yosry Ahmed <yosryahmed@google.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Shakeel Butt <shakeelb@google.com>,
        Muchun Song <muchun.song@linux.dev>,
        Ivan Babrou <ivan@cloudflare.com>, Tejun Heo <tj@kernel.org>,
        =?UTF-8?Q?Michal_Koutn=C3=BD?= <mkoutny@suse.com>,
        kernel-team@cloudflare.com, Wei Xu <weixugc@google.com>,
        Greg Thelen <gthelen@google.com>,
        Domenico Cerasuolo <cerasuolodomenico@gmail.com>,
        Attreyee M <tintinm2017@gmail.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        Linux CGroups <cgroups@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20231129032154.3710765-1-yosryahmed@google.com>
 <20231129032154.3710765-6-yosryahmed@google.com> <ZWqPBHCXz4nBIQFN@archie.me>
 <436e96d1-29eb-49ec-a463-2ed420757ce8@redhat.com>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <436e96d1-29eb-49ec-a463-2ed420757ce8@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/2/23 09:56, Waiman Long wrote:
> 
> On 12/1/23 20:57, Bagas Sanjaya wrote:
>>> -void mem_cgroup_flush_stats(void)
>>> +/*
>>> + * mem_cgroup_flush_stats - flush the stats of a memory cgroup subtree
>>> + * @memcg: root of the subtree to flush
>>> + *
>>> + * Flushing is serialized by the underlying global rstat lock. There is also a
>>> + * minimum amount of work to be done even if there are no stat updates to flush.
>>> + * Hence, we only flush the stats if the updates delta exceeds a threshold. This
>>> + * avoids unnecessary work and contention on the underlying lock.
>>> + */
>> What is global rstat lock?
> 
> It is the cgroup_rstat_lock in kernel/cgroup/rstat.c.
> 

OK, I see that. Thanks!

-- 
An old man doll... just what I always wanted! - Clara