Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1589028rdb; Sat, 2 Dec 2023 01:46:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnjq8JwkmAC574M9E2USahy65bT7o4tOhHUbCv8tdD+MuhL/gP2ZrBjTPl+rrtX4PPWqFo X-Received: by 2002:aca:220f:0:b0:3ae:50f7:e3a4 with SMTP id b15-20020aca220f000000b003ae50f7e3a4mr1215858oic.22.1701510411226; Sat, 02 Dec 2023 01:46:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701510411; cv=none; d=google.com; s=arc-20160816; b=KY4UW0db47tVw13T8BdXeIB6+OFqAQmS78wlN5ntGikig0b641Irw7XjyF1pMhRern qwkzHLT7EQwwxL4263R9cShY3AO9nTkA6An8DoQYKeTjldhQFj7pKBwqQ1X/aRO50sJS DMRI0uOFIJsNwuSO5arD0CyXRzFQN1B36+kG21U99MsjXgbA6YEBUsCjmUUM7IVz+8Ya /7syOu/Q24W3AmnUBkLHietBTEfyfchfDbul6SZ9XVkGRYRhaZNHQ1qA/xNz4doJNvmh MXEd9fHfyODbRyL571TNDDZJYrScPp6wt80KjXHhDscK0P2bj/E4mjVJm927lwfjG/S+ kbgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=ISPqILfihvE5pzRClGLwWz5pvqpAxt7nmRZi6Fyvjtg=; fh=+WI4m5k3dRLR+dR3neThuZkNBTzIm/a8HgtddERL9fA=; b=m/p3QdU+PUVtGq1SXLDKfdVukd0wIl+MAMyK/HGSxuMtpZQf8h5esQOxmh6zHq71ZH 9q8IgT8b05h6onHsXOHomsw7dQ8NXTazPoZZPMLlt/KkQxlhMA9kGUAdTDHR7C6MVnQL YIo3wXCGlbUXbBnbvlfTwoHkyoUxEFYWCJ9YHDHheMPIdLaQiWZpztfPPbke1PR/4fWw ezvawEw55lPJAuPrtKgs4e/5YqwjoUxbAPm25SylThBWEK0CtcX1GQiVLnlA6qr5aJnI Mcm5XFLszQhSy7iRlo5FwVdtOmX+fwJcmG8kv2NgN+tYjPn0yt7QiiP62skfqB7OluOz m3Bg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fXwYKADO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id k62-20020a632441000000b005c6032d28c2si92250pgk.41.2023.12.02.01.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 01:46:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fXwYKADO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 562378024000; Sat, 2 Dec 2023 01:46:48 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232330AbjLBJqd (ORCPT + 99 others); Sat, 2 Dec 2023 04:46:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjLBJqc (ORCPT ); Sat, 2 Dec 2023 04:46:32 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBAA1181; Sat, 2 Dec 2023 01:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701510396; x=1733046396; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=D/v0y2NA6xRqP9bnDret0xs9lulZFX+zXryP5QvmzLE=; b=fXwYKADO/y9Mdvz1hDolBDulWghnXQkIyDM9NQojKK/7FwEwhyvhVSQD vIeErtLfJZBwbrm99G20ZEbhwF7eB1pRw+JZWnyI8x+NIUHsoUWy7kTEA Lpn/B1KyTbmO6NBybCw4amaFn++gDWH6t0WzfWvPjMy01AhCNvNdFLCxP 4k73P6yL4+GD1hFDU9LUuDqTRJl/es68ZPYqt5aPFo0PN8RKQO0tSEi7l B3oErvl5ciBW9if9Dip5Tx+Daq4lmz0grTUE+tUbLz9bS9YG0eAN7CR4P yIFMAxEh79+rXf6pL8Tw9zRt/5uICipT8NbJGtJYeXaRR83OYl3QQcNPz w==; X-IronPort-AV: E=McAfee;i="6600,9927,10911"; a="372982756" X-IronPort-AV: E=Sophos;i="6.04,245,1695711600"; d="scan'208";a="372982756" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2023 01:46:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10911"; a="773705785" X-IronPort-AV: E=Sophos;i="6.04,245,1695711600"; d="scan'208";a="773705785" Received: from yzhao56-desk.sh.intel.com ([10.239.159.62]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2023 01:46:33 -0800 From: Yan Zhao To: iommu@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: alex.williamson@redhat.com, jgg@nvidia.com, pbonzini@redhat.com, seanjc@google.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com, baolu.lu@linux.intel.com, dwmw2@infradead.org, yi.l.liu@intel.com, Yan Zhao Subject: [RFC PATCH 06/42] KVM: Register/Unregister importers to KVM exported TDP Date: Sat, 2 Dec 2023 17:17:38 +0800 Message-Id: <20231202091738.13770-1-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231202091211.13376-1-yan.y.zhao@intel.com> References: <20231202091211.13376-1-yan.y.zhao@intel.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 02 Dec 2023 01:46:48 -0800 (PST) Each TDP exported by KVM has its own list of importers. External components can register/unregister itself as an importer with a unique importer ops. The sequence for external components to register/unregister as importer is like: 1. call kvm_tdp_fd_get() to get a KVM TDP fd object. 2. call tdp_fd->ops->register_importer() to register itself as an importer. 3. call tdp_fd->ops->unregister_importer() to unregister itself as importer. 4. call kvm_tdp_fd_put() to put the KVM TDP fd object. When destroying a KVM TDP fd object, all importers are force-unregistered. There's no extra notification to the importers at that time because the force-unregister should only happen when importers calls kvm_tdp_fd_put() without calling tdp_fd->ops->unregister_importer() first. Signed-off-by: Yan Zhao --- include/linux/kvm_host.h | 5 +++ virt/kvm/tdp_fd.c | 68 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 72 insertions(+), 1 deletion(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 5a74b2b0ac81f..f73d32eef8833 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -2334,6 +2334,11 @@ struct kvm_exported_tdp { struct kvm *kvm; u32 as_id; + + /* protect importers list */ + spinlock_t importer_lock; + struct list_head importers; + /* head at kvm->exported_tdp_list */ struct list_head list_node; }; diff --git a/virt/kvm/tdp_fd.c b/virt/kvm/tdp_fd.c index 7e68199ea9643..3271da1a4b2c1 100644 --- a/virt/kvm/tdp_fd.c +++ b/virt/kvm/tdp_fd.c @@ -13,6 +13,13 @@ static inline int is_tdp_fd_file(struct file *file); static const struct file_operations kvm_tdp_fd_fops; static const struct kvm_exported_tdp_ops exported_tdp_ops; +struct kvm_tdp_importer { + struct kvm_tdp_importer_ops *ops; + void *data; + struct list_head node; +}; +static void kvm_tdp_unregister_all_importers(struct kvm_exported_tdp *tdp); + int kvm_create_tdp_fd(struct kvm *kvm, struct kvm_create_tdp_fd *ct) { struct kvm_exported_tdp *tdp; @@ -56,6 +63,9 @@ int kvm_create_tdp_fd(struct kvm *kvm, struct kvm_create_tdp_fd *ct) if (ret) goto out; + INIT_LIST_HEAD(&tdp->importers); + spin_lock_init(&tdp->importer_lock); + tdp_fd->file = anon_inode_getfile("tdp_fd", &kvm_tdp_fd_fops, tdp_fd, O_RDWR | O_CLOEXEC); if (!tdp_fd->file) { @@ -107,6 +117,7 @@ static int kvm_tdp_fd_release(struct inode *inode, struct file *file) list_del(&tdp->list_node); spin_unlock(&tdp->kvm->exported_tdplist_lock); + kvm_tdp_unregister_all_importers(tdp); kvm_arch_exported_tdp_destroy(tdp); kvm_put_kvm(tdp->kvm); kfree(tdp); @@ -141,12 +152,67 @@ static inline int is_tdp_fd_file(struct file *file) static int kvm_tdp_register_importer(struct kvm_tdp_fd *tdp_fd, struct kvm_tdp_importer_ops *ops, void *data) { - return -EOPNOTSUPP; + struct kvm_tdp_importer *importer, *tmp; + struct kvm_exported_tdp *tdp; + + if (!tdp_fd || !tdp_fd->priv || !ops) + return -EINVAL; + + tdp = tdp_fd->priv; + importer = kzalloc(sizeof(*importer), GFP_KERNEL); + if (!importer) + return -ENOMEM; + + spin_lock(&tdp->importer_lock); + list_for_each_entry(tmp, &tdp->importers, node) { + if (tmp->ops != ops) + continue; + + kfree(importer); + spin_unlock(&tdp->importer_lock); + return -EBUSY; + } + + importer->ops = ops; + importer->data = data; + list_add(&importer->node, &tdp->importers); + + spin_unlock(&tdp->importer_lock); + + return 0; } static void kvm_tdp_unregister_importer(struct kvm_tdp_fd *tdp_fd, struct kvm_tdp_importer_ops *ops) { + struct kvm_tdp_importer *importer, *n; + struct kvm_exported_tdp *tdp; + + if (!tdp_fd || !tdp_fd->priv) + return; + + tdp = tdp_fd->priv; + spin_lock(&tdp->importer_lock); + list_for_each_entry_safe(importer, n, &tdp->importers, node) { + if (importer->ops != ops) + continue; + + list_del(&importer->node); + kfree(importer); + } + spin_unlock(&tdp->importer_lock); +} + +static void kvm_tdp_unregister_all_importers(struct kvm_exported_tdp *tdp) +{ + struct kvm_tdp_importer *importer, *n; + + spin_lock(&tdp->importer_lock); + list_for_each_entry_safe(importer, n, &tdp->importers, node) { + list_del(&importer->node); + kfree(importer); + } + spin_unlock(&tdp->importer_lock); } static void *kvm_tdp_get_metadata(struct kvm_tdp_fd *tdp_fd) -- 2.17.1