Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754285AbXLAUQg (ORCPT ); Sat, 1 Dec 2007 15:16:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751470AbXLAUQV (ORCPT ); Sat, 1 Dec 2007 15:16:21 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:54669 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751457AbXLAUQT (ORCPT ); Sat, 1 Dec 2007 15:16:19 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Stephen Hemminger Cc: Alan Cox , Mark Lord , Greg Kroah-Hartman , Greg KH , Tejun Heo , Linux Containers , netdev@vger.kernel.org, cornelia.huck@de.ibm.com, stern@rowland.harvard.edu, kay.sievers@vrfy.org, linux-kernel@vger.kernel.org, Andrew Morton , Herbert Xu , David Miller , Linus Torvalds Subject: Re: namespace support requires network modules to say "GPL" References: <47515D39.9030900@rtr.ca> <20071201111736.297dd99a@freepuppy.rosehill> <20071201192341.6750fbdb@the-village.bc.nu> <20071201113815.5df0960a@freepuppy.rosehill> Date: Sat, 01 Dec 2007 13:13:46 -0700 In-Reply-To: <20071201113815.5df0960a@freepuppy.rosehill> (Stephen Hemminger's message of "Sat, 1 Dec 2007 11:38:15 -0800") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1741 Lines: 42 Stephen Hemminger writes: > Actually, the whole mess would go away if the api for dev_get_by_XXXX hadn't > been changed in the namespace transition. IMHO the interface to > dev_get_by_name() > should not have added a namespace parameter, of the callers in the tree, only > two use a different namespace. So it would have been better to to introduce > dev_get_by_name_ns() with the extra parameter. As a general rule if you are calling dev_get_by_name and taking an &init_net parameter that means you code has not yet been converted to actually support network namespaces. Not everything can be safely changed at once so we take it by steps. When the code fully supports network namespaces practically nothing will take an &init_net parameter. The network namespace parameter will come in some form from userspace. Either from current or from the network socket. Except for boot time initialization I don't know of any cases using dev_get_by_XXXX that won't need to be modified before the network namespace work is complete. I believe I mentioned that this getting the fully network namespace support was going to take a while and a bunch of patches at the outset. > Can we get this resolved before 2.6.24 is released? Going back and forth > on API's is just needless frottage. Sure. We keep the updated dev_get_by_XXXX that takes a network namespace parameter. Or is their some legitimate usage of it by out of tree code that I'm not aware of? Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/