Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Sat, 2 Dec 2023 18:23:32 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     David Wu <david.wu@rock-chips.com>
Cc:     netdev@vger.kernel.org, sebastian.reichel@collabora.com,
        davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: stmmac: dwmac-rk: Repair the clock
 handling
Message-ID: <334c740b-eda2-450d-b000-2ed39b86779e@lunn.ch>
References: <20231202091806.179512-1-david.wu@rock-chips.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231202091806.179512-1-david.wu@rock-chips.com>
Precedence: bulk

On Sat, Dec 02, 2023 at 05:18:06PM +0800, David Wu wrote:
> It's clarier and simpler to replace devm_clk_bulk_get_optional
> via devm_clk_bulk_get_all. And it may be a different clocks
> combination for different Socs, so for the clk_mac_speed, it is
> more correct to obtain the clock directly by its name.

Is this fixing a real bug? What is that bug?

This is a big change, and it is not obviously correct. Please take a
look at the stable rules:

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Could you create a minimal fix for stable, and direct this change to
net-next?


    Andrew

---
pw-bot: cr