Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1835166rdb; Sat, 2 Dec 2023 11:09:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFtTX6MKUCQ2NO0ylVN2D6tcCqxclGFG79Lq2WO9hriwWysxRBob7loFJIYSmQzCipoOP42 X-Received: by 2002:a05:6808:14c4:b0:3b8:43b5:363c with SMTP id f4-20020a05680814c400b003b843b5363cmr1952331oiw.4.1701544167154; Sat, 02 Dec 2023 11:09:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701544167; cv=none; d=google.com; s=arc-20160816; b=rnvqp6qomZj0ugouI2rv4u26bzrlHAyOAg5tK02V01SK1zR4YHQvvi1RwBKOZRbpYr jLlcl3DFJ+VoCyBLio8N+G7K+C/5xX2MSFo/L8D9ZXvmA/wjgpQt6Pz81XanmDC3ikU1 bfpJGniZK+0oxAGUOA0PRagOOAIwUyg9F/p8OWU5icAgbmGUVfrnrbYuTyy2qyDDu+Yb vKc31NtnmfdIbKkXzq1ru4wIy6QcUy60lGeYRGQqfE0Of5ZQcuurud/hjCJ3lrh1xCeq ehjmcNJkp+NtlWLGMSen2J8JsgCJssHyE7I6cWNdqIqyHph5gK3rWmSFZjewWrG9ATBq GuYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hILZhULZeuU4D7CkSzLlqvX1D9imsudessJgvQHUhpk=; fh=eC8MWupst1PhTHgFrJuNp/mBpTABBdacHnKnNMROpcg=; b=z9fBGS8mEE1e7dxKWrcMrr1OxrFjMTlMBiC6lB6s6xss0LcPFKwSKs6NmviNx9QSwy KuV7lLTLKGGe3zM2FsCs8Qh5jsEFusfaVb4SAUk7dlklqTkHBBn+oTYRwCX1WZp3esZH uaZv1OfSwZwUQXO+JzYoh7G0kQSNdFTnvygEXXgwWOGY42ewI82jF7VueOX8NFa2h12h oqwopSeKHwFBD4dkXlLWfMmH3ODp65all08pJ2NAkd/Q7FOqzLG1cfrKCHxF8DaEsJfy cV86V3x5WtmwNUFjU/XaQKYhscmn5TadlRRZzzIPg2vtUAk625Rir26fkl6y+PDeBduQ Wbgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=KdTHcpqK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id p11-20020a056a000b4b00b006cb8abd39d3si3144266pfo.180.2023.12.02.11.09.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 11:09:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=KdTHcpqK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1C16F806290A; Sat, 2 Dec 2023 11:09:26 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbjLBTJP (ORCPT + 99 others); Sat, 2 Dec 2023 14:09:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjLBTJO (ORCPT ); Sat, 2 Dec 2023 14:09:14 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20B0311D; Sat, 2 Dec 2023 11:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=hILZhULZeuU4D7CkSzLlqvX1D9imsudessJgvQHUhpk=; b=KdTHcpqKq2XjRLSkRGdDGlFGak 0yjtouapM61SGNda1mGd1bdbqIc/Fj2AEZDjaIkm/05NQFwvAlDSKnlXJyy02dpZ+8/YR7hV0AFRK Wshw2dyDSPw5IkQTl/UGIKImneDPTnyuTS7eegj1VehSX0n9VaknHnVApcumt+iQN7BM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r9VMU-001rX6-6S; Sat, 02 Dec 2023 20:09:10 +0100 Date: Sat, 2 Dec 2023 20:09:10 +0100 From: Andrew Lunn To: Jakub Kicinski Cc: Justin Lai , davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pkshih@realtek.com, larry.chiu@realtek.com Subject: Re: [PATCH net-next v13 01/13] rtase: Add pci table supported in this module Message-ID: <0a2b5646-9d24-4a22-b1e3-87517e7cadb1@lunn.ch> References: <20231130114327.1530225-1-justinlai0215@realtek.com> <20231130114327.1530225-2-justinlai0215@realtek.com> <20231201203602.7e380716@kernel.org> <27b2b87a-929d-4b97-9265-303391982d27@lunn.ch> <20231202105845.12e27e31@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231202105845.12e27e31@kernel.org> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 02 Dec 2023 11:09:26 -0800 (PST) > I'm mainly asking to make sure we avoid "implicitly programming" the > switch, like, IIUC, one of the TI drivers did. And we ended up with > multiple versions / modes of operation :( Sounds like this driver > doesn't touch switch registers yet, tho, so all good. I asked questions about this earlier, should it be a pure switchdev switch, or a DSA switch, etc. So i think we have that basic questions covered. Andrew