Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1891066rdb; Sat, 2 Dec 2023 13:46:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IFohnnL9L16S7fC/eJ1uNxdYKXUSfa9wEI5ATud2Ad9KJzx1CMASqH5Y222A1gwtLbBm8PB X-Received: by 2002:a05:6a00:180c:b0:6ce:2731:47b7 with SMTP id y12-20020a056a00180c00b006ce273147b7mr1988023pfa.23.1701553592804; Sat, 02 Dec 2023 13:46:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701553592; cv=none; d=google.com; s=arc-20160816; b=LQjSg7OkLlAYMCsuz6oYRG4Sqk4kgrKTw65Nc3mEfg5r8X6qg3rhxjj4cIKemwitna +uo2soOn2Y179MFhpwNrxpn0HlmYBk/DVMdBdstEPQR6T90wBcCT4vdKRaqXvC+x2HvX 9a4hDbk+TVis++h5gGxOpZebKk8Mz2yf2MSwPsIjG+QuUTEesMVEFyNPINVBsYJSkgUM fhc1dxbVZtJtDETPlJntVoz7WvPNvUYaR9A5IDWCXng52m0aU06j2QG8yunYvZ2zrE1+ mF2Cic5hH16DNxHicX9srUzt5nZ6a9ghjQc5+DG7x7+kE3jRwoeKdAIUDial8CCRDMIL y6Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4Rwyik1Cyaf8rPAzDwFjNdQAfgF5Q1clOrCxMqMQ94o=; fh=FF1Fm43wjDVBknCypeo6GYbgR2lUx2vVEAg8epl3//0=; b=BCQ5y53NzA7AvWUY2PBLYy36cfMmXTittYVG9Uuuwmmep7/baFqVWF3WeSAGDUCWO9 GlgHQiWc7RiBdpm+LEd+dafxGiYLJ7aeknma3b/OzMp6xnfK7qafZR11wJqk/grJC3HH DqFe1iUL4/HeJTQGCeW+yr1NOKbgO+zM1qxzTWW69n4nP91fU422klkJQye+/bQYbHKw F4mq/8N1nHxrEOHvS+oBZ9g9AAJ6o8Lg+TRu5lMj/Zxi1btvNUKvQZdQS4a0ZiTwNnyU uw58PnSXRcOqVPxc710JX92bw1XGGHHpgGzefblSGsBy4W3h8yWqHBB/BGjhWxo5IRmE 3FLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=Z1FoUWKO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id y14-20020a056a00180e00b006cd8454cbbcsi5477170pfa.212.2023.12.02.13.46.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Dec 2023 13:46:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=Z1FoUWKO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E202E80792EC; Sat, 2 Dec 2023 13:45:15 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229531AbjLBVpF (ORCPT + 99 others); Sat, 2 Dec 2023 16:45:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjLBVpD (ORCPT ); Sat, 2 Dec 2023 16:45:03 -0500 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C97BE8; Sat, 2 Dec 2023 13:45:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4Rwyik1Cyaf8rPAzDwFjNdQAfgF5Q1clOrCxMqMQ94o=; b=Z1FoUWKOMFkaUPPOx1TpIBqZYj oE/rw6p6G0Gdbrxv1xh+gWe62MwcSRjvo66FsO/w+Y0rbVbvivKZ8F5dlKiE11g9E3j9mwDfoz7zN HJgQyvOwilDkm4U5MxnnAmc5fKMpI4fhp8h4CtxvxtIV2fS0eB1FAIPvTc2a9UxQlLNFSQCGXFTja 4xSL1DjiYZLcOIC8lBMtb0KacxdxNt7dPRvugTbkKLVicFsWzGTo62N+PcjFPWkRpeGw3P4kaBNz6 prVtjHDOySrh1PSdPhho5ImtrQ6w0uwx5Wa2fkn1LVb8lXYTJfDoSZYn5ls50lnnw5fpdRlyihuBw LnFtuiOg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1r9XnK-006OGD-15; Sat, 02 Dec 2023 21:45:02 +0000 Date: Sat, 2 Dec 2023 21:45:02 +0000 From: Al Viro To: Kees Cook Cc: "Guilherme G. Piccoli" , Christian Brauner , Peter Zijlstra , linux-fsdevel@vger.kernel.org, Tony Luck , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 3/5] fs: Add DEFINE_FREE for struct inode Message-ID: <20231202214502.GS38156@ZenIV> References: <20231202211535.work.571-kees@kernel.org> <20231202212217.243710-3-keescook@chromium.org> <20231202212846.GQ38156@ZenIV> <202312021331.D2DFBF153@keescook> <20231202214212.GR38156@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231202214212.GR38156@ZenIV> Sender: Al Viro X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 02 Dec 2023 13:45:16 -0800 (PST) On Sat, Dec 02, 2023 at 09:42:12PM +0000, Al Viro wrote: > I'll poke around and see what I can suggest; said that, one thing I have > spotted there on the quick look is that you are exposing hashed dentry associated > with your inode before you set its ->i_private. ... and on the second look, no, you do not do anything of that sort. My apologies...