Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Sat, 2 Dec 2023 15:35:23 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        "Linus Torvalds" <torvalds@linux-foundation.org>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH 2/2] x86/microcode: Rework early revisions reporting
Message-ID: <ZWu/O9XeMBfbs3H7@a4bf019067fa.jf.intel.com>
References: <20231115210212.9981-1-bp@alien8.de>
 <20231115210212.9981-3-bp@alien8.de>
 <ZWjVt5dNRjbcvlzR@a4bf019067fa.jf.intel.com>
 <20231201163928.GCZWoMQNAAQSA9U12D@fat_crate.local>
 <ZWpDHgNjhQKLodF6@a4bf019067fa.jf.intel.com>
 <20231201204146.GGZWpFCqodLUPS27tJ@fat_crate.local>
 <ZWpQ9Wbb7u4ss0mt@a4bf019067fa.jf.intel.com>
 <20231202163850.GCZWtdmrMoJqyAiycZ@fat_crate.local>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231202163850.GCZWtdmrMoJqyAiycZ@fat_crate.local>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?elbwp0uS89L/Fi3otk9M9u+j0EimcTDPWMdwarLTEVhT9rREDZzgvFcN6JYT?=
 =?us-ascii?Q?+XNL0Fx5prLP+v3eRgQ50pDnex6s5mdwsN7nUXKa4oHS6qys6D1zzGTBQSgf?=
 =?us-ascii?Q?lura0AmY716AxM5WSXx02UBZ3fmfCjKW8WGwT4p3UKrXgrgY+vO2TqCq9HLU?=
 =?us-ascii?Q?CNC0MJWIPKYzoy1runa/KPqjoeXcMeKJ0S/ud/XYHSl/23yG5Awvl4kH+wKP?=
 =?us-ascii?Q?HPFjWQ3iKvjd0xF9Nf/XdE9zfgT0+0aj3lCPHIkdwIUbZSVuhu8goPs078hn?=
 =?us-ascii?Q?krYE9WzdIEX/xdXGV4lk4NzH4jFrrccB8XOQwMan1eQHQEp0xe04V0d2MV4i?=
 =?us-ascii?Q?voeLCsccpPRJjt1z95Aj6BzW1MHKYmZHXcLQf6TIAEvKYSdMm32UcuV1CASv?=
 =?us-ascii?Q?Hq2RodxI2NjtOJ6mkfULDP7CF8YsRMMch5xAkJYBvhfN/z9Zk8JRGnhHGg3d?=
 =?us-ascii?Q?UhULr6S9HN/58tlHIYOtKU7P40KrVeEt3npTwjad+1MyJefiPpdMSKrw6dGX?=
 =?us-ascii?Q?QsOu06qP8cACTz+FFTPt6KkBW9LCfQJ/O7ThjAotp3dF9wEuEhpcjqNEoaqh?=
 =?us-ascii?Q?TFgnjrFExkaLB49aTvtmTfxm41Y5ukixwJ9cUK6kPBtOwCtGpIutxDNw6AlD?=
 =?us-ascii?Q?1cNFfkyrxeKM866qn8lfeDrbzbrRoEdQ1B6JfdnqO137dguSUCXEckevTa7t?=
 =?us-ascii?Q?ugOEo+wiFzkVrlcWzuzZev1JTb5qVZh5X8ROi2A1bGfzEoHwUY1ttT7nL5vx?=
 =?us-ascii?Q?1Cf+jlQV+D8qsbNPqWNXJxzWLgEb3lPvTV2407fWTEKqJKPRh1/8Gm1Xw1E2?=
 =?us-ascii?Q?E56VWaHbxvWNOBNioHMbu1MomlmTpGxDZwk3ZSryumD9nIwyx+53sMU5L7d/?=
 =?us-ascii?Q?yl5dh4iVBm4gt1URW8sObECAiMo+GkyCeoiXt5u3rlMeqfgjGt9VKEBDEDeR?=
 =?us-ascii?Q?Rjk2TAqT5tYabi4ol+qqzBzi+Br8kWJIEl97QkAkoQ19yI4x9SiiFVepyDnd?=
 =?us-ascii?Q?MdfCzb2lc3AQkc8laPomWM50/b58eDc91mnQ7vxRuWzj4vdtFJj41EMsnxgS?=
 =?us-ascii?Q?3r4hjnxFOf1A8QSSAa7gQLre9a6VHZAEdx48UJym/q4k7v4ZxU33pd+XHHWL?=
 =?us-ascii?Q?v1s0Snv0mZeT6FYNoxQxyVKAxs+Fo/ItzKvgyXnSQqUh5CcJs5xafdgwgWcF?=
 =?us-ascii?Q?sSUX9rVpn/zdRp7vyfMIgorZx0cZtAxiZ+DbAKlySuTyxIbDFl1AYFl91g1W?=
 =?us-ascii?Q?kfjMMhKiMlUE9e8RbhLLzrBohPWuHbzgqLjV2//Ln25Nq061okg78YNQujJn?=
 =?us-ascii?Q?HC3Y8dFsiLzprv1DA2yxgTaQpoCKrdSQEIc8udfIktzrcpK5PPNiFGdILLO9?=
 =?us-ascii?Q?G2I3PcBrt+ca32kEglvj9C9OzMokhs0z2MJqk3dp5zWUvTKsj1D/gr+cDotH?=
 =?us-ascii?Q?3cI7SuIFoo9KJbpba/SiGPnGC8gNjoXlB1zIa8RNw0aaNWxVwHqOOyElbWf9?=
 =?us-ascii?Q?tFS3VYzzQO+MQnNgBmkzhf4pQIySGNA/cfvaX/iUhxy2Z0IJibIr/zL1zxn5?=
 =?us-ascii?Q?Or1hZucFf7gHXw4JdK4qjmysPiBKEWlEUVhXjozw?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b2b38a7d-9f99-4caa-fcc9-08dbf38f62ed
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2023 23:35:37.1911
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1I4Mm3hQH3064WRzRW4boeFIL5kdcZYN8pjEynXnwYIuaEalMehLnxETwW+u4N+p25KX5/R21Lh+g7Zv+eZZvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8348
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 02 Dec 2023 15:46:07 -0800 (PST)

On Sat, Dec 02, 2023 at 05:38:50PM +0100, Borislav Petkov wrote:
> On Fri, Dec 01, 2023 at 01:32:37PM -0800, Ashok Raj wrote:
> > dmesg for the microcode part here below:
> > 
> > https://paste.debian.net/hidden/e911dffc/
> 
> Thanks, it is all clear now.
> 
> This should fix it:

Yes, this works as expected.

> 
> ---
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> Date: Fri, 1 Dec 2023 14:35:06 +0100
> Subject: [PATCH] x86/microcode/intel: Set new revision only after a successful update
> 
> This was meant to be done only when early microcode got updated
> successfully. Move it into the if-branch.
> 
> Also, make sure the current revision is read unconditionally and only
> once.
> 
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>

Tested-by: Ashok Raj <ashok.raj@intel.com>