Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Sat, 2 Dec 2023 23:38:12 +0000
From:   Qais Yousef <qyousef@layalina.io>
To:     Vincent Guittot <vincent.guittot@linaro.org>
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
        corbet@lwn.net, alexs@kernel.org, siyanteng@loongson.cn,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        lukasz.luba@arm.com, hongyan.xia2@arm.com, yizhou.tang@shopee.com
Subject: Re: [PATCH v2 2/2] sched/fair: Simplify util_est
Message-ID: <20231202233812.cq2nodia3estdexy@airbuntu>
References: <20231201161652.1241695-1-vincent.guittot@linaro.org>
 <20231201161652.1241695-3-vincent.guittot@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231201161652.1241695-3-vincent.guittot@linaro.org>
Precedence: bulk

On 12/01/23 17:16, Vincent Guittot wrote:

>  /*
>   * The load/runnable/util_avg accumulates an infinite geometric series
>   * (see __update_load_avg_cfs_rq() in kernel/sched/pelt.c).
> @@ -505,9 +469,20 @@ struct sched_avg {
>  	unsigned long			load_avg;
>  	unsigned long			runnable_avg;
>  	unsigned long			util_avg;
> -	struct util_est			util_est;
> +	unsigned int			util_est;
>  } ____cacheline_aligned;

unsigned long would be better?