Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753516AbXLAWXS (ORCPT ); Sat, 1 Dec 2007 17:23:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751460AbXLAWXA (ORCPT ); Sat, 1 Dec 2007 17:23:00 -0500 Received: from gate.crashing.org ([63.228.1.57]:41584 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbXLAWW7 (ORCPT ); Sat, 1 Dec 2007 17:22:59 -0500 Date: Sun, 2 Dec 2007 01:22:35 +0300 From: Vitaly Bordug To: cbou@mail.ru Cc: Jochen Friedrich , linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, Jeff Garzik , netdev@vger.kernel.org Subject: Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality Message-ID: <20071202012235.4ad9abc3@kernel.crashing.org> In-Reply-To: <20071201213403.GA2350@zarina> References: <20071126142906.19642.45540.stgit@localhost.localdomain> <47516646.9000803@scram.de> <20071201213403.GA2350@zarina> X-Mailer: Claws Mail 3.1.0cvs26 (GTK+ 2.12.1; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1234 Lines: 27 On Sun, 2 Dec 2007 00:34:03 +0300 Anton Vorontsov wrote: > > If i understand your code correctly, you seem to rely on the fact > > that fixed_phy_add() is called before the fixed MDIO bus is scanned > > for devices. > > Yes, indeed. The other name of "fixed phys" are "platform phys" > or "platform MDIO bus" on which virtual PHYs are placed. > > That is, these phys supposed to be created by the platform setup > code (arch/). The rationale here is: we do hardware emulation, thus > to make drivers actually see that "hardware", we have to create it > early. well that was the intention but... The point is - as device is emulated, (nearly) everything is doable, and the only tradeoff to consider, is how far will we go with that emulation. IOW, PHYlib could be tricked to "do the right thing", and I thought about adding module flexibility... But thinking more about it, it seems that BSP-code-phy-creation just sucks less and is clear enough yet flexible. -- Sincerely, Vitaly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/