Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <20231102032330.1036151-1-chengming.zhou@linux.dev> <20231102032330.1036151-5-chengming.zhou@linux.dev>
In-Reply-To: <20231102032330.1036151-5-chengming.zhou@linux.dev>
From:   Hyeonggon Yoo <42.hyeyoo@gmail.com>
Date:   Sun, 3 Dec 2023 15:01:23 +0900
Message-ID: <CAB=+i9SDzPNSL03U9T6XAhfW8oed42yhc9F0ou5-2bqWkUJ=ZQ@mail.gmail.com>
Subject: Re: [PATCH v5 4/9] slub: Prepare __slab_free() for unfrozen partial
 slab out of node partial list
To:     chengming.zhou@linux.dev
Cc:     vbabka@suse.cz, cl@linux.com, penberg@kernel.org,
        rientjes@google.com, iamjoonsoo.kim@lge.com,
        akpm@linux-foundation.org, roman.gushchin@linux.dev,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Chengming Zhou <zhouchengming@bytedance.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 2, 2023 at 12:24=E2=80=AFPM <chengming.zhou@linux.dev> wrote:
>
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> Now the partially empty slub will be frozen when taken out of node partia=
l
> list, so the __slab_free() will know from "was_frozen" that the partially
> empty slab is not on node partial list and is a cpu or cpu partial slab
> of some cpu.
>
> But we will change this, make partial slabs leave the node partial list
> with unfrozen state, so we need to change __slab_free() to use the new
> slab_test_node_partial() we just introduced.
>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
> Tested-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> ---
>  mm/slub.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index eed8ae0dbaf9..1880b483350e 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -3631,6 +3631,7 @@ static void __slab_free(struct kmem_cache *s, struc=
t slab *slab,
>         unsigned long counters;
>         struct kmem_cache_node *n =3D NULL;
>         unsigned long flags;
> +       bool on_node_partial;
>
>         stat(s, FREE_SLOWPATH);
>
> @@ -3678,6 +3679,7 @@ static void __slab_free(struct kmem_cache *s, struc=
t slab *slab,
>                                  */
>                                 spin_lock_irqsave(&n->list_lock, flags);
>
> +                               on_node_partial =3D slab_test_node_partia=
l(slab);
>                         }
>                 }
>
> @@ -3706,6 +3708,15 @@ static void __slab_free(struct kmem_cache *s, stru=
ct slab *slab,
>                 return;
>         }
>
> +       /*
> +        * This slab was partially empty but not on the per-node partial =
list,
> +        * in which case we shouldn't manipulate its list, just return.
> +        */
> +       if (prior && !on_node_partial) {
> +               spin_unlock_irqrestore(&n->list_lock, flags);
> +               return;
> +       }
> +
>         if (unlikely(!new.inuse && n->nr_partial >=3D s->min_partial))
>                 goto slab_empty;
>

Looks good to me,
Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com>

> --
> 2.20.1
>