Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754588AbXLAX2F (ORCPT ); Sat, 1 Dec 2007 18:28:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752678AbXLAX1x (ORCPT ); Sat, 1 Dec 2007 18:27:53 -0500 Received: from chilli.pcug.org.au ([203.10.76.44]:57667 "EHLO smtps.tip.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707AbXLAX1w (ORCPT ); Sat, 1 Dec 2007 18:27:52 -0500 Date: Sun, 2 Dec 2007 10:27:39 +1100 From: Stephen Rothwell To: cbou@mail.ru Cc: Jochen Friedrich , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jeff Garzik , linuxppc-dev@ozlabs.org Subject: Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality Message-Id: <20071202102739.490ae468.sfr@canb.auug.org.au> In-Reply-To: <20071201213403.GA2350@zarina> References: <20071126142906.19642.45540.stgit@localhost.localdomain> <47516646.9000803@scram.de> <20071201213403.GA2350@zarina> X-Mailer: Sylpheed 2.4.7 (GTK+ 2.12.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Sun__2_Dec_2007_10_27_39_+1100_P8UzWhXZL=bMA0n_" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1656 Lines: 60 --Signature=_Sun__2_Dec_2007_10_27_39_+1100_P8UzWhXZL=bMA0n_ Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Just a little reminder ... On Sun, 2 Dec 2007 00:34:03 +0300 Anton Vorontsov wrote: > > static int __init of_add_fixed_phys(void) > { > struct device_node *np; > const u32 *prop; > struct fixed_phy_status status =3D {}; >=20 > while ((np =3D of_find_node_by_name(NULL, "ethernet"))) { for_each_node_by_name(np, "ethernet") { (this probably does what you want instead of finding just the first ethernet over and over again. :-)) > data =3D of_get_property(np, "fixed-link", NULL); > if (!data) > continue; >=20 > status.link =3D 1; > status.duplex =3D data[1]; > status.speed =3D data[2]; >=20 > ret =3D fixed_phy_add(PHY_POLL, data[0], &status); > if (ret) > return ret; if (ret) { of_put_node(np); retun ret; } > } --=20 Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ --Signature=_Sun__2_Dec_2007_10_27_39_+1100_P8UzWhXZL=bMA0n_ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFHUe3yTgG2atn1QN8RAnKXAJ0atAh7fRzQ8PgPUE1+yoK4aNVJQgCfY29E kx+R21nK1BHD63ePkedAKeE= =D5Cu -----END PGP SIGNATURE----- --Signature=_Sun__2_Dec_2007_10_27_39_+1100_P8UzWhXZL=bMA0n_-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/