Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2208071rdb; Sun, 3 Dec 2023 07:06:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGeDlUhIZ5E1D7uO1dRR8g/gmJs68Vf0nD1u3CMQnkXWRRybBh6HSfG7LCcLJByrM6zSRtS X-Received: by 2002:a17:902:e844:b0:1cf:c3fb:a982 with SMTP id t4-20020a170902e84400b001cfc3fba982mr2696517plg.63.1701615986822; Sun, 03 Dec 2023 07:06:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701615986; cv=none; d=google.com; s=arc-20160816; b=RDqruFts/vApVGDBa9xjUMChBo9Irl9QMV2Q10E3OHVXohD3lc9yehPowqf0IplH3X hbLhEXVbS0PsMHR6EBl6DGL5yZCouc+5uEePyWRHgq7+3u8k/y4bZHBzXSPo1FoRUhTa a6oAFHe6hokIEsfCj5V2nlsDb8BkTYr0Niv10O5GxdKbJhAH2ywpYyeLuJCsYr24nA1w TPVEjdZ9nR89MCMMGfcG/bpWkL86IXa51VM63L7LUNfAuzXAQcLLYLz29JegDtHN/Y83 DJRJ8ZzIxtFUziTWGAR/gQtEgEGZxd3ije3nVhV/Q0pueNTe70vZ3hAN2DNHTa9sWzLx viRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=jX9IpjfH+8GSToZOwniHDWJpuDtqbu6qE49XYEJKFo0=; fh=tm5+ybPKiUsG0bo/W2Kxx3bDO4lMv6Ni6hwOmmWjw3U=; b=ONEP7scbCiOOSCiyarlhPyACv9WTzOLleI317Cub01fQNHUAcy+d8gHqE20BbZzjmr B4RW3ygqVgnaAOSUSLQc1qv6mAoY0HMPa2kdNTkGx+MmIpWHRExibS/RVg23XM7wKbse ry//hWuDDc0fv6MBJdiF74umLrhU8QKofLrOlzR3Uz5JManFwLny5HmOGOAtEffdkWqm l14jcUfG/e8isFybDWXfOE3a28t5tjO/PUMo5kW+X1MEUWL9qpQDG6amyxTw8uRziSh4 WQO6OoYi5H4MoX3AYgeAPf+pW4QIef4HjWe3O3Z6uqSh1PP6YiJugrGzwp/pAa5x0aIk PNnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DFOxKVf4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id bx33-20020a056a02052100b005c67e10f23bsi1148201pgb.362.2023.12.03.07.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 07:06:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DFOxKVf4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 82529805A78B; Sun, 3 Dec 2023 07:06:24 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233617AbjLCPFA (ORCPT + 99 others); Sun, 3 Dec 2023 10:05:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233593AbjLCPFA (ORCPT ); Sun, 3 Dec 2023 10:05:00 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52362EA for ; Sun, 3 Dec 2023 07:05:03 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-54ca43031d1so535528a12.0 for ; Sun, 03 Dec 2023 07:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701615901; x=1702220701; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jX9IpjfH+8GSToZOwniHDWJpuDtqbu6qE49XYEJKFo0=; b=DFOxKVf4qKVLK1Z6Sz14Rfh+wa6P6MfdOTuCvvr1bdph7DrHjRvaUz1kucHJF757eI IahQb855qxPiHOsRk3BpyjN6Kttc91V4+nVmDaWHCOFmqyeGfZj2E5/jiQQtBnINakfY rYxtq9+b5bRMGjhDJiJZZdNV7yRtJidJm0M7QtIdowtWsiL9Yv34T05F/4re59vyZ4io l8mjQ7n60PJgWwVBkgGJUpYG97pWK92SsbQ/FHSuRUVtnybelJCd4hzNSMM1iqVXFCNF 9sjw1cLEhFSCjlnBsVA9EMYBZooC1fnNb6y34iur4vgBCZMTeyD8JRdGn1EVbcXnF4+4 c9bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701615901; x=1702220701; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jX9IpjfH+8GSToZOwniHDWJpuDtqbu6qE49XYEJKFo0=; b=TRrw7VZKsRohG0fDFBwv4cuqkkyovBq/WWlYHJbDWqSUgEDwcY7CTjAk3Lme5ZeC/y XiGpK/wsT2AvdXwXpNUdKV6GTMjH5Y6Ry1BMSJuhVyEf+AuRzPi+YijaCEVapcq7KSxP du7KrULxn9jCxEDj/F7y2ygeKPL7X0r542WA/Q24NK4qz0cm0ple1ZqNFCC+EW+jLiOs j4DFfrlexSNAVpSvYENh1/YueWzQ9ujlzkDRcXwzPR+tr11yBgo7UFv01m62oltbuLyc no0brmx51pU6hgqTAvFceLzv12YsJjJYNXoZGfHd0p+fTtS4XnVBLoleYKuCzK45D64e 79Zw== X-Gm-Message-State: AOJu0YyHb12bB0hi+7IYjK+Znsd39+CyB9e89+ovHuOnxG9WyiBqscRn 3u3ereiQs9Bx5964IBf+X+cQXQ== X-Received: by 2002:a50:cd0d:0:b0:54a:f8d9:8023 with SMTP id z13-20020a50cd0d000000b0054af8d98023mr2461518edi.37.1701615901194; Sun, 03 Dec 2023 07:05:01 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.109]) by smtp.gmail.com with ESMTPSA id n28-20020a5099dc000000b0054c9d0436a6sm1272080edb.45.2023.12.03.07.04.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Dec 2023 07:05:00 -0800 (PST) Message-ID: <6250c57b-6d38-4085-9a79-58e4e5ed1e3d@linaro.org> Date: Sun, 3 Dec 2023 16:04:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dt-bindings: interrupt-controller: Add support for Realtek DHC SoCs Content-Language: en-US To: =?UTF-8?B?SmFtZXMgVGFpIFvmiLTlv5fls7Bd?= , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" References: <20231117162709.1096585-1-james.tai@realtek.com> <20231117162709.1096585-2-james.tai@realtek.com> <7959920acf004f3cb8072de1e17439fa@realtek.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 03 Dec 2023 07:06:24 -0800 (PST) On 02/12/2023 17:18, James Tai [戴志峰] wrote: > Hi Krzysztof, > >>>> + >>>> + compatible: >>>> + enum: >>>> + - realtek,rtd1319-intc-iso >>>> + - realtek,rtd1319-intc-misc >>>> + >>>> + "#address-cells": >>>> + const: 0 >>>> + >>>> + interrupt-controller: true >>>> + >>>> + interrupts-extended: >>> >>> interrupts instead. >>> >>> Anyway, you must describe the items. Why this is not fixed but flexible? >>> Hardware has different number of pins? That's unlikely. >>> >> I will replace it with 'interrupts'. Since our Interrupt controller architecture >> doesn't involve multiple interrupt sources, using 'interrupts' should suffice. >> > > Due to changes in hardware design, some peripheral interrupts pin initially connected to the Realtek interrupt controller were redirected to the GIC. > However, the associated fields and statuses in the Realtek interrupt controller registers were not removed. > As a result, these interrupts cannot be cleared by peripheral register, and their status clearing is still needing the Realtek interrupt controller driver to manage. > > That's why flexibility is necessary. This does not explain why this is not fixed per variant. Best regards, Krzysztof