Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   Suman Ghosh <sumang@marvell.com>
To:     Shigeru Yoshida <syoshida@redhat.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "dsahern@kernel.org" <dsahern@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH net v2] ipv4: ip_gre: Avoid skb_pull() failure in
 ipgre_xmit()
Thread-Topic: [EXT] [PATCH net v2] ipv4: ip_gre: Avoid skb_pull() failure in
 ipgre_xmit()
Thread-Index: AQHaJTq+xdxLhbQE0EyCVUEj9YjahLCXrVmQ
Date:   Sun, 3 Dec 2023 15:18:52 +0000
Message-ID: <SJ0PR18MB52163C04ECCF817B3F99B58CDB87A@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20231202161441.221135-1-syoshida@redhat.com>
In-Reply-To: <20231202161441.221135-1-syoshida@redhat.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?B0sGny4cz1ZejPchh/sRxOrFuUfP7t/y1FxJLkIgbqMrbTdaV/7nvjK5QyDn?=
 =?us-ascii?Q?adTkQij3kAU77NP8jl+sbkUhAzvqsX9mXq6mqYnzutev118qE9YAGUAEJV9i?=
 =?us-ascii?Q?hz/O0Gnu4DI/oTPVLN+UAToD91zYJ94GaK2B2keJGa8wyKBDZC89zjH8+vbe?=
 =?us-ascii?Q?ewPKsYhG7M2TIxTpmnWEnCohppuEBl5vr+rHCWIYwJwgPHQUUEtKQcTox7yP?=
 =?us-ascii?Q?IIHWF0p3Arg/X4NkBpjYafkjaZWsIQOIoNAuf/J+wa1MqWeKL3MUE4e2YsmP?=
 =?us-ascii?Q?IZ4eVmJeNBrwACCzrsGIrU4tjOgTkCHh4ZcInE1bl2/cnPOaExoqSKytuV0A?=
 =?us-ascii?Q?Yy0gma3KSQop0NjDr7DPMQGv+3J/Yo4wz4lWNdMTr2eZik4UCZCyY+Mi95Tl?=
 =?us-ascii?Q?oNiB8PWbrE13hdQa36hfxE9oBb9KFGOxK00U+ko4sX8Ox8xxJvUFf24WoZMt?=
 =?us-ascii?Q?6n8fYqpF17ANTsfXc74Bs3FtgCTK1zm5GH8HAq4AR+nKlNuGwobsYbs3pLmn?=
 =?us-ascii?Q?UVvJHof/64XWxy56koQa9o040PRAZJHuDDdcF7t5vRHoHt3l12gvvllgxNVb?=
 =?us-ascii?Q?bvCnlTzBYr4UKKtmHQel8Yj0KHv33Wvz+WCtujqjbvotlJTsDU6K4PLmOEsA?=
 =?us-ascii?Q?/RY3qJenQFNvQzsTVP8fjSKccYCfJPhs9RN/hwulRix2qVbSi146LWqainVB?=
 =?us-ascii?Q?HUsbWVbM04MjejfBuwCJMbNbOVihpPtETUIbC5CijidBukK9gXVoUbRca1e3?=
 =?us-ascii?Q?mYx5Jz+KiaE0LvCfO/Bg9lFIC2RxumacTfZWqgPGfS3Re9mH7TdKiXe6z0+X?=
 =?us-ascii?Q?dPmUoQubY/K7bNQlyZj49+i5bkJ1CexWgS/bBj8v3gff3/OA0fLPClbFfR+S?=
 =?us-ascii?Q?deM76UWwuCKyDQ0snyP/jN/kBVCuNh3OXRhKM9mVmq9kiyy1xz6ZkVPppVzx?=
 =?us-ascii?Q?6yFWkpjCBVi8pag8wMxuHS9+iCoo/tsh+ezqkRDgWPrF7xYyprMSa6BbnPVy?=
 =?us-ascii?Q?+VbE6FlRaWXSjTuMCmcBEeF0RYcMn0CYcL1/4uYXRmdp/VyrJp9LQym4GqaU?=
 =?us-ascii?Q?OhgiMtVnUO+/53ambNdccRGQu6/xQ+xsGulKL60BveTSu2K87I0r1OAbZ0OC?=
 =?us-ascii?Q?dhEPB+Vp3r8M4QBsDzIQW0YAV2oTwW6utS4WKHrMmG4hHUfUFJ9ZGD7RXq4c?=
 =?us-ascii?Q?aFNXVQKVKzwhQ7Cl8Tqvw/Mca0IG88D4uN0ir4hYh6h/76kaRxtuCJAnqpij?=
 =?us-ascii?Q?mlS3BRhX9EX6vQ2w2LAUfmn6OTQN8QUuOwDjjCH2VTkqpjPuqAAKxjG/XPUV?=
 =?us-ascii?Q?Eph9gnLkgpdpHNa1NcPVV+gLpnHwK9Mkhvu+OcJkS+lR88VGtWTjhZzA3zp4?=
 =?us-ascii?Q?V9ENui63ekJURrxmT6uj/4QLEJ6ghVQlb0SkzpJYQWTYO7Ena7/IzYOIEicK?=
 =?us-ascii?Q?95Xv+34lZOy5fZSZgwHkxjGJfcPBFotZKGOyJ3LuVyaXZDrAPHTF/EsKg6YZ?=
 =?us-ascii?Q?2DzYpMQZgnz9otKek/uj+7+cbPdZIXye4+G9sS0gxtqNX4VKwWm/INuv8C1X?=
 =?us-ascii?Q?zGnuHqR6dk/Y/GLqRq7EfinSYMC1vNbJwE4rUqOr?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94bdb818-78ad-419b-7d2d-08dbf413285b
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2023 15:18:52.1511
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: N9WsSMC98a04aGvDEI0LtV4E/f2m1vao9JWFwdLRS/rbk/OIBsN2n0jiAxgVFI4ghZcXn2GRa+S6o81LZjgaUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR18MB4422
X-Proofpoint-GUID: _Zuk7slAQMvWlmuvrVY_KyRt_coC4Nzs
X-Proofpoint-ORIG-GUID: _Zuk7slAQMvWlmuvrVY_KyRt_coC4Nzs
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-03_13,2023-11-30_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 03 Dec 2023 07:19:21 -0800 (PST)

>In ipgre_xmit(), skb_pull() may fail even if pskb_inet_may_pull()
>returns true. For example, applications can use PF_PACKET to create a
>malformed packet with no IP header. This type of packet causes a problem
>such as uninit-value access.
>
>This patch ensures that skb_pull() can pull the required size by
>checking the skb with pskb_network_may_pull() before skb_pull().
>
>Fixes: c54419321455 ("GRE: Refactor GRE tunneling code.")
>Signed-off-by: Shigeru Yoshida <syoshida@redhat.com>
>---
Reviewed-by: Suman Ghosh <sumang@marvell.com>

>v1 -> v2:
>- Change the title
>- Update the code with Eric's suggestion
> =20