Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Sun, 3 Dec 2023 19:48:41 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-kernel@vger.kernel.org, Wasim Khan <wasim.khan@nxp.com>,
        Wei Fang <wei.fang@nxp.com>, Clark Wang <xiaoning.wang@nxp.com>
Subject: Re: [PATCH pci] PCI: remove the PCI_VENDOR_ID_NXP alias
Message-ID: <20231203174841.uj6ixj7ap2hzlvey@skbuf>
References: <20231122154241.1371647-1-vladimir.oltean@nxp.com>
 <20231129233827.GA444332@bhelgaas>
 <2023113014-preflight-roundish-d796@gregkh>
 <20231203151654.nh4ta7vtzwpwg4ss@skbuf>
 <2023120354-expansion-frequency-f991@gregkh>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2023120354-expansion-frequency-f991@gregkh>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RFCPSOaQpTL91H2/BE4tyAz73n+GrSCMpieh3HCdPIesokl05K2LjnUrfOxS?=
 =?us-ascii?Q?EuhypBcwT7a1ORdmwXRZkp/2OYQsOhZwAVOCQvgDOuJAaPaN7Yppv08kr04L?=
 =?us-ascii?Q?RHM9FutUd3IW845z9eeFxZ5cSAlZSfmBetfie9R7sSSnrQ3BXCsQdybHsJRH?=
 =?us-ascii?Q?qtaRX89vQEbOxogpT8+wydnKTdo9kE5twmtlqfytIKRanREp3/+LilWRO0BQ?=
 =?us-ascii?Q?ZkX+08acVuU7y6vi5ASUG9Q6dhEwwgq1BYlurVhfUcUWOgkWOvv3zzeP0a5u?=
 =?us-ascii?Q?nhLCdKPeM/0TyQZ6P4oHeiJCYY+k1sjDjlyM4/QFoHHdBBE/IkuTAePvL0pP?=
 =?us-ascii?Q?Lb6ueeuk3IvMqvbmD47RfZiPappjQ/ZkMiDWY43yfSZF5fx9m6MvOtjZzx/k?=
 =?us-ascii?Q?MVTFVu0WbsVhuaEghmhZJIUvBNn9QIQpIrYMVq+f5WvL7BljTfDprTHNhwUo?=
 =?us-ascii?Q?je9a54uRRYEO0ciDRpe+Y1kSgHQKyR02O8kFMW7Kf7SZ4H+XeBV4pa2SJSBX?=
 =?us-ascii?Q?knrU/mHGDdMRY71Bxo2YGIr5D8QW/RLNxR2HIg7MwBFSTZH3rB0KDdI3jWgW?=
 =?us-ascii?Q?01PhEjDUBBYLwpS1kuZcNBCeNy+Ol+NzCWwN0+NR8vEQwAl2HmTiIs5CLKQ1?=
 =?us-ascii?Q?hR6tIajq2uIYaxsXIALq3bx4UIClF2xmSkH2MvBEqSrNAVkPBCZAmcHjKKnQ?=
 =?us-ascii?Q?PI0um2t2xQCxvBQ4fLcCKPMrPJcHEA4IL5BVCkufmdaQNagT+XZzu8S9xOE9?=
 =?us-ascii?Q?sdddMXbdHH/azBvOjIJcXnfMBarLmfYT6+fVqJSgG/Gw0ETDmf3F5WrglQh+?=
 =?us-ascii?Q?6khgnCGnQoScCKUkqEhObdCxBY+QyKv8hOzeLXM+LQQtnX0yh/vrq+pvjN5T?=
 =?us-ascii?Q?7eEpPz9HcPFyr+iXubou/JF/+lyI9hNYJv8qOa1Ne0DvuRDJqr6Q2f+15J8x?=
 =?us-ascii?Q?VXMrOfwEAatYJi58GsKArwv8UJ9DPj2EW70Z4x4LLJW1503dqlyr/VnnezkL?=
 =?us-ascii?Q?vUK2SmiO7cymAFd0eOLGE9eW1EOG8JLUsJMLlzbiJ3+SRp4OBD8EQQkgXKrF?=
 =?us-ascii?Q?EzkfAzO+clCctd1sHFBLBV1Dc+e5YHWPmOFC9lw4JXWX852mzfB0o8MwIg25?=
 =?us-ascii?Q?kibf8qqZLR6DrDJwEBnMQr68hr0mptKWW6q8QcucPyZzmh1XjwRvlb701eaC?=
 =?us-ascii?Q?RGbfPAljL76/gVCHrrN8eq/+b7JzOh69Q2x8UK/G5KxpdLsKWqfRaDMcdBSB?=
 =?us-ascii?Q?Jtqy9aeBMiJjKVVfqMhpfp/bcTAXKxXeYQGgtYzEytxfiA/cF0vWpJhQiW7b?=
 =?us-ascii?Q?/FNexO2gV/lZP6hJDFIu/iuj2+ChBJb845E55h959BjzoAOFNnVzJk2DvrUH?=
 =?us-ascii?Q?ApkP5DMomBAYf6VHfncJh29XvEXFblEYlNHWbhFAXXeoUmlz5f5SZgk4T1vl?=
 =?us-ascii?Q?Xw4+Xdlq1umVghH/Mt09YP69CtSu03sJ+CFApfiwyH3fJlOHtff1Togs8xWc?=
 =?us-ascii?Q?lfM0oqxHnip9PS06z+gAW7+ye1qTiMdImH+fK8l47Dy7HfiySabp5rQehoeo?=
 =?us-ascii?Q?D2RU1ieHNFckXoWnEW7rnZ5t24ZWcK/Xl3pZgwZKCHdQdyRoU/I7RzbAebmZ?=
 =?us-ascii?Q?GQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ff25b082-7c74-4364-95ea-08dbf42817ff
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6452.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2023 17:48:44.3575
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NTtoAxVqZbGut3TYly60gif9kgkedJXFUJLnnggiUD4lm79WyJ6RDKBvOTWvFV+NujOnIpH6TWeWITdS9533gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9711
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 03 Dec 2023 09:49:06 -0800 (PST)

On Sun, Dec 03, 2023 at 06:30:13PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 03, 2023 at 05:16:54PM +0200, Vladimir Oltean wrote:
> > On Thu, Nov 30, 2023 at 11:10:19AM +0000, Greg Kroah-Hartman wrote:
> > > > Why would we remove name of the current company and use the name of a
> > > > company that doesn't exist any more?
> > > 
> > > Yes, this seems very odd.  What is the reason for any of this other than
> > > marketing?  Kernel code doesn't do marketing :)
> > 
> > I'm not sure who is doing the marketing; not me, that's for sure.
> > The patch that I'm proposing undoes these strange aliases.
> 
> Why?

Why am I undoing the aliases? It's in my commit message. NXP now
produces PCI devices with a different vendor ID. If aliasing is the way
to go, then are we supposed to add a new PCI_VENDOR_ID_NXP2,
PCI_VENDOR_ID_NXP3 etc?

Mellanox was bought by Nvidia and I don't see its PCI ID aliased to
Nvidia. There are probably countless of other examples.

> Who did it originally in what commit id and what was wrong with them
> then?

Does it really matter? "Git blame" on the line with #define PCI_VENDOR_ID_NXP
will point to a random commit by Wasim Khan (also CCed). The usage of
PCI_VENDOR_ID_NXP is not widespread, it's only that commit. Everywhere
else in the kernel, 0x1957 is referred to as PCI_VENDOR_ID_FREESCALE.
I can't comment on what was wrong with Wasim.