Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2290980rdb; Sun, 3 Dec 2023 10:12:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IGEvFZRZnuZvOHVB5HohvGOIFTyU0+S+FrNiond7z/x42Tl3b4BLq2u1pTKzg/SbrPdiru1 X-Received: by 2002:a05:6a20:979b:b0:18b:208b:7043 with SMTP id hx27-20020a056a20979b00b0018b208b7043mr2968405pzc.49.1701627163208; Sun, 03 Dec 2023 10:12:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701627163; cv=none; d=google.com; s=arc-20160816; b=dMaaiV5gmc/3dv2nRHBvzl9jukhXYj+NqvO+4UyjHfoQD2LZajRKUuxIxK5eSJCu44 wXPq8AGE48Jx1Lr2D6ycO8BeolU6mlzQvKAFsaGO0hbQch2+JsWVx/xlpcQmQOeIi2HG zxUbdhR+MMoef2IYCJC6kHJtYPJCtabXHgms6y44hGb91Nqd2pN2RGI5LSuP+MhuDZ7V tkke7UDhyXJud7iF5xwGevr/utjPz6u8z3uCvB/MJe533i7NegNmHRF5w2KvaX6fnTxi ihCWUx/bvq9g/FRb7wOnCJGYU3WxPEuUmlZXEVoLdpBSAglz5fxzEbcm9Mh9TW/nB8XT 05Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Lg+rYehudk4zCa2J1cWSGcffMXq8x+Mv5QTHznDZ7UE=; fh=tiSUy0jekMg3uCAK3eC2BHXgAOtR/PPpba8hg7Upv94=; b=gQ3ExVuRbLiTHaeI+fB2CksbhVeao9vQOtjRLNK7eI25kK8/238EEg5ify0XO9VgBT GPZbfiIwrsd7vjwOodspHodbejRLxcYmzJ7i5pZiaMsybrPL1CQ40jFxb4Jiju5XgX8D tqLrL2KHf1DXNxDCMBgBmDbUxKr/WF4gxZPK7QuGxb0ri4Hin4VIkZSO3Lmt8h60kEXO Rv7PtZVJD7YGs+AuCqenrZGu70Vv9Vq0yrN7dAEwJaRqP4ixLFJUANacFh6zO2SP4xgc aGdRIwLRazoTNAJb5lGQ6Wsvwe2RQlx9NL0G3RBH90ISWh0vrKE0pqedDQ7UqAkTCzRg ai+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IItbyqSa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id g10-20020a656cca000000b005c1cd597808si7158730pgw.692.2023.12.03.10.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 10:12:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=IItbyqSa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id AD6028087258; Sun, 3 Dec 2023 10:12:40 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233820AbjLCSMX (ORCPT + 99 others); Sun, 3 Dec 2023 13:12:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjLCSMV (ORCPT ); Sun, 3 Dec 2023 13:12:21 -0500 Received: from mail-oo1-xc2a.google.com (mail-oo1-xc2a.google.com [IPv6:2607:f8b0:4864:20::c2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79EC8EB for ; Sun, 3 Dec 2023 10:12:27 -0800 (PST) Received: by mail-oo1-xc2a.google.com with SMTP id 006d021491bc7-58d54612d9cso2525339eaf.1 for ; Sun, 03 Dec 2023 10:12:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701627147; x=1702231947; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Lg+rYehudk4zCa2J1cWSGcffMXq8x+Mv5QTHznDZ7UE=; b=IItbyqSaslJmRtggyu2MJS+ZvmgLSPiVPVxd2zCgP5su6Rzc0f436I16Kzy2d3iS7C z1e83YjuZ4XHkI0eXQsQcNsF9Q30ABDjm7EAxKQnGUdTRZPUxPKzyArV10HiKD4jnUrR BGjpu/N3DNis4/6iR3DnUlfgQhiw/py8pBKSNjBNEa/0owAG8s3GB2C0/gSN4rEFKxn1 5kqxHQ2+Gh35xP8Wk+t8VBLlBf9+L1546BE8iOq/MyFyYvIY7tcSf8jpK+lVMZKAz8ce AxgOx5tKA8F8NJysQmRx06xrpnm7YbBbD5sUQuloYcKh5X7lm08SJYM4OdJh2riv0DF0 xoUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701627147; x=1702231947; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lg+rYehudk4zCa2J1cWSGcffMXq8x+Mv5QTHznDZ7UE=; b=kyzEf51477i9CA7iv9wvOD+APr2ROvIROuGg7j5LwWu8wG2dsnPOfmqSfoUtCsqPY6 3PBRs2ga+YbY2DrHU9kGEexzqep/dpR3oUd6jJbWTkGb5ZYcwK7XBYPjvQjDtglnUgvo 1x3yag+WNGn9egV+dRQMTh/dzlnPt5CYeUnFXmU1PH4/WBEihMqVxWdtcKX56YmX2TQg bW5YuIWEhfO80uo7QJwyKceoF/PeCZDwJ9U+cjMXppcJ4rGthI8bZo8aoAiOQmHzSY3+ P5d0Y+IwrrH3lLEJc9duIChy7VTcM6uus5BsRkncPoAvuN2A0QEYcnO85ZRW6gaP3OnO qHTw== X-Gm-Message-State: AOJu0YyJpu2kn0HSv6vCBMX1OCqWtUzT1KQLxMGFU6i5KjMuY/q79a+J QcYNzKpVQCtxJTYSUIfC/OtuOXBcLUnr3k1jZJcHiUxbe3uWDizVBdk= X-Received: by 2002:a05:6358:10a:b0:170:17eb:b3e with SMTP id f10-20020a056358010a00b0017017eb0b3emr2568531rwa.40.1701627146725; Sun, 03 Dec 2023 10:12:26 -0800 (PST) MIME-Version: 1.0 References: <20230612133452.47315-1-luhongfei@vivo.com> <3a32ad33-5f0e-4166-a118-1bbbec9c68e0@ixit.cz> In-Reply-To: <3a32ad33-5f0e-4166-a118-1bbbec9c68e0@ixit.cz> From: Dmitry Baryshkov Date: Sun, 3 Dec 2023 20:12:16 +0200 Message-ID: Subject: Re: [PATCH v3] soc: qcom: pmic: Fix resource leaks in a device_for_each_child_node() loop To: David Heidelberg Cc: luhongfei@vivo.com, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 03 Dec 2023 10:12:40 -0800 (PST) On Sun, 3 Dec 2023 at 19:46, David Heidelberg wrote: > > Heya! > > I think this would be great candidate for backport, at least up to 6.6. > What do you think? Yes. Most likely it should have had: Fixes: 080b4e24852b ("soc: qcom: pmic_glink: Introduce altmode support") -- With best wishes Dmitry