Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Sun, 3 Dec 2023 18:35:00 +0000
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     =?iso-8859-1?B?Wm9sdOFuIEL2c3r2cm3pbnlp?= <zboszor@gmail.com>
Cc:     linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
        zboszormenyi@sicom.com, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] egalax_ts_serial: Fix potential buffer overflow
Message-ID: <ZWzHv7X1UKgJJYTy@google.com>
References: <202312021646.cwwvptuB-lkp@intel.com>
 <20231203090600.85890-1-zboszor@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231203090600.85890-1-zboszor@gmail.com>
Precedence: bulk

Hi Zolt?n,

On Sun, Dec 03, 2023 at 10:06:00AM +0100, Zolt?n B?sz?rm?nyi wrote:
> @@ -42,7 +42,7 @@ struct egalax {
>  	struct serio *serio;
>  	int idx;
>  	u8 data[EGALAX_FORMAT_MAX_LENGTH];
> -	char phys[32];
> +	char phys[NAME_MAX];

This simply wastes 200+ bytes for no good reason. It is perfectly fine
to truncate phys string (which does not happen in practice).

If you feel strongly about it then maybe use devm_kasprintf() to
allocate the needed buffer.

Thanks.

-- 
Dmitry