Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2354465rdb; Sun, 3 Dec 2023 13:18:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IFzY64i2pwXKlvAMZ70iHP3BZn1iLk/uoLtLnio5WC2XMkaLS0ewhSC7rO+BGcLvVIAtzgg X-Received: by 2002:a05:6808:2120:b0:3b8:b063:9b59 with SMTP id r32-20020a056808212000b003b8b0639b59mr3379597oiw.75.1701638287691; Sun, 03 Dec 2023 13:18:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701638287; cv=none; d=google.com; s=arc-20160816; b=G0nffKrjZWsIQJid+ieLLe4X0yCsJecUu1BmprMVMqP4r8TVKNGB7s0I9oRWrUY5P9 upCvDMloeYEBveOHHV67Sdhjhr6nOzbMFi9Nmc25+KdcPsik0T2Eb90hXeb7ykgJLUVB 4K3sSxHRmIW8rhCzRh+8dlhDOK3SMqDvVqzlx7gJoRu3AmRoL5DFcMrtfimNgx32ENTO oedsyi2VIHxagvX/BeKP2tVUWhiaYJASjMz73dLGMKiWbds6+TdhNt+L1NQcpb5OiG3k fxd1iiJFNoA8PS1V4+zTO5UOQniXzvPeilk+PKaHX2gDYQtTYfAl2HdIE/J0Ak6rV220 zMIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=sNu4rq12zJfraTogHA7IM7xLG1akfHpOXGiVhiLxf70=; fh=Il0qpuvo8wrSvd9413P7fLgAl6b8NBpe1VKpwUtjXN0=; b=n3+KiGMpT61exrLrgikVC8dI/4EWmmhmZXtkLhJ4uoFnVQME9MvPkZ6O8ejxQk3iIK 6Ynrk4T/6+ZPv4pzBzR/8tEWncj63wFkH14cx4POq9Y6vPITIxAGmEpBNEeIdgxvskUR Og9Bf+++jmtOi70x1sKrDDSIg4RyqdJ8gngKa1ihbstcKT11mNabvV1hlMYdjBlhnWCJ AXrGj5TXCatip/hNMR0RAui8iTJnp4ew90zdEceXDwBteEuMdmdAzw2cuK56vdXuouiN p1Xpm05Ps+QM5OHm8AJuvlGGL880j3yV3puPKdGsNtfZX7/Zyeuv7w8sCv0X/9hdBO8j 7ryQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id z6-20020a63d006000000b0057795cb4f16si6649028pgf.684.2023.12.03.13.18.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 13:18:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 6B09D808A37A; Sun, 3 Dec 2023 13:18:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233945AbjLCVQI (ORCPT + 99 others); Sun, 3 Dec 2023 16:16:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjLCVQH (ORCPT ); Sun, 3 Dec 2023 16:16:07 -0500 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a02:c205:3004:2154::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC32AAA; Sun, 3 Dec 2023 13:16:13 -0800 (PST) Received: from p200301077700c3001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:107:7700:c300:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r9tot-006z7p-93; Sun, 03 Dec 2023 22:16:07 +0100 Date: Sun, 3 Dec 2023 22:16:05 +0100 From: Andreas Kemnade To: Lee Jones Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, bcousson@baylibre.com, tony@atomide.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v2 2/6] twl-core: add power off implementation for twl603x Message-ID: <20231203221605.38496a8d@aktux> In-Reply-To: <20231201104820.GC3259151@google.com> References: <20231127221907.177442-1-andreas@kemnade.info> <20231127221907.177442-3-andreas@kemnade.info> <20231201104820.GC3259151@google.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sun, 03 Dec 2023 13:18:05 -0800 (PST) On Fri, 1 Dec 2023 10:48:20 +0000 Lee Jones wrote: > > + if (err) { > > + pr_err("I2C error %d reading PHOENIX_DEV_ON\n", err); > > It would save an awful lot of lines and space if we could place these > warnings/errors inside twl_i2c_read_u8(). Well, it is already in twl_i2c_read() ... yes, we can save quite some lines. Regards, Andreas