Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Sun, 3 Dec 2023 23:06:26 +0100
From:   Andi Shyti <andi.shyti@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Mario Limonciello <mario.limonciello@amd.com>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Wolfram Sang <wsa@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Jan Dabros <jsd@semihalf.com>,
        Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v4 19/24] i2c: designware: Uninline i2c_dw_probe()
Message-ID: <20231203220626.ild5flvaqvlsqbmy@zenone.zhora.eu>
References: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com>
 <20231120144641.1660574-20-andriy.shevchenko@linux.intel.com>
 <20231129232151.ueum2axn74qzuzes@zenone.zhora.eu>
 <ZWiN8sY-I8cyNWCs@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZWiN8sY-I8cyNWCs@smile.fi.intel.com>
Precedence: bulk

Hi Andy,

On Thu, Nov 30, 2023 at 03:28:18PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 30, 2023 at 12:21:51AM +0100, Andi Shyti wrote:
> > Hi Andy,
> > 
> > On Mon, Nov 20, 2023 at 04:42:01PM +0200, Andy Shevchenko wrote:
> > > Since i2c_dw_probe() is going to be extended, uninline it to reduce
> > > the noise in the common header.
> > 
> > where is it going to be extended? It's not in thie series. I'm
> > fine with the patch anyway as it cleans up the header file.
> 
> It's used to be in the previous versions of the series where I have
> device_set_node() API to be used.

Thanks! I think this missed:

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Andi