Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <20231203222903.343711-1-andreas@kemnade.info> <20231203222903.343711-7-andreas@kemnade.info>
In-Reply-To: <20231203222903.343711-7-andreas@kemnade.info>
From:   Adam Ford <aford173@gmail.com>
Date:   Sun, 3 Dec 2023 16:46:20 -0600
Message-ID: <CAHCN7xKG6-vgnJ+mA8xt0aFK-jCBWOX-GkVmJGNERH43N0ikaw@mail.gmail.com>
Subject: Re: [PATCH v3 6/6] ARM: dts: omap: gta04: standardize system-power-controller
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     lee@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        bcousson@baylibre.com, tony@atomide.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Dec 3, 2023 at 4:29=E2=80=AFPM Andreas Kemnade <andreas@kemnade.inf=
o> wrote:
>
> Replace TI-specific property by generic one.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> cannot be applied independently of the other ones, so maybe simply delay
> it.
>
>  arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi b/arch/arm/boot/d=
ts/ti/omap/omap3-gta04.dtsi
> index 3661340009e7a..5001c4ea35658 100644
> --- a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi
> @@ -476,6 +476,7 @@ twl: twl@48 {
>                 reg =3D <0x48>;
>                 interrupts =3D <7>; /* SYS_NIRQ cascaded to intc */
>                 interrupt-parent =3D <&intc>;
> +               system-power-controller;

Could this go into the twl4030.dtsi file so we don't have every omap3
board with this part duplicating this line?

adam
>
>                 clocks =3D <&hfclk_26m>;
>                 clock-names =3D "fck";
> @@ -490,7 +491,6 @@ codec {
>
>                 twl_power: power {
>                         compatible =3D "ti,twl4030-power-idle";
> -                       ti,system-power-controller;
>                 };
>         };
>  };
> --
> 2.39.2
>
>