Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2463532rdb; Sun, 3 Dec 2023 19:03:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IFXVSpicf/LJrPmUE1xGyixj/i2OfuhL0ylHsFIzxYro9TMWx38dshob1T6P6lc1ewCrHuN X-Received: by 2002:a05:6a00:88e:b0:6c9:892c:5916 with SMTP id q14-20020a056a00088e00b006c9892c5916mr32181294pfj.9.1701658993085; Sun, 03 Dec 2023 19:03:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701658993; cv=none; d=google.com; s=arc-20160816; b=qMgFYTryiDe+UBJVoB1/63Tth2K2V79chdajubZQpdF0grOkeTsgTkshMbgpoDCioA pgiKbvQnbAU9zUkWklG3wiq096ZzHJYovE6ABrd59+TAR/4c2lz2b65MzFFj7ny2QBWf lH7uscDp/xLgFq9nMKqxb1MJ3smhtPH7675/URXMFRz/DHT0SsosFQ/+BPIzNcJ6eA3+ 21isVuTaqwG85C3s/eQ7lN8yzl13wcwqyFZ2GQMdXoWRajyw7xoLdjW4gYTM+lD2gSIe Ph7EmoFm2uLO0fb3oQB0IA7b7IDK9P0fK+CZWYI/cc4A5A4kKAv9uL8fEYLUz3rP/+jX qCQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=ZJOt/o2LiRzU+Yz/3sRcWSsqnS1rjHB1nmr45ewsKkw=; fh=Rr4wuf83T0JSDESlcnNDHT2EOlnIVVq22SCwhzTaeic=; b=ZYPhQY4waYK3l/rQnewkSxA7Qaeemvwl/TAerIjUkMGcXoOTAZ84qaYnemwIvboQ8+ ke8oDN2mkvaNeKDNVRgwtAGpNYzmvj0Abj6/Tl1Uu5XFiACRc0uO14lhdf7OMV2jKwHv kVGnbaIWFhNMmUTdhe+pu/WeEnmGnAp6wGef460zYbFEFMtEwOjtQ+WO0wt1USXRHrl9 boBGR3VkIjWNH3MmmBFQh1IhIktNNiNvmhKMCwkDJPgsxJI6Dj0S0aE19qQtsO7WooT1 sjVhYQyfWo/UkzfJ9FRtL3VCGfUWHfElFgDCEsK4L9wbPV7PtY7N1zDYzFYJSU97oBV2 UHpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id f6-20020a056a0022c600b006ce500e3702si1047048pfj.343.2023.12.03.19.03.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 19:03:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id B5CBE806BC3D; Sun, 3 Dec 2023 19:03:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229918AbjLDDCs convert rfc822-to-8bit (ORCPT + 99 others); Sun, 3 Dec 2023 22:02:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjLDDCr (ORCPT ); Sun, 3 Dec 2023 22:02:47 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F0C7E5; Sun, 3 Dec 2023 19:02:48 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 7CBD624DDB2; Mon, 4 Dec 2023 11:02:44 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 4 Dec 2023 11:02:44 +0800 Received: from ubuntu.localdomain (202.188.176.82) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 4 Dec 2023 11:02:42 +0800 From: Jia Jie Ho To: Herbert Xu , "David S . Miller" , , Subject: [PATCH] crypto: starfive: Remove unneeded NULL checks Date: Mon, 4 Dec 2023 11:02:39 +0800 Message-ID: <20231204030239.989183-1-jiajie.ho@starfivetech.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [202.188.176.82] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 03 Dec 2023 19:03:10 -0800 (PST) NULL check before kfree_sensitive function is not needed. Signed-off-by: Jia Jie Ho Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202311301702.LxswfETY-lkp@intel.com/ --- drivers/crypto/starfive/jh7110-rsa.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/starfive/jh7110-rsa.c b/drivers/crypto/starfive/jh7110-rsa.c index c2b1f598873c..cf8bda7f0855 100644 --- a/drivers/crypto/starfive/jh7110-rsa.c +++ b/drivers/crypto/starfive/jh7110-rsa.c @@ -45,12 +45,9 @@ static inline int starfive_pka_wait_done(struct starfive_cryp_ctx *ctx) static void starfive_rsa_free_key(struct starfive_rsa_key *key) { - if (key->d) - kfree_sensitive(key->d); - if (key->e) - kfree_sensitive(key->e); - if (key->n) - kfree_sensitive(key->n); + kfree_sensitive(key->d); + kfree_sensitive(key->e); + kfree_sensitive(key->n); memset(key, 0, sizeof(*key)); } -- 2.34.1