Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2464052rdb; Sun, 3 Dec 2023 19:04:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IESMKaSRS3xTxWcCPGcKfGkTuK2A6SvLFMQWw6hx5GSB14hRREGwgM/aMB6Esj4RBQnEJeW X-Received: by 2002:a05:6a20:258f:b0:18c:64e0:4474 with SMTP id k15-20020a056a20258f00b0018c64e04474mr22432820pzd.1.1701659076152; Sun, 03 Dec 2023 19:04:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701659076; cv=none; d=google.com; s=arc-20160816; b=ohRniGZBQbRaouDOg6q8/scUaGxYvL+Mj55vtB2+NeHlokAodUR49UFikmRmQSnZUT TltGzm1Pa2EVI075545HxBQFUFmZhIb2NA06ie72JRjF5BrlFRdqAmZ4yyu70awU6xPZ Hx2+bQ1g9RYBshJX8PlS3T41C20ApQm+jU7y5dFIrST2vdYd2CF6Om+AvGK9PcLGUvjk I7Ce8k1H76JhYjy9mQkLCuc15purYMWmXyobkUkHuB74tK2BQfq0ViiubXHsttfX9PmX 44jsLKjV61JkQcan+1KVR7biG/ZDc/y5CU7s0UaQ7xJ8pk6GWoAR8wWE0JHocFg+Ssyy Wy4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from; bh=FUV986pd/svLEyiaOpvGL/in9TkbxOGeIk3TTqeOAFE=; fh=Rr4wuf83T0JSDESlcnNDHT2EOlnIVVq22SCwhzTaeic=; b=ZGsWGUzcH6GghK578r5yEyNfC8on2yWIvW1YwD10p9DiqWr3fAaOgtlZdwUmgFV3bh ql4l+/+o//Uc6fVcPzSZtdceYpDKAT7AEoNcvfxS8xHetsyufjE/kLtZaxytqWniglXR MRSq7MCrL5vhH7AmXFPJPSdLfPuA6A9OBUsoSKQMpOkKYrnEyNETdP78GuFADqrb5j2b Oq/d7UXRqImLTC8fzGTiAoSDCl+YDogZ8yvDhldBR7MhhpPAYcbcpuyICfECw+LLleko d1evYfwgBJFYPXhVkTosJm13oohUFN6G/LpQWHmPg1c53pW52tQFHcmTSZIp79Sn8yqY M/lA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id nh9-20020a17090b364900b002865ae767cesi4811211pjb.172.2023.12.03.19.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Dec 2023 19:04:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id E241780608C1; Sun, 3 Dec 2023 19:04:33 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbjLDDEN convert rfc822-to-8bit (ORCPT + 99 others); Sun, 3 Dec 2023 22:04:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbjLDDEM (ORCPT ); Sun, 3 Dec 2023 22:04:12 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A4E7E5; Sun, 3 Dec 2023 19:04:18 -0800 (PST) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 50E9A24DDB2; Mon, 4 Dec 2023 11:04:17 +0800 (CST) Received: from EXMBX168.cuchost.com (172.16.6.78) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 4 Dec 2023 11:04:17 +0800 Received: from ubuntu.localdomain (202.188.176.82) by EXMBX168.cuchost.com (172.16.6.78) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 4 Dec 2023 11:04:15 +0800 From: Jia Jie Ho To: Herbert Xu , "David S . Miller" , , Subject: [PATCH] crypto: starfive - Fix dev_err_probe return error Date: Mon, 4 Dec 2023 11:04:13 +0800 Message-ID: <20231204030413.989243-1-jiajie.ho@starfivetech.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [202.188.176.82] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX168.cuchost.com (172.16.6.78) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Sun, 03 Dec 2023 19:04:34 -0800 (PST) Current dev_err_probe will return 0 instead of proper error code if driver failed to get irq number. Fix the return code. Signed-off-by: Jia Jie Ho --- drivers/crypto/starfive/jh7110-cryp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/starfive/jh7110-cryp.c b/drivers/crypto/starfive/jh7110-cryp.c index 1e3cadcb179b..cd876fb23ade 100644 --- a/drivers/crypto/starfive/jh7110-cryp.c +++ b/drivers/crypto/starfive/jh7110-cryp.c @@ -160,7 +160,7 @@ static int starfive_cryp_probe(struct platform_device *pdev) ret = devm_request_irq(&pdev->dev, irq, starfive_cryp_irq, 0, pdev->name, (void *)cryp); if (ret) - return dev_err_probe(&pdev->dev, irq, + return dev_err_probe(&pdev->dev, ret, "Failed to register interrupt handler\n"); clk_prepare_enable(cryp->hclk); -- 2.34.1