Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Geethasowjanya Akula <gakula@marvell.com>
To:     Simon Horman <horms@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: RE: [EXT] Re: [net v3 PATCH 3/5] octeontx2-af: Fix mcs stats register
 address
Thread-Topic: [EXT] Re: [net v3 PATCH 3/5] octeontx2-af: Fix mcs stats
 register address
Thread-Index: AQHaI2MJo8oLnqMHDUCszsbF1cpkorCXzccAgADOWXA=
Date:   Mon, 4 Dec 2023 05:22:53 +0000
Message-ID: <DM6PR18MB260210685BDED4A713503D9ECD86A@DM6PR18MB2602.namprd18.prod.outlook.com>
References: <20231130075818.18401-1-gakula@marvell.com>
 <20231130075818.18401-4-gakula@marvell.com>
 <20231203170054.GL50400@kernel.org>
In-Reply-To: <20231203170054.GL50400@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NDq0Yf6SQIjOchyC3T/Y2QI4qx9Q7S4J8ndQjfpyRG0iAJi/Tx4YgNRxtXTG?=
 =?us-ascii?Q?uUNsFMLNcwkjTdJQpcAQov2+tX53sJP04pfz+DJCkqoPwlredQ4b2DKil6ge?=
 =?us-ascii?Q?m/l3dZh8prqiWF6EdDPTVS8C06qRv+beq/qhcZvS6Y3SWbtDWfRYxm97z2Ux?=
 =?us-ascii?Q?ed8uGiJSVtH8CeFfv2DkmWLG3hx/JAcXJXUiCIJ8tnZPY3AatXXNJYBidGZ7?=
 =?us-ascii?Q?ilhR8F5EF0WftbK4gsMaownMJ0MqXceTRy6rcgBShG9cH/LvScInF6L2GGdK?=
 =?us-ascii?Q?1+iJdqWznkFcenXRbSZS6Kg8S8CRSHpyW/oqBfmchsRt7eSwVNPgW1uWD4Oh?=
 =?us-ascii?Q?FDdT+psdogUlFGj66tHllx3vZFa0kR7xev/7661ISeFMLO93PHjxK2KHYX+Q?=
 =?us-ascii?Q?tbex0A/RLy7LOQ6DuUw5lvgTzN2OO5B+EOKwjOo8si61UO9BomzHp5/iXIFp?=
 =?us-ascii?Q?u7zaw+olpQiaiHEnI8GbgfzhsH9VcyV6fvUh7SRv35A/XzAh/SIa1nsNz1XQ?=
 =?us-ascii?Q?mVHDhZSxVdSSIf82OqLRbniuM+h3lpjqC1R/gfTFTMNyCMi3U9cXye9cGnDI?=
 =?us-ascii?Q?I68M7ZM49BC2+chVfk/+Kq55vba1ywGLoXaVaSp14Fg+rviFHPiMJmycn4Vm?=
 =?us-ascii?Q?AReLyq4qUoCjpzwYbQV79xvyvAh23lw0Ok9t620SxqY0bN8FIk1h9JxFER5Q?=
 =?us-ascii?Q?69quSy7qnpk23oXdi62qdQdZJYGa7ffu+Yvzct2GTUbJhhlZuwzVLfCOXRIu?=
 =?us-ascii?Q?gpPs/s03mdKcIpEzD+WxetItr7uoP0WAyje2ux+SQ5pl5EgWJbuO4qtG0grc?=
 =?us-ascii?Q?PSlqrML4lOpk2vbAZ7y3s3FXd9JFiHqQHszggSCCJ1Pe+hMSa4ZSAP50HKRM?=
 =?us-ascii?Q?GPwJ4/ZeKTVYwFzpdxFVSE1lM9KZYZzBsujXLSs3Fe+KNQljIhz2xD27q8OK?=
 =?us-ascii?Q?UF5X3SQB3DL26YSZ7Zo43CwtYeIpp31kV20bsF+F7rJfHuExTUVhTSi6ecw8?=
 =?us-ascii?Q?5mRagWIzpIryDLRIavLHuuqGAUOF1DYT4beQdZfVSRjoYMqwECJGnjmhgMM5?=
 =?us-ascii?Q?69lE2l01dG6/bZtDqrfv+STEVwr5FFjONdlRBmeTLnGQOktfS60Kpq2LnuFg?=
 =?us-ascii?Q?+onOpnKLcjLxTElDEc8BWdwFfxnRMWXJ+8dGsHV8LEdXEu4D4BHIbHOkXPRH?=
 =?us-ascii?Q?YaeY2k9pxHvMPecrSU4Z5ZQBBazgpnnv+6tIPHc/7BCzbbqpSpgbuCBNNC4R?=
 =?us-ascii?Q?pm9hw03/z6R9y+CCcvQYCc7EIUm0/21YajiWuV3oh34pNgWlA2ULY1C1WmRx?=
 =?us-ascii?Q?UIFxCyph/Jqc/RVHuPROJGaGirS+IqR7DtFoZcZPnWigbbPCYhYT6st4Qg3O?=
 =?us-ascii?Q?rE7f+FO6NOsesr6B/nGtTFxoIo9b92AT/kebstRfzrX94WbS9i/I6rjUGD75?=
 =?us-ascii?Q?EXJFBz0uhSrLCEz8pZCh0zPEsdetsin4RDFbuV8pkftM5XUWdaczd6ISSL6I?=
 =?us-ascii?Q?WJq2bRa19tWqpyUiIgHo4p1teUIc9U6Er1NvpREcOtjG4xgguavZnfVpTUym?=
 =?us-ascii?Q?t/9r4xHiS0DzAPHz4QM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB2602.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 145d5d00-8058-421a-51c6-08dbf48910c7
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 05:22:53.1785
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uHzUvnbancSu93rlcjqyQnDMl/kVeudjW9AcAW61xGDVb6EM6b3+WeeCA5GzTMk48bBnxHzZCWYSACryddyupQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB4302
X-Proofpoint-ORIG-GUID: BLWVcD4v3BDEXzht2_FJWVSvb0T6VFqr
X-Proofpoint-GUID: BLWVcD4v3BDEXzht2_FJWVSvb0T6VFqr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-04_03,2023-11-30_01,2023-05-22_02
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 03 Dec 2023 21:27:05 -0800 (PST)


> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Sunday, December 3, 2023 10:31 PM
> To: Geethasowjanya Akula <gakula@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kuba@kernel.org=
;
> davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil
> Kovvuri Goutham <sgoutham@marvell.com>; Linu Cherian
> <lcherian@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Hariprasad Kelam
> <hkelam@marvell.com>
> Subject: [EXT] Re: [net v3 PATCH 3/5] octeontx2-af: Fix mcs stats registe=
r
> address
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Thu, Nov 30, 2023 at 01:28:16PM +0530, Geetha sowjanya wrote:
> > This patch adds the miss mcs stats register for mcs supported
> > platforms.
> >
> > Fixes: 9312150af8da ("octeontx2-af: cn10k: mcs: Support for stats
> > collection")
> > Signed-off-by: Geetha sowjanya <gakula@marvell.com>
> > Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> > ---
> >  .../net/ethernet/marvell/octeontx2/af/mcs.c   |  4 +--
> >  .../ethernet/marvell/octeontx2/af/mcs_reg.h   | 31 ++++++++++++++++---
> >  2 files changed, 29 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
> > b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
> > index d6effbe46208..d4a4e4c837ec 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs.c
> > @@ -117,7 +117,7 @@ void mcs_get_rx_secy_stats(struct mcs *mcs, struct
> mcs_secy_stats *stats, int id
> >  	reg =3D MCSX_CSE_RX_MEM_SLAVE_INPKTSSECYTAGGEDCTLX(id);
> >  	stats->pkt_tagged_ctl_cnt =3D mcs_reg_read(mcs, reg);
> >
> > -	reg =3D
> MCSX_CSE_RX_MEM_SLAVE_INPKTSSECYUNTAGGEDORNOTAGX(id);
> > +	reg =3D MCSX_CSE_RX_MEM_SLAVE_INPKTSSECYUNTAGGEDX(id);
> >  	stats->pkt_untaged_cnt =3D mcs_reg_read(mcs, reg);
> >
> >  	reg =3D MCSX_CSE_RX_MEM_SLAVE_INPKTSSECYCTLX(id);
> > @@ -215,7 +215,7 @@ void mcs_get_sc_stats(struct mcs *mcs, struct
> mcs_sc_stats *stats,
> >  		reg =3D MCSX_CSE_RX_MEM_SLAVE_INPKTSSCNOTVALIDX(id);
> >  		stats->pkt_notvalid_cnt =3D mcs_reg_read(mcs, reg);
> >
> > -		reg =3D
> MCSX_CSE_RX_MEM_SLAVE_INPKTSSCUNCHECKEDOROKX(id);
> > +		reg =3D
> MCSX_CSE_RX_MEM_SLAVE_INPKTSSCUNCHECKEDX(id);
> >  		stats->pkt_unchecked_cnt =3D mcs_reg_read(mcs, reg);
> >
> >  		if (mcs->hw->mcs_blks > 1) {
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/mcs_reg.h
> > b/drivers/net/ethernet/marvell/octeontx2/af/mcs_reg.h
> > index f3ab01fc363c..f4c6de89002c 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/mcs_reg.h
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/mcs_reg.h
> > @@ -810,14 +810,37 @@
> >  		offset =3D 0x9d8ull;			\
> >  	offset; })
> >
> > +#define MCSX_CSE_RX_MEM_SLAVE_INPKTSSCUNCHECKEDX(a) ({	\
> > +	u64 offset;					\
> > +							\
> > +	offset =3D 0xee80ull;				\
> > +	if (mcs->hw->mcs_blks > 1)			\
> > +		offset =3D 0xe818ull;			\
> > +	offset +=3D (a) * 0x8ull;				\
> > +	offset; })
>=20
> Hi Geetha,
>=20
> I see this is consistent with existing code in this file, but I do wonder=
 if there
> would be value in moving to a more compact mechanism at some point. F.e.
> (completely untested!):
>=20
> #define MCSX_REG(base, a) ((base) + (a) * 0x8ull) #define
> MCSX_MB_REG(base_mb, base, a) \
>         MCSX_REG((mcs->hw->mcs_blks > 1 ? (base_mb) : (base)), (a)) ...
> #define MCSX_MCS_TOP_SLAVE_PORT_RESET(a) MCSX_MB_REG(0xa28ull,
> 0x408ull, (a)) ...
> #define MCSX_CSE_RX_MEM_SLAVE_INPKTSSECYCTLX(a)
> MCSX_REG(0xb680ull, (a)) ...
>=20
Hi Simon,
Thanks for your suggestion. Will take this in different patch set.

> In any case, such a change isn't for this patch, which looks good to me.
>=20
> Reviewed-by: Simon Horman <horms@kernel.org>
>=20
> > +
> > +#define MCSX_CSE_RX_MEM_SLAVE_INPKTSSECYUNTAGGEDX(a) ({	\
> > +	u64 offset;					\
> > +							\
> > +	offset =3D 0xa680ull;				\
> > +	if (mcs->hw->mcs_blks > 1)			\
> > +		offset =3D 0xd018ull;			\
> > +	offset +=3D (a) * 0x8ull;				\
> > +	offset; })
> > +
> > +#define MCSX_CSE_RX_MEM_SLAVE_INPKTSSCLATEORDELAYEDX(a)	({
> 	\
> > +	u64 offset;						\
> > +								\
> > +	offset =3D 0xf680ull;					\
> > +	if (mcs->hw->mcs_blks > 1)				\
> > +		offset =3D 0xe018ull;				\
> > +	offset +=3D (a) * 0x8ull;					\
> > +	offset; })
> > +
> >  #define MCSX_CSE_RX_MEM_SLAVE_INOCTETSSCDECRYPTEDX(a)
> 	(0xe680ull + (a) * 0x8ull)
> >  #define MCSX_CSE_RX_MEM_SLAVE_INOCTETSSCVALIDATEX(a)
> 	(0xde80ull + (a) * 0x8ull)
> > -#define
> MCSX_CSE_RX_MEM_SLAVE_INPKTSSECYUNTAGGEDORNOTAGX(a)
> 	(0xa680ull + (a) * 0x8ull)
> >  #define MCSX_CSE_RX_MEM_SLAVE_INPKTSSECYNOTAGX(a)	(0xd218 + (a)
> * 0x8ull)
> > -#define MCSX_CSE_RX_MEM_SLAVE_INPKTSSECYUNTAGGEDX(a)
> 	(0xd018ull + (a) * 0x8ull)
> > -#define MCSX_CSE_RX_MEM_SLAVE_INPKTSSCUNCHECKEDOROKX(a)
> 	(0xee80ull + (a) * 0x8ull)
> >  #define MCSX_CSE_RX_MEM_SLAVE_INPKTSSECYCTLX(a)
> 	(0xb680ull + (a) * 0x8ull)
> > -#define MCSX_CSE_RX_MEM_SLAVE_INPKTSSCLATEORDELAYEDX(a)
> (0xf680ull + (a) * 0x8ull)
> >  #define MCSX_CSE_RX_MEM_SLAVE_INPKTSSAINVALIDX(a)	(0x12680ull +
> (a) * 0x8ull)
> >  #define MCSX_CSE_RX_MEM_SLAVE_INPKTSSANOTUSINGSAERRORX(a)
> (0x15680ull + (a) * 0x8ull)
> >  #define MCSX_CSE_RX_MEM_SLAVE_INPKTSSANOTVALIDX(a)
> 	(0x13680ull + (a) * 0x8ull)
> > --
> > 2.25.1
> >