Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   Geethasowjanya Akula <gakula@marvell.com>
To:     Simon Horman <horms@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>
Subject: RE: [EXT] Re: [net-next PATCH] octeontx2-af: cn10k: Increase
 outstanding LMTST transactions
Thread-Topic: [EXT] Re: [net-next PATCH] octeontx2-af: cn10k: Increase
 outstanding LMTST transactions
Thread-Index: AQHaIrZHFSEdVNY12EGY3dRjVkfxG7CUT2QAgARQRPA=
Date:   Mon, 4 Dec 2023 05:28:06 +0000
Message-ID: <DM6PR18MB2602CA69A2BD90500C4A9C31CD86A@DM6PR18MB2602.namprd18.prod.outlook.com>
References: <20231129112155.9967-1-gakula@marvell.com>
 <20231201113456.GU32077@kernel.org>
In-Reply-To: <20231201113456.GU32077@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F4r9ziHg2Tv8VSArU/E4ooixnvRE4OXAoU8iExMvHa8LzR3qOT5JGArfbCMI?=
 =?us-ascii?Q?mtIKL58Q44q11wBb6FjiJwmmxvV5rdUsSKpZ5Ux4vsEI3QGPRREl6+aaK05r?=
 =?us-ascii?Q?fqrJgsSnsTm1a9pH+rNkFrV+i3F9XnKIVSy0po2rNQry+FvPGe6gy8jcDfHP?=
 =?us-ascii?Q?mfbwHCM60LoCHcjBXxqSxRbn/johRLAgRMVuEkj6O5ZwgwcsFmBPoDq02PY1?=
 =?us-ascii?Q?sOly3TdYlC3E8TOXfHzJQKIqaXZcJb4cmSKRoTcKo+KVZvN+wcqmTPBH4yFb?=
 =?us-ascii?Q?P27EUWJSaJi5phxdaTU/HNspfYtZC0as2pqyVZRDmzPKpWYN242Q6NsPJ7i7?=
 =?us-ascii?Q?qBnjjC8NT7PC+fxmi1h3E2a/24Td1HLN0nCG6JlZFVTRGa+42nxZhQ7dz05j?=
 =?us-ascii?Q?sEOzXrVkesoISIHTHUGflMO5EhDE3AvagN+Hg3W6hQocZFwU4YFvaRLEBxLN?=
 =?us-ascii?Q?1XjKRnbRivL9mtl8kK/VoqRPfeSKdSBB442LeUiE2VGa1d/oA2VzORFBJxhh?=
 =?us-ascii?Q?KBjyL0xeC58q/trff2AwE5mo9KC61Vr7eBQqqg71dqjeUwB46q7UEv+Alh0P?=
 =?us-ascii?Q?j6TAjOx2yqdgkn33BzoYIVB3QiuEllmBs+D2tmLw6jynO/q6dheqg1G5NA1m?=
 =?us-ascii?Q?c9oh+jw/YI+y8bgn2sYpuNo8o9WNswDNiFk2HEj6gkBWgnilF09HCMi5/e/V?=
 =?us-ascii?Q?O3krkbszNqRB5mSnnG8D/d+XyuR4uHYh6fxwUuAfSpRjezH1FSAhvkfdP7JZ?=
 =?us-ascii?Q?4/hDMNk5eoOEDaFYVTsEtABgv07e4qkCVUWTcDOr3/mbEolS1yXZC1iassw/?=
 =?us-ascii?Q?uzjl/8mxJgu/++R6R5Q68274GnzMBiHm3s0u1stqY2XhzQF2i4Gl7S8MtFro?=
 =?us-ascii?Q?s0Yvr7vn/D14rhGSMy9rJhgVTNnF1+cbain3RmEd1U/6wFK25XyyN63Te/As?=
 =?us-ascii?Q?72SvuWm0LsgewQmKsbHGhaV2DGtwH7VOqa7Y6H/t9MWOncB4Si+ORUfXmz5G?=
 =?us-ascii?Q?N6+r63h92wO/HCflzizd0lkLJkJsy95yv7SKr9mWOfj0k1bZqzO6TZt44qPE?=
 =?us-ascii?Q?RHsmYanl/0zGB/ExgMqTS0jnPn54Lxk3jraCjdNLS/emiYg93SheVMTA62h0?=
 =?us-ascii?Q?OZiXLBBTdYGRpgyh0TsmX+xnOiqv3LTw58un0O4xT+DR8J0bCQB5O7CJ+SNR?=
 =?us-ascii?Q?0TIdeUrd89LkjDnnuRe34qTskcX0WIOJcyMi1Rk5ZA0F1UESUN/Z3JCYiVnq?=
 =?us-ascii?Q?5gqOwQaHuS4XOX7y+0LwHXsliPuC0DpHyLMLoYS45lQ8we1mSYi7rM6qxCBp?=
 =?us-ascii?Q?fJ5rboJLcb7g3extTeHktuScj//8o+T6qM6jDufMfci2XWNRrCWVFkkNxNwM?=
 =?us-ascii?Q?rnRZ/wdhVh4lOYwkuX1P3Id6oGzCctWEzN4UFPx+9lK9FCJAQpUH3k9YhE9L?=
 =?us-ascii?Q?kZKtqWHbGqSibAL6dFBNvn2/PxrYGT7DJzN7Qqz2lgyZMDLEtvvTLGF3C7ug?=
 =?us-ascii?Q?hYDAza9C2u03ZgPOx9Oe1yg3iwb9tQj1GcJAsq97ZIt7uHF070Jk5q0Qmjsm?=
 =?us-ascii?Q?66OOZq+UgHfBaM+uiXc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR18MB2602.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99f813a5-212c-4b82-3bd4-08dbf489cb93
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 05:28:06.5776
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7XPQ8ajKxaowPKnK4v8SQYHX1yg+m+mU62HRjIKF106YBKC2z/7x04G7Hnnl28xVAY6KXbuIpIhxiiGOGiuTpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR18MB5401
X-Proofpoint-ORIG-GUID: yhS5PGwBuDOuINYa2i6uAcVgNGe4QxvX
X-Proofpoint-GUID: yhS5PGwBuDOuINYa2i6uAcVgNGe4QxvX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-04_03,2023-11-30_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 03 Dec 2023 21:28:40 -0800 (PST)


> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Friday, December 1, 2023 5:05 PM
> To: Geethasowjanya Akula <gakula@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kuba@kernel.org=
;
> davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Sunil
> Kovvuri Goutham <sgoutham@marvell.com>; Linu Cherian
> <lcherian@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Subbaraya
> Sundeep Bhatta <sbhatta@marvell.com>; Hariprasad Kelam
> <hkelam@marvell.com>
> Subject: [EXT] Re: [net-next PATCH] octeontx2-af: cn10k: Increase
> outstanding LMTST transactions
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> On Wed, Nov 29, 2023 at 04:51:55PM +0530, Geetha sowjanya wrote:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Currently the number of outstanding store transactions issued by AP as
> > a part of LMTST operation is set to 1 i.e default value.
> > This patch set to max supported value to increase the performance.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > Signed-off-by: Geetha sowjanya <gakula@marvell.com>
>=20
> ...
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > index 0e74c5a2231e..93fedabfe31e 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cn10k.c
> > @@ -559,3 +559,12 @@ void rvu_nix_block_cn10k_init(struct rvu *rvu,
> struct nix_hw *nix_hw)
> >  	cfg |=3D BIT_ULL(1) | BIT_ULL(2);
> >  	rvu_write64(rvu, blkaddr, NIX_AF_CFG, cfg);  }
> > +
> > +void rvu_apr_block_cn10k_init(struct rvu *rvu) {
> > +	u64 reg;
> > +
> > +	reg =3D rvu_read64(rvu, BLKADDR_APR, APR_AF_LMT_CFG);
> > +	reg |=3D 0xFULL << 35;
>=20
> Hi Pavan and Geetha,
>=20
> I think it would be best to avoid the magic value 35 here.
>=20
> Best would probably be to use GENMASK_ULL and FIELD_PREP.
> Else defining something similar to APR_LMT_MAP_ENT_SCH_ENA_SHIFT.
>=20
> It might also be nice to avoid the magic value 0xFULL using a #define.
Ack. Will submit next version.
>=20
> > +	rvu_write64(rvu, BLKADDR_APR, APR_AF_LMT_CFG, reg); }
> > --
> > 2.25.1
> >