Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Shinas Rasheed <srasheed@marvell.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Haseeb Gani <hgani@marvell.com>,
        Vimlesh Kumar <vimleshk@marvell.com>,
        "egallen@redhat.com" <egallen@redhat.com>,
        "mschmidt@redhat.com" <mschmidt@redhat.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "horms@kernel.org" <horms@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "wizhao@redhat.com" <wizhao@redhat.com>,
        "konguyen@redhat.com" <konguyen@redhat.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Sathesh B Edara <sedara@marvell.com>,
        Eric Dumazet <edumazet@google.com>
Subject: RE: [EXT] Re: [PATCH net-next v1] octeon_ep: control net API
 framework to support offloads
Thread-Topic: [EXT] Re: [PATCH net-next v1] octeon_ep: control net API
 framework to support offloads
Thread-Index: AQHaJFjb+nsMFUaWhkuN7pMJLMvFsrCVXvyAgANQCCA=
Date:   Mon, 4 Dec 2023 06:39:14 +0000
Message-ID: <PH0PR18MB4734DF93FA905F7160AAE23EC786A@PH0PR18MB4734.namprd18.prod.outlook.com>
References: <20231201131815.2566189-1-srasheed@marvell.com>
 <20231201195843.118fdcfe@kernel.org>
In-Reply-To: <20231201195843.118fdcfe@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/jW7Hf8cW8h7DlKcISdUsXLuWd1RaSII8vdho/vexvBAiCZKrxJXwc3tN9Ke?=
 =?us-ascii?Q?dp7y486qHTlVkpSNDSzLxtKO1wbBeiHpNpga2zsbzRu+sxPfDNZWIEaTdXHG?=
 =?us-ascii?Q?ocu/9loaV+Ej9EkkQDg/cPZslnF+F2OpeBumRsZRgPRMaMN8mI9J2vDJyvB/?=
 =?us-ascii?Q?Qu8GoXat+yP7oMO9rYgt8bHCUSdHcNZpAApVeea/jbWau1i43dK58Z+Vk+PJ?=
 =?us-ascii?Q?ExQh64asWk6yIpDA2OsObvq3BGqBNhlXjw3gb0hMFxaI+3cD3/S8mk62/D3v?=
 =?us-ascii?Q?sLxfoDqlwipyzRhl0T2YMljKV85aqpJgwRSPfQCs77ygdhA7Yi5U6s5Z7THU?=
 =?us-ascii?Q?NvWsEhnyXUZteCZh8jGUWBCkZBPAyikvDTTrvCFoqi1D/gR1rzWuauoMxGj0?=
 =?us-ascii?Q?UIlfMZwHUcNGwpniAFBqwh6Ki9lZNVXrQA4vBqFA+YJb7inIDaCxM6pDjC5c?=
 =?us-ascii?Q?Sa0RJqqEdV/hDg31ICkIIeXWGbYbwWgmma8DwtSy0FJVbIXq4ZcxfRAqyjHh?=
 =?us-ascii?Q?IoCet3FK0l7TilJCmXrMS823qrcFO4ed8UmPLPhHJ+mYKB+56Wpa2l/2+hZ0?=
 =?us-ascii?Q?MoUn3Hh64nFx2C172Up7yzqhmaTkPPVTUld9LY486q1HryxkgvicKIZg3zQ+?=
 =?us-ascii?Q?27IuQE3xIMSmj0agYKs1KE7fntDjHaSwR9B+KZHtLA7lCET0XeFKMcj63zyN?=
 =?us-ascii?Q?MVNtuzcJikn8AxsyAGh5affwzVpoYq7TEs9lKGi0/Ebnr0a9j9kHd07cjG1M?=
 =?us-ascii?Q?D1fvE6AdGBL+PtScFJAHdYp1XmrimRb6nyGYGxZTSzUpqyjoQxm/JuozmpyC?=
 =?us-ascii?Q?Vu2wBflRRqxFoeFsNrRBzvLbZfXPgoNi8DrIMwiSFnwwviCVQPye7VFci25C?=
 =?us-ascii?Q?mtQUmhliamx6qUWj/DbGvSNzt6zgndchQ2wklvqEusx1l54EaeNA26YnMX1Z?=
 =?us-ascii?Q?ZKCCy2Vl/+l6t23FK2CYbInF3PDUiaqwrJhnLSrjXeofd6mqddsB92J+otwa?=
 =?us-ascii?Q?zSDVkACedP8qI0FlYt7WaDxsacGWv4q2S1SlaU6LEUZLltNLP1yQWsZoLvM6?=
 =?us-ascii?Q?0ax4ANqs23J3Q4+wVbEte4fM7ycvWNxOTjllIO9CW1zq+9iVhAIGxFKJF0O6?=
 =?us-ascii?Q?c0JgmhS2ecWHHEEraExKIncpw3sP33QvR9+aeSVoyNpxZorKA8pf9VpFYv5c?=
 =?us-ascii?Q?Ggt90cDIW5TgsivqsaJqhfXjtlFrmCeKwwh86eRCgv7zRWhzerxlotQxFYpj?=
 =?us-ascii?Q?NY2kYdfZ0/rbfifMU6KkOD9CV4Ex6D4fCbkUaRdqJttuMrW5jMbIy7S15k6G?=
 =?us-ascii?Q?uUoIHZndHzd89b60H0wKwsISK9oPPnJ8bWhfBandqss3Zy9z/mm7ce6AyLFO?=
 =?us-ascii?Q?Ir2lIWsly4KOycuPIWYGTFTj/OzDF4hKiPxUM/ezFOuhpCWEe/fW4XF9AU5D?=
 =?us-ascii?Q?1N9qhyISFUqK3ViZ4BzxkgxIlHBR4d69N6ddqCKw2HLsOJYmVmiG0Q3+KSKY?=
 =?us-ascii?Q?qPwP76XD8m/EsEp8BcvVQ+2X+mQlMVIqvJ37uSZLQisQd/607fzPq1vKVtLQ?=
 =?us-ascii?Q?6ILT0wW1xJSppxvoPvmKKVqh2Syo5LlqPoNI1PBt?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4734.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bc85aa59-cd98-457a-0a77-08dbf493bbaa
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 06:39:14.8357
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mHonn58xph9/n4JftStTql4c78tc1FC5dnHIV16pwB2BMonFG4FA5MxCduUxdYTh/l9GD2QjqGeuXaGwOcohtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR18MB4227
X-Proofpoint-GUID: s2olImTWwRWyUpQbT581QFfIg6o0Ew3g
X-Proofpoint-ORIG-GUID: s2olImTWwRWyUpQbT581QFfIg6o0Ew3g
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-04_04,2023-11-30_01,2023-05-22_02
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Sun, 03 Dec 2023 22:39:36 -0800 (PST)


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Saturday, December 2, 2023 9:29 AM
> To: Shinas Rasheed <srasheed@marvell.com>
> > +static netdev_features_t octep_fix_features(struct net_device *dev,
> > +					    netdev_features_t features)
> > +{
> > +	return (dev->hw_features & features);
> > +}
>=20
> Why is this needed? The core kernel should already make sure
> unsupported features aren't requested.

Yes that is correct. I also don't see an interdependency between features t=
o decide anything in this function currently, so I think perhaps fix featur=
es can be implemented later on or even just return the obtained features it=
self I guess. I'll submit an updated patch set. Any other nits to update in=
 the next version?