Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <b1fa2827-61fb-4594-8f80-e5083be8d5fa@amd.com>
Date:   Mon, 4 Dec 2023 09:17:08 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/radeon/dpm: fix a memleak in sumo_parse_power_table
Content-Language: en-US
To:     Zhipeng Lu <alexious@zju.edu.cn>
Cc:     Alex Deucher <alexander.deucher@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Jerome Glisse <jglisse@redhat.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20231203171643.3287229-1-alexious@zju.edu.cn>
From:   =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <20231203171643.3287229-1-alexious@zju.edu.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekxXZ1RqNGFqbGU4bWpEbDU2NnZNM3h5YWwzeENkSXJXQitQc1laK2RZSVJj?=
 =?utf-8?B?SVplT1h4ZXM2NW9tZ1FEaGtFaXhibDBGZ1VPSUFwQmFYUzVWTDhxUDVac0c5?=
 =?utf-8?B?R1BUbTM1cXpUVDhGbnMrVWpqN3VkNDJSWkdSd1lQS1VZNnhjOVlxS294Q29Y?=
 =?utf-8?B?OUhQcUNFNWpKZGczMTVHUXJoMHMySGR3K1RqbmFETjlyUHpaYi9KZnNhblBs?=
 =?utf-8?B?d1BJZEprMEVXc1NnSGU1cys4cHhnZVFZTFRxa3l1cWM4VmlFcXRSQ25ZalJh?=
 =?utf-8?B?WXEzZVIxTjZyWHlBcW9TMDlyUFVmdmRWUmFwY3EzQ3FDeHJBb25pRmxWQWY1?=
 =?utf-8?B?UHppM3BWdy9iYXUyMFYyTTJvTjRzcmUzZFFBWkhWVXVGdGZVT2dWRE43ZmhC?=
 =?utf-8?B?eFFrZVUwZW9VaktQNWdaVmhNNWJkbTlDUWdjc3VvVHdBcWxqOTVsbEV6Wmtv?=
 =?utf-8?B?Y1JsNk1VMWplVXNoS2FSYmFJUzhJZ2ZTQ2JRR1p4OEU5QUFYZEY5MGF2K05l?=
 =?utf-8?B?YkU1NHZtSnRPcWRMVE5hQWIwMEhybkxYZ3RQM1FVTkJIbDdiQ1RVbzU4OEw1?=
 =?utf-8?B?R0pxQ0dCeDV1c0RYWGRUbk1sT25WVUl0ODR6ZVVKeFJXbG1NWm9ob0pTNVl4?=
 =?utf-8?B?cHF6T2daQTVlSURKSWZFU1JJZS9tS2RoMk9hUEhGdmtJYmVmS3FYT2VYeFRO?=
 =?utf-8?B?OW5WU3RwL1lmTzF0ck1MbFRxeGN4WXJLRDQ1c1U3TzFwT0FLYTAvVVliUEJ0?=
 =?utf-8?B?QjRWUmNsbDk2SG1pT3p5aTMxeXR0dG9laSs5ampJbk9NZzNtamRyallqNDh5?=
 =?utf-8?B?Z2t5bjlHY25HQlZrWGJqTFVRMkk5dXVMallkejVhQk5ORWU4S2I4OFhsZWsz?=
 =?utf-8?B?MWRsdUhQNWNNSjJZS0hJODlEQ0l4TE9XM0dZbXN4YXh6aURXc2Y3dWtZcy9W?=
 =?utf-8?B?NnA5VWx4RFlYY2RQTGZSdjhFakxTZ2xzeWRvTXUyUkZmOHUvTXlNQjVCckFK?=
 =?utf-8?B?djBEQ1B3NmJING5qdThRR2x2VHhKa21JYTlyMGRDbnVNWTRycmY0UUF3ZW1D?=
 =?utf-8?B?TGkwYUxablMwTTQzc0ZHcDdVcTh3cFVidXJJbVJJNEljcjJXWFBpeWUybm5R?=
 =?utf-8?B?MWxoVWtnU2JnbmpTbjMzWFB0ajVmbDhJOXhPemt3RVpYRW0wL1g0Y28ra0FJ?=
 =?utf-8?B?Tk94b2xOais1U1BOWWs3Zm84SnRpTExscDJUUGhNZmVMNUZkdGowNVhGRUdM?=
 =?utf-8?B?aU9RcHBycHFhY0ZubWVVRVllUHhobDR5aW95aVl5WTFZR0RWMlJ2NUd4M0NE?=
 =?utf-8?B?VHJFZlRWU3VORlh6OUFDSGFjeDJmcFUya0JZWTg1RkRSR0RKL0NjRmZTTjh2?=
 =?utf-8?B?V251a09mNmVqYVBqWHYyQVY4STRyNThCMS9UbHNxSFlOUmVCcHVVVjRta2pJ?=
 =?utf-8?B?K21Ga29yc015Tzg4K010ajZmQ3VmR3liWHN3UldzNDJpYWR3WWoxcjA2T0l0?=
 =?utf-8?B?R044TlZ2Q0FVZEY3dTh5MDIyVStucjlkS3dxUkRvTWY0QnJ3bUlVUlZ5TjRH?=
 =?utf-8?B?RkwvM3BzSSsyeHlxeEJ0RFJnUkJWSWp2U0x6RVVnQUVvcEgxMFA5TUJRVWk5?=
 =?utf-8?B?MXJOMkpxeHJvTlR5dzV5bFNwZkFueTFiRVlTbE04WEl0M2NJRkZWZHVJRXV6?=
 =?utf-8?B?NnROamx6UVJWTmhpbmJ0TWFZeUVGemJHTTVDNFpHWVZpeHJlQ2pEencxbXNM?=
 =?utf-8?B?RU1uTlduemZvTVV3bklwSDN4NjV2WnVNZ1hrZEVRbmpjbGk4aXlMdndhbXpw?=
 =?utf-8?B?T1RvOC9mWGJEemdJYjllTFVlYzUwWmhPakRrNVlRYUN5RlJOLzcwUTVJWDh6?=
 =?utf-8?B?Rk9oMHVwekRQck1pL1l1SVFkemlMSDhLaTRLd1Y4VFYrd0VQVXN6T2EzRVBv?=
 =?utf-8?B?Z2IvOEdMYjgxeFVrTTNGYU9BSDBjNHpZb2JKb3FFZXRSempQREZjODNRcjN4?=
 =?utf-8?B?anRCTW4rWnpkY3A4QldraG9YRmFnaUJ5UFBmMEIwdmZPZVFEWksvd3hNam9G?=
 =?utf-8?B?Sm4rYzFNQ05PNHFMdEtCL0FUMjNSZmhTVWI5dU96cEIvV1ZMMGtkVHJydHl0?=
 =?utf-8?Q?D8N4=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 674e21a5-6d1c-4a96-da2f-08dbf4a16c04
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 08:17:14.4971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kJEJYWj9CK0nSrLexIkLuzjBWFqWl9q4S1KDzAycqCpO4Wy1Fjvk7twm11HX7VLG
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7130
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 00:17:27 -0800 (PST)

Am 03.12.23 um 18:16 schrieb Zhipeng Lu:
> The rdev->pm.dpm.ps allocated by kcalloc should be freed in every
> following error-handling path. However, in the error-handling of
> rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed,
> resulting in a memleak in this function.
>
> Fixes: 80ea2c129c76 ("drm/radeon/kms: add dpm support for sumo asics (v2)")
> Signed-off-by: Zhipeng Lu <alexious@zju.edu.cn>
> ---
>   drivers/gpu/drm/radeon/sumo_dpm.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/sumo_dpm.c b/drivers/gpu/drm/radeon/sumo_dpm.c
> index f74f381af05f..bde640053708 100644
> --- a/drivers/gpu/drm/radeon/sumo_dpm.c
> +++ b/drivers/gpu/drm/radeon/sumo_dpm.c
> @@ -1494,6 +1494,7 @@ static int sumo_parse_power_table(struct radeon_device *rdev)
>   		non_clock_info = (struct _ATOM_PPLIB_NONCLOCK_INFO *)
>   			&non_clock_info_array->nonClockInfo[non_clock_array_index];
>   		if (!rdev->pm.power_state[i].clock_info)
> +			kfree(rdev->pm.dpm.ps);
>   			return -EINVAL;

That change is obviously not correct since you now always return -EINVAL.

You need to at least add {} here.

Regards,
Christian.

>   		ps = kzalloc(sizeof(struct sumo_ps), GFP_KERNEL);
>   		if (ps == NULL) {