Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069
MIME-Version: 1.0
Message-Id: <dc1ba294-233a-4308-81df-23783487b817@app.fastmail.com>
In-Reply-To: <5402aa8a-a20f-4d28-bd36-3b88702ea6ae@huawei.com>
References: <20231204072932.1077878-1-arnd@kernel.org>
 <5402aa8a-a20f-4d28-bd36-3b88702ea6ae@huawei.com>
Date:   Mon, 04 Dec 2023 09:52:58 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Jijie Shao" <shaojijie@huawei.com>,
        "Arnd Bergmann" <arnd@kernel.org>,
        "Yisen Zhuang" <yisen.zhuang@huawei.com>,
        "Salil Mehta" <salil.mehta@huawei.com>,
        "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>
Cc:     "Hao Chen" <chenhao418@huawei.com>,
        Netdev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: hns3: reduce stack usage in hclge_dbg_dump_tm_pri()
Content-Type: text/plain
Precedence: bulk

On Mon, Dec 4, 2023, at 09:31, Jijie Shao wrote:
> on 2023/12/4 15:29, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>>
>> @@ -981,7 +981,7 @@ static const struct hclge_dbg_item tm_pri_items[] = {
>>   
>>   static int hclge_dbg_dump_tm_pri(struct hclge_dev *hdev, char *buf, int len)
>>   {
>> -	char data_str[ARRAY_SIZE(tm_pri_items)][HCLGE_DBG_DATA_STR_LEN];
>> +	char *data_str;
>>   	struct hclge_tm_shaper_para c_shaper_para, p_shaper_para;
>>   	char *result[ARRAY_SIZE(tm_pri_items)], *sch_mode_str;
>>   	char content[HCLGE_DBG_TM_INFO_LEN];
>> @@ -991,9 +991,13 @@ static int hclge_dbg_dump_tm_pri(struct hclge_dev *hdev, char *buf, int len)
>>   	ret = hclge_tm_get_pri_num(hdev, &pri_num);
>>   	if (ret)
>>   		return ret;
>
> Thanks,
>   But it would be better if there is an empty line here.

ok

>
> all exception condition also need to free memory before return. eg:


Indeed, I'll send a v2 in a bit.

     Arnd