Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2584118rdb; Mon, 4 Dec 2023 01:25:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IGNBBmJjjxX44XPnZPH4f+ICrbzeyO9gZ/tF3fKRnlyF+8Pw7fFaKJWEMg/lL63wdGjnyjR X-Received: by 2002:a17:902:708b:b0:1cf:d634:367 with SMTP id z11-20020a170902708b00b001cfd6340367mr17000154plk.56.1701681938868; Mon, 04 Dec 2023 01:25:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701681938; cv=none; d=google.com; s=arc-20160816; b=PZAbFRhVExIVZD/YLu2bf+ww77+0sRncd2xliqgU5mI6WQiI5yvtFSM8XfZ6jzOorm cSaCuM03/usnV0pTVQD5klG5m3UKVtL0BEoHVfR/ToZyojdHfGdNKfKKU7W8X0DyoG5d y+gtpmMvMSrCfA6a4fQq6woOR6yKNL664S9Nwrcpaf5Na4JUUAhCo+xAPEnRV/+XB5aU py+mBb/EXsuSU1UJIO04CrCCYOGGs4NjqQfEhR9crwwuQVi+2GK60KVA+NtkEXnmlP1f X8WIWyTu+MAfQn+nH3bJfkagr2FIWBqFNPus4lu+/UiEdhP43QtOdszDHL42Wlz0wnCs 4Uvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=bZg7Uz7l/oLXksQdbuK4eufPIvGHkgjgcRzamCHOkzE=; fh=7Tr+rUj8bkwsVt6Y0h9TaNU4GyoXVoRZi37lykSN9fQ=; b=ZdqNEcGPQA47ID17wnCsCfSzoNcwYP5Ii/bPIbyw1aEtBmYkYhhQS5EjwOUyuABcMf Ky+vnnEj7ph+s0WPDPyG7LIfxk3CfApPOOwlPNQGal+Do77oaCuTeGPgK8RBdrF40SKc rk02K9E8PArgj5y8vSwEKWE+PlDtj0yPtiZhDgC/NVwE78KiBk0kC0mPZt9E40Ww33ij 7vZwZgOL1LShXalwG4ARsM2uN8XwFNnBQOfcLu1Hrkha1zfgz4zr6XA3S9WMXWbWXW0e XSqvaAjoVqQ4VY788pcy4ET7ybgx/PB+lesKEqYh2E0ymra+yQePF9ZOvHWNtbDl+qfF PL6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id u18-20020a17090341d200b001d0a8b8e210si1215359ple.526.2023.12.04.01.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 01:25:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 2E6DE8084612; Mon, 4 Dec 2023 01:25:36 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbjLDJZK (ORCPT + 99 others); Mon, 4 Dec 2023 04:25:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbjLDJZJ (ORCPT ); Mon, 4 Dec 2023 04:25:09 -0500 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE2F1C3 for ; Mon, 4 Dec 2023 01:25:14 -0800 (PST) X-UUID: ca51dacefc1d4e65b834832015ee8d7b-20231204 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.33,REQID:2ddbf53d-f3cd-4a14-8e9e-fa6542c7399c,IP:5,U RL:0,TC:0,Content:-5,EDM:-30,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,AC TION:release,TS:-45 X-CID-INFO: VERSION:1.1.33,REQID:2ddbf53d-f3cd-4a14-8e9e-fa6542c7399c,IP:5,URL :0,TC:0,Content:-5,EDM:-30,RT:0,SF:-15,FILE:0,BULK:0,RULE:EDM_GN8D19FE,ACT ION:release,TS:-45 X-CID-META: VersionHash:364b77b,CLOUDID:4991ca60-c89d-4129-91cb-8ebfae4653fc,B ulkID:231204172511L5AJDDL3,BulkQuantity:0,Recheck:0,SF:38|24|17|19|44|66|1 02,TC:nil,Content:0,EDM:2,IP:-2,URL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil, COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_FAS,TF_CID_SPAM_FSD,TF_CID_SPAM_FSI, TF_CID_SPAM_ULN X-UUID: ca51dacefc1d4e65b834832015ee8d7b-20231204 X-User: chentao@kylinos.cn Received: from vt.. [(116.128.244.169)] by mailgw (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1216688055; Mon, 04 Dec 2023 17:25:08 +0800 From: Kunwu Chan To: lee@kernel.org, arnd@arndb.de, s-anna@ti.com Cc: kunwu.chan@hotmail.com, linux-kernel@vger.kernel.org, Kunwu Chan Subject: [PATCH] mfd: syscon: Fix null pointer dereference in of_syscon_register Date: Mon, 4 Dec 2023 17:24:43 +0800 Message-Id: <20231204092443.2462115-1-chentao@kylinos.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 04 Dec 2023 01:25:36 -0800 (PST) kasprintf() returns a pointer to dynamically allocated memory which can be NULL upon failure. Fixes: e15d7f2b81d2 ("mfd: syscon: Use a unique name with regmap_config") Signed-off-by: Kunwu Chan --- drivers/mfd/syscon.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index 57b29c325131..c9550368d9ea 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -105,6 +105,10 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_res) } syscon_config.name = kasprintf(GFP_KERNEL, "%pOFn@%pa", np, &res.start); + if (!syscon_config.name) { + ret = -ENOMEM; + goto err_regmap; + } syscon_config.reg_stride = reg_io_width; syscon_config.val_bits = reg_io_width * 8; syscon_config.max_register = resource_size(&res) - reg_io_width; -- 2.34.1