Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Mon, 4 Dec 2023 09:33:01 +0000
From:   Jonathan Cameron <jic23@kernel.org>
To:     Bhavya Kapoor <b-kapoor@ti.com>
Cc:     Wadim Egorov <w.egorov@phytec.de>, <lars@metafoo.de>,
        <robh@kernel.org>, <heiko@sntech.de>, <peter.ujfalusi@ti.com>,
        <mugunthanvnm@ti.com>, <linux-iio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <nm@ti.com>,
        <upstream@lists.phytec.de>
Subject: Re: [PATCH v2] iio: adc: ti_am335x_adc: Fix return value check of
 tiadc_request_dma()
Message-ID: <20231204093301.05c19b96@jic23-huawei>
In-Reply-To: <0c26613b-4aba-4e1e-bf0e-57feff23e303@ti.com>
References: <20230925134427.214556-1-w.egorov@phytec.de>
        <20231005150917.2d0c833e@jic23-huawei>
        <a58ae80e-e281-425a-9b72-bad8fd305e6a@phytec.de>
        <0c26613b-4aba-4e1e-bf0e-57feff23e303@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 27 Nov 2023 15:14:29 +0530
Bhavya Kapoor <b-kapoor@ti.com> wrote:

> LGTM !!=F0=9F=99=82
>=20
> On 24/11/23 5:41 pm, Wadim Egorov wrote:
> >
> > Am 05.10.23 um 16:09 schrieb Jonathan Cameron: =20
> >> On Mon, 25 Sep 2023 15:44:27 +0200
> >> Wadim Egorov <w.egorov@phytec.de> wrote:
> >> =20
> >>> Fix wrong handling of a DMA request where the probing only failed
> >>> if -EPROPE_DEFER was returned. Instead, let us fail if a non -ENODEV
> >>> value is returned. This makes DMAs explicitly optional. Even if the
> >>> DMA request is unsuccessfully, the ADC can still work properly.
> >>> We do also handle the defer probe case by making use of=20
> >>> dev_err_probe().
> >>>
> >>> Fixes: f438b9da75eb ("drivers: iio: ti_am335x_adc: add dma support")
> >>> Signed-off-by: Wadim Egorov <w.egorov@phytec.de> =20
> Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>

Applied to the fixes-togreg branch of iio.git and marked for stable.

> >> +CC Bhavya,
> >>
> >> Could you take a look at this given you had comments on v1. =20
> >
> > Bhavya, any comments on this?
> > If not, is there anything else that is blocking this patch?
> >
> > Regards,
> > Wadim
> > =20
> >>
> >> Thanks,
> >>
> >> Jonathan
> >> =20
> >>> ---
> >>> v2:
> >>> =C2=A0=C2=A0 - Update description
> >>> =C2=A0=C2=A0 - Drop line break after Fixes tag
> >>> =C2=A0=C2=A0 - Move decision about optional DMA into probe/caller
> >>> ---
> >>> =C2=A0 drivers/iio/adc/ti_am335x_adc.c | 4 +++-
> >>> =C2=A0 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/iio/adc/ti_am335x_adc.c=20
> >>> b/drivers/iio/adc/ti_am335x_adc.c
> >>> index 8db7a01cb5fb..5f8795986995 100644
> >>> --- a/drivers/iio/adc/ti_am335x_adc.c
> >>> +++ b/drivers/iio/adc/ti_am335x_adc.c
> >>> @@ -670,8 +670,10 @@ static int tiadc_probe(struct platform_device=20
> >>> *pdev)
> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 platform_set_drvdata(pdev, indio_dev);
> >>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 err =3D tiadc_request_dma(pdev,=
 adc_dev);
> >>> -=C2=A0=C2=A0=C2=A0 if (err && err =3D=3D -EPROBE_DEFER)
> >>> +=C2=A0=C2=A0=C2=A0 if (err && err !=3D -ENODEV) {
> >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 dev_err_probe(&pdev->dev,=
 err, "DMA request failed\n");
> >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto err_dma;
> >>> +=C2=A0=C2=A0=C2=A0 }
> >>> =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return 0; =20