Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2603559rdb; Mon, 4 Dec 2023 02:11:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IGTJXGSNL7ZvYffHv2BOSgaziVhL4Wyu3G6BxlxVApnH1VX7jGHKeggtZ6HgL7rbE8Y/ZdN X-Received: by 2002:a05:6870:3287:b0:1fa:fbef:1773 with SMTP id q7-20020a056870328700b001fafbef1773mr5411233oac.52.1701684711434; Mon, 04 Dec 2023 02:11:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701684711; cv=none; d=google.com; s=arc-20160816; b=ImiSCAQLjeZmroHyvehMP6gRUf2K+lkeP4u66aJdw+rso47f40JmF9XRk+1+ThA/sF oKSG9mqHAjiRvjVQLPkzTKgLD3iCydj38TOU4VrukwhdXCFNvesXK6xd2GihZeDPP5Xt MJjF9bOY+jIcUYloRpMcr5TYEzysA9pJnF4fNkAcUmp5ivb4YWNArsM36fM37KZ6z+0K 2VMMbkM+AUnp/GdU+0GxpdZg0VkS0NWB41bz/4iDu8asVqabcSqz1gJgZb2dHz3TKnPC Z1w6Sdqp4+FYGcoTIc7GUB3i+D3TC49bUXRPqhaYmXxop1e9gQ75V6bM6L4cYqcJEGVy EvSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=O//OwtlB9xUHI8xzdgP82D84QZPMtvN/fGhDIUI/1Yo=; fh=YBcVSHytjpgxrY9dIpkze/pzT+7W7WQy+k8yC6QVkpo=; b=nM2xJGizcpObjUCr5DFdwPywFdlGMhPlFH/TVUvzQfgiyi2DmdNJW68HiiFB1jy34g ASFm10QQSTULtFMZOBS0SJQkPYGtVPQX93ORmaFJRuY9RM8M6jg6yY1DBwJsz7ZTqK3s AMVm7bg9mso3tX1wNL4jfi2nz1NiCqwiYF1qigjAY/KWHCsXCqcZ1bDQM18F+EwveqSH WXkUToluX/9RvImpwhoUFWd07ErtsqrSOiAtEa/RxmQV4mrmGw0uzRaLg2nr9EFUNYgw YxskI7jpxnAIndLlktihotv+3avZFvhYhld6fgQ9XMSvo2pM/0mFYdyDeFnOOe7gPQRL JyLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fCv5j0F9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id h2-20020a63e142000000b005c179c0075dsi7461980pgk.883.2023.12.04.02.11.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 02:11:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=fCv5j0F9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 53680807F179; Mon, 4 Dec 2023 02:11:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230287AbjLDKLe (ORCPT + 99 others); Mon, 4 Dec 2023 05:11:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbjLDKLc (ORCPT ); Mon, 4 Dec 2023 05:11:32 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30A00103; Mon, 4 Dec 2023 02:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701684699; x=1733220699; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=p6Klwtsa8H36R/4ygyuhGjGbPY4N4JOBgFJRY200D3g=; b=fCv5j0F9Qs1aDVJX6gr128V8zIlKZNaaS7J9rAdeUdxPXC7ehadcGmks vBGn5SCarlAoM+jS85T8XPj77j+FSCBykDl+MvvQWcsIHORYGUNPyXiS2 Qi8eKbqkvAT3/CbvQSHNwbO9NekK2tDJiX22505tkhxOc1WDP6p5EqyF8 upja/cc14kFBl9RRcsnpHuS8fZyKONAMVwFWEx/RXvlOIX34u+tNKcQt4 Wb9sTG0OqL8ek2tl/bV56zKVcp2Nr9vqEHbx+VLOFA7KH81I8RKJEdzz1 KOkr8RxZjtMlUoE63yzTgREJsW+qrFxQlaIUOzJyDqzVtE7LMV5wD9DiK Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="458033399" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="458033399" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 02:11:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10913"; a="840975746" X-IronPort-AV: E=Sophos;i="6.04,249,1695711600"; d="scan'208";a="840975746" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Dec 2023 02:11:33 -0800 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 0EC7311FB88; Mon, 4 Dec 2023 12:11:31 +0200 (EET) Date: Mon, 4 Dec 2023 10:11:31 +0000 From: Sakari Ailus To: Vincent Knecht Cc: Tianshu Qiu , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yassine Oudjana , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] media: i2c: ak7375: Prepare for supporting another chip Message-ID: References: <20231201181350.26454-1-vincent.knecht@mailoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201181350.26454-1-vincent.knecht@mailoo.org> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 04 Dec 2023 02:11:49 -0800 (PST) Hi Vincent, On Fri, Dec 01, 2023 at 07:13:48PM +0100, Vincent Knecht wrote: > In view of adding support for at least one other chip, > change the driver to move chip-specific properties and > values in a common structure. > > No functional changes. > > Signed-off-by: Vincent Knecht The patches seem fine, thank you! I'll merge them soonish. Somehow the DKIM check fails in b4 while it was successful when receiving them patches via my mail server. Just FYI. -- Regards, Sakari Ailus