Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <c382dc51-3a3c-4c79-90c0-13e2e716d0a9@intel.com>
Date:   Mon, 4 Dec 2023 11:19:59 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2 net 2/2] net: hns: fix fake link up on xge port
Content-Language: en-US
To:     Jijie Shao <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
        <salil.mehta@huawei.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
CC:     <shenjian15@huawei.com>, <wangjie125@huawei.com>,
        <liuyonglong@huawei.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20231204011051.4055031-1-shaojijie@huawei.com>
 <20231204011051.4055031-3-shaojijie@huawei.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231204011051.4055031-3-shaojijie@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Umo2QklGeHVDK0dDalE5OE1TTkJPMG5NbHBLL0wxd2JzL1EzVG5aNWtnTyty?=
 =?utf-8?B?TXRsWnZMbHdPaUFoTGw0U3FXUXVsakJCb2hXQTdUU3FUZ1Y0ZGFvVndiZ2Vx?=
 =?utf-8?B?L0pQUnRlV0FWcUdQejg0eXZLQVFJZWdHbzNucVpQR0txZGFyTEEvRHpFMWpx?=
 =?utf-8?B?TVVUYm9JYmlNQUtjWE5OK05xRVFEUENtRGRGeVdXcVcxRVg3YkxiUkNLNkEy?=
 =?utf-8?B?cE43dHhvcjlTVzRWMkkyQWhjRGk2RWhhL0R1MU9oRlpwOG5mYjNJRWFFQlI0?=
 =?utf-8?B?NGwwZmpvRVErL05CeUNSMyszbDc5ZGk2eTR6Z29OTUEyN0VhNENuYWNJVUtZ?=
 =?utf-8?B?eThrQ0ZPNzZwNEx3UUM3blUzbDlyZHUrY1JKaER6NFZzekRuMG5zdGtPTmow?=
 =?utf-8?B?SWY2dEhYUi9MRThncmhTTHpnRVIyUjZTZG9WenIwc0N6eHlhcjZQWFN6ZWIr?=
 =?utf-8?B?bE9yTU9mRkRQWXZkRmt1a0RNd1llZWRBdThoSU5kTHkyWGozdW5DY2t6Zytm?=
 =?utf-8?B?bXBoMURQSHVsQTQwd1lpeVhlUVpTOTU0YUd2N3ltQk9oRVRBUHJVb2dPSW9l?=
 =?utf-8?B?ZEVkZVlZdTN0N1pONVFuMmgvOTArNC9HUEU0Q3hEMVNzUTlsdVF0NmlHUGNH?=
 =?utf-8?B?eWRoNnpyemcvc3N0emxZZkpyeVZwbDJxK04vVURCMWVxY3NMa09jU01ZYWdk?=
 =?utf-8?B?TlA2NUZackdLYjZBT2VyOENvdVJMZzUxYXhFTnc1T0xXcG1uaUtnR3RhOEdh?=
 =?utf-8?B?emd6U3djM3VFbXVjR0RPVm5qVHdPcVJsZHVpQkxTOG5UMG9zQm5LZVNBSmU4?=
 =?utf-8?B?MnNhUVFkTkZsQWNjSXJndlZhRkNneldTQUJwMXNzWXRXdE1COW5FbEVPUnpQ?=
 =?utf-8?B?YzdJWCtYTlVxUUQ1K3hRUDNlQmxTMVBWTk5xYlQyWDJOMURFOGRmK0ljeVNW?=
 =?utf-8?B?RHpCekR3L1pQNWJzdVVIV1V2V1JSbXlSaTNHZHlTaklYaDZmWmxLNkF5SG9C?=
 =?utf-8?B?YWM5YVFTc01ZbGcyZUU2NWQvaThpTWdGWGVrRkFIZVFINmJFejZ0MnM1QTZw?=
 =?utf-8?B?bW96djZXNFRiVWQzRGhkWlNWYld4MGFIeVpKZjBab0kyMXdQMlRoZzBpL2p6?=
 =?utf-8?B?ZUJnQUV0ZGdnZnR3RGFWK2wvQ2hrY3V2U3M4OUV4b2xSaHo1cTZVNi81MVVq?=
 =?utf-8?B?Mnl5OWoxT1VVNjZRYkFqbjZSNWF3MG5ReU44aURNeFdtb3ZEUDUycm43RUcv?=
 =?utf-8?B?ajNQSC9LWkhuaEY0VnpYRFM5L2psK2JXaTE2cm1zOFJRUHhnSUdzVmt1MFZF?=
 =?utf-8?B?N001enoxSnhzOTdMWXRwZDdTbG1jelJzcnNFZ3ZrVTlGVzNpbDZldGJIRlA2?=
 =?utf-8?B?RFoySE1VK0hQWmZNWkt5ZXgvSHRzbnlFR2ZRMThHV3d3QU5VVkc4bmJjYnpE?=
 =?utf-8?B?ejJlN3BmbVlTN3JqazFZYmV3a0R2ckI5cFN4RWg1cnhMU2I0QjU0dFdyMGcx?=
 =?utf-8?B?cWhOUFhXbjdpMk9yRHJzem9OeFlhbmMyc3R6bnJCeFBreEpwUWNXNGNrNUZU?=
 =?utf-8?B?WjVtWFRaVkpjSUJTM05SNTNMcDJLbWlFZktySGl5elJzbngyWWpZMWdZamNY?=
 =?utf-8?B?QjhQZ3hQTzVwVnd3UjdSZFQ5NFowVzUzVEg1aXgvZXJPOUxDQnQ1N0ZQSmtF?=
 =?utf-8?B?Uk5UMXhJV0VBdjQ0bUFHTGpBSVl2NmwvR0krM1A3ZTVvTFJFMG5kN0ZJR05p?=
 =?utf-8?B?MnlWQm04K1FPay93RUdYSGVTRWZuY1JnN1Y2ZWhMVUt1QVBVYTJ4SjBIZ210?=
 =?utf-8?B?Yzl3OEZKQ2JKdVV1ZVY0Yjk4YXZHMmQyTUFKVEl2c0FnYUpRVjAyYXY0a2Zv?=
 =?utf-8?B?OTZneHFtNTBWeGdwUVZ4NFN3QlZKekptNEIvSzk0aWZMbnAvVXJoTWhnRlJG?=
 =?utf-8?B?aGlUK0llbVovSEhoUGFoZlpiaUtOZ0YyMTFaL0lZNWdMaG52MEJvNm1IMTV1?=
 =?utf-8?B?R1Q2K1hqTnBmTU4vZnduRzRLSndYK0h1YzQxcmxON2c3cHljR2NkR2twRXhK?=
 =?utf-8?B?Mk5YYWhtNWxUcFh4RUFWZXlnckhhVGZUaWFFL1FZN2ppZGlOcXFCUmM1RjI0?=
 =?utf-8?B?bmZyOGRZcDBINXp3V295N3MycXRtcDhOY0tQMFhKcDlsSDlPeG92bEJmZlVs?=
 =?utf-8?B?N1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d4c8e81f-09a5-4598-36eb-08dbf4b2951c
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 10:20:04.8721
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 65sScq61ZGdgLefgjCsGGS8FcUyXk6GuWLj0wZzW76bo6SJzqbFDwPw/fVWtktHBvMvZW3h8TMmVIY279YtkLtGknqTh+l8DUngCKL+FwLA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6222
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 04 Dec 2023 02:20:23 -0800 (PST)


On 04.12.2023 02:10, Jijie Shao wrote:
> From: Yonglong Liu <liuyonglong@huawei.com>
> 
> If a xge port just connect with an optical module and no fiber,
> it may have a fake link up because there may be interference on
> the hardware. This patch adds an anti-shake to avoid the problem.
> And the time of anti-shake is base on tests.
> 
> Fixes: b917078c1c10 ("net: hns: Add ACPI support to check SFP present")
> Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>
> Signed-off-by: Jijie Shao <shaojijie@huawei.com>
> ---
>  .../net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> index 928d934cb21a..c3abb14edd51 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c
> @@ -66,6 +66,27 @@ static enum mac_mode hns_get_enet_interface(const struct hns_mac_cb *mac_cb)
>  	}
>  }
>  
> +static void hns_mac_link_anti_shake(struct mac_driver *mac_ctrl_drv,
> +				    u32 *link_status)
> +{

It would be cleaner to return the link status than using output arg IMO

> +#define HNS_MAC_LINK_WAIT_TIME 5
> +#define HNS_MAC_LINK_WAIT_CNT 40
> +
> +	int i;
> +
> +	if (!mac_ctrl_drv->get_link_status) {
> +		*link_status = 0;
> +		return;
> +	}
> +
> +	for (i = 0; i < HNS_MAC_LINK_WAIT_CNT; i++) {
> +		msleep(HNS_MAC_LINK_WAIT_TIME);
> +		mac_ctrl_drv->get_link_status(mac_ctrl_drv, link_status);
> +		if (!*link_status)
> +			break;
> +	}
> +}
> +
>  void hns_mac_get_link_status(struct hns_mac_cb *mac_cb, u32 *link_status)
>  {
>  	struct mac_driver *mac_ctrl_drv;
> @@ -83,6 +104,14 @@ void hns_mac_get_link_status(struct hns_mac_cb *mac_cb, u32 *link_status)
>  							       &sfp_prsnt);
>  		if (!ret)
>  			*link_status = *link_status && sfp_prsnt;
> +
> +		/* for FIBER port, it may have a fake link up.
> +		 * when the link status changes from down to up, we need to do
> +		 * anti-shake. the anti-shake time is base on tests.
> +		 * only FIBER port need to do this.
> +		 */
> +		if (*link_status && !mac_cb->link)
> +			hns_mac_link_anti_shake(mac_ctrl_drv, link_status);
>  	}
>  
>  	mac_cb->link = *link_status;