Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2614216rdb; Mon, 4 Dec 2023 02:36:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IElVO2t4FOu+mH+kNddhbEKiDc1JIgGAp9gpdFU0OY0itOBY6Q+ClBReJ3RK3OVyQIbOWyX X-Received: by 2002:a05:6358:52c3:b0:16e:111:fafd with SMTP id z3-20020a05635852c300b0016e0111fafdmr3236605rwz.12.1701686207332; Mon, 04 Dec 2023 02:36:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701686207; cv=none; d=google.com; s=arc-20160816; b=ibuMiWEOg4aOXm3BCIVVHsNJNwagWEakxF2SCz/AfWYe4xReDVLvzgMtp8E8JSa8zo mmdWXkmCvnucMThixsrz4TCM3soFaT5QLoe3AXqF68IqQl4Hul1jDHVua6+jPEJk9zPH ljEBRrCIaMQE5T0oJP7TvQqIXAA4S9nLvP8K9WMf24W63FSLRDcAU7Sd2LHylSzSPwUK pePWfQlo7dvaUF6RqWLkYdnqgwUqvfl5kzWzj7D9e24lOnuzl1WIKDFBa8FOtB9xQ7XO SrxFUA6Gi83Rf4+92BuiT8Oot5liiTLT8wLdLvs9hdNpYe3xWJpOtBEOMpd98WCehMtO A46w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=mCwZaJ7dRtJDc4MiLyk7lSNLxiPR+SKMxqLPWCK5zWo=; fh=KWJbQ88DhE/YcRasxthR5IrPG1qzpPiMjIYrzRLN5h8=; b=d65+naUUkRukZ4uRIOy0Gy3doQ6PIDw3CS5Gu9jhlrJvBbEfwrqDLRnc42SLGM/dPt mUbBBt/0mIBL7Cn0jJLxMVXHxEMLaDVEUWy8XkUNs6wO94+5cVT6w4lE+1F1UJ+tW9kN oXQ4LSaazeRgK6FE0UHs6Rs4PvsfhMx5rfNIVpAaCXHhPhH5zIUQDxmELQib/iNdEXve HL8cCtV4gY4NeH0oBZAbP4kGl4/AuBKmpnEvHbPQt2I2SajHowRLHtx/R9HkT38/A5tL 8VTQOOyeYRxxROM8pCx45grG+J2uvP6hDygPRv6kTuPaGB08VO/q6V6k94FSm95QfC4L ltDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=T99h48Br; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id h63-20020a636c42000000b005c624c6c8c0si7590076pgc.536.2023.12.04.02.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 02:36:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=T99h48Br; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C022C8088A53; Mon, 4 Dec 2023 02:36:44 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231817AbjLDKg2 (ORCPT + 99 others); Mon, 4 Dec 2023 05:36:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229718AbjLDKg0 (ORCPT ); Mon, 4 Dec 2023 05:36:26 -0500 Received: from mail.alien8.de (mail.alien8.de [IPv6:2a01:4f9:3051:3f93::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADD6EB9; Mon, 4 Dec 2023 02:36:32 -0800 (PST) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id AB39A40E01AD; Mon, 4 Dec 2023 10:36:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ha1ktEKlv6FG; Mon, 4 Dec 2023 10:36:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1701686187; bh=mCwZaJ7dRtJDc4MiLyk7lSNLxiPR+SKMxqLPWCK5zWo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T99h48BruYWkziFWjTMxh6+yOj/D/PLvAsIQocbREPZWE4Hx2hIDZgnzwBFwrks9/ 7Q/Q9uorRsVIlF7kRZ0iaXQiruCkuD7qUhNyu+2P3+igKQSqtgIX2kiZVePc7Ir2Dq eaglLRWyx6deaL5iEMoWNx93+jMVVPqQm+JKTJ8AshWgVsmk6xeSvEYHdVqRle/xxP wlWMZz755WiOACjxcKyYFCYIUPG5pfxenGwLiMoevG0r821EqyH9MBvv/8sYtYe6PQ WirQexeDxx9XXJJvUDLw7EeCHjFGH23CmQk63AvV5krsQkZSYjsOvrTpC83rOccvl2 s5tx1GXFDPmOTevhe9tFIhzQB7Sqa0vkLiSJHk76/Nq2HGDlRL1QtH/2F5G6Rfke4q BBRZ3IkdKEieqccGNeNydIqaPnVFw0aDph+pFXDogcI1lU5tswxrnrdVryRqg9fWen ZKheo1BnCL2OSgKIYsUSE1qZak2hAeY9dkMb/N73MRJytAk9qodHP10hWpOIMa6pg3 JhWMcNDvnaL1QcWbtvfuC2wlV9T5hKLnBALmsoLOG+eBCPJB4y0GxeRugjSSeljcX4 jJphAcp8iPF11oG2t2uOea/bjIWXCxxRRSyOyvl3/NS8vZrcEU12ovkYS3gOpRjX1Y gw7pAqx8yTmT2+YDPh8ywMQY= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 08F5E40E014B; Mon, 4 Dec 2023 10:36:00 +0000 (UTC) Date: Mon, 4 Dec 2023 11:35:59 +0100 From: Borislav Petkov To: Alexey Makhalov Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, hpa@zytor.com, dave.hansen@linux.intel.co, bp@alien8.d, mingo@redhat.com, tglx@linutronix.de, x86@kernel.org, netdev@vger.kernel.org, richardcochran@gmail.com, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, zackr@vmware.com, linux-graphics-maintainer@vmware.com, pv-drivers@vmware.com, namit@vmware.com, timothym@vmware.com, akaher@vmware.com, jsipek@vmware.com, dri-devel@lists.freedesktop.org, daniel@ffwll.ch, airlied@gmail.com, tzimmermann@suse.de, mripard@kernel.org, maarten.lankhorst@linux.intel.com, horms@kernel.org Subject: Re: [PATCH v2 2/6] x86/vmware: Introduce vmware_hypercall API Message-ID: <20231204103559.GAZW2rj9obaooeqxWA@fat_crate.local> References: <20231122233058.185601-8-amakhalov@vmware.com> <20231201232452.220355-1-amakhalov@vmware.com> <20231201232452.220355-3-amakhalov@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231201232452.220355-3-amakhalov@vmware.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 02:36:44 -0800 (PST) On Fri, Dec 01, 2023 at 03:24:48PM -0800, Alexey Makhalov wrote: > Introducing vmware_hypercall family of functions as a common > implementation to be used by the VMware guest code and virtual > device drivers in architecture independent manner. > > By analogy with KVM hypercall API, vmware_hypercallX and > vmware_hypercall_hb_{out,in} set of functions was added to > achieve that. Architecture specific implementation should be > hidden inside. Pls read section "2) Describe your changes" in Documentation/process/submitting-patches.rst for more details on how to formulate your commit messages. Also, see section "Changelog" in Documentation/process/maintainer-tip.rst More specifically: "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour." Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette