Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
MIME-Version: 1.0
References: <20231204033549.2020289-1-wenst@chromium.org>
In-Reply-To: <20231204033549.2020289-1-wenst@chromium.org>
From:   Daniel Baluta <daniel.baluta@gmail.com>
Date:   Mon, 4 Dec 2023 13:38:02 +0200
Message-ID: <CAEnQRZBseYM8FO+fJND6pxhDrH+TFc8k6Aoj4ScNwXaz+Whmng@mail.gmail.com>
Subject: Re: [PATCH] ASoC: SOF: Move sof_of_machine_select() to core.c from sof-of-dev.c
To:     Chen-Yu Tsai <wenst@chromium.org>
Cc:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Dec 4, 2023 at 5:46=E2=80=AFAM Chen-Yu Tsai <wenst@chromium.org> wr=
ote:
>
> This reverts commit 014fdeb0d747304111cfecf93df4407c1a0c80db.
>
> Commit 014fdeb0d747 ("ASoC: SOF: Move sof_of_machine_select() to
> sof-of-dev.c from sof-audio.c") caused a circular dependency between
> the snd_sof and snd_sof_of modules:
>
>         depmod: ERROR: Cycle detected: snd_sof -> snd_sof_of -> snd_sof
>         depmod: ERROR: Found 2 modules in dependency cycles!
>
> Move the function back with sof_machine_select().
>
> Fixes: 014fdeb0d747 ("ASoC: SOF: Move sof_of_machine_select() to sof-of-d=
ev.c from sof-audio.c")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>

Thanks for fixing this.

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>