Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Date:   Mon, 4 Dec 2023 12:55:17 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     Yangtao Li <frank.li@vivo.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuidle: kirkwood: Convert to platform remove callback
 returning void
Message-ID: <20231204115517.zxjgi6ateobjj52d@pengutronix.de>
References: <20230712094014.41787-1-frank.li@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wql4bbahif3ubg5s"
Content-Disposition: inline
In-Reply-To: <20230712094014.41787-1-frank.li@vivo.com>
Precedence: bulk


--wql4bbahif3ubg5s
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 12, 2023 at 05:40:13PM +0800, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>=20
> Cc: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Reviewed-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Can you pick this up?

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--wql4bbahif3ubg5s
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmVtviQACgkQj4D7WH0S
/k5RVAf9GssNsesa0iKADCcIdZ5sTs4QcBmxOLz6FhLgc0e4kZB7HPxoLP9t+VbV
/qR0w8tyX3KPQEcdEuRc8jkmlCJczPAs5t6T7eKW3YQsYesBdW/ACDge6hnjC0Ja
H/KmLgaZD39rcdSrOmVY4vFzo04sXVkiCqEFKUAwWs9ahF75Jru3Ei40M79JQuXm
g87s15i2rzUqpN+LQN26ZMH5T9HYneFmPjZRoypYr7mSeewcKewmWhS3qJbJKJ3/
1qtx6IaaO05+QJdEud87Bch0Dxa2N10XKrD4teSpvQdAy5tPTRwSFGPylQG6Zs7n
1E7r/q9XvnhWwDxLuqUrtok8vVuEDw==
=HURS
-----END PGP SIGNATURE-----

--wql4bbahif3ubg5s--