Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2650911rdb; Mon, 4 Dec 2023 03:57:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwJPXZleGFVEOZ7fh3j5asr/gtWXGR0ot72OKEfEMCfBuPszQJtwvi4TKl1tyThiSg6oLH X-Received: by 2002:a17:902:b702:b0:1d0:914f:455f with SMTP id d2-20020a170902b70200b001d0914f455fmr1976841pls.12.1701691053962; Mon, 04 Dec 2023 03:57:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701691053; cv=none; d=google.com; s=arc-20160816; b=t0Qggp7NsOLo5prb1C2Z9BEC/MBFli/6I5tNvsu8K/8YCi+o+6sdcaSP8BjydjRo+n LkJvhBLJ1v4rnRfRZpSmmuEF+zeNalQUITc7L1SkpMgydWkeGZ/Xe7Euj1N1sVoTEcDf pg8q8i2ZaDw6BCTFINy5iPQbCVKI7bwW25Ldj6Q+VbXyiK3hqmXbny6tARQbCPd6x/2O aZ0GEiZERrIOFlb8tdnYGiK90RSUTeqr969/8JINIGQkrt5uJXd0315cJUoRLWrT5M/F mgZAtTZeQ2ulQ4utkwRrt5uQZR9ShxG/uUSBS+dte9ljv1emEbJcVTJ3ZnDwQzghqiYA uD0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=QGbDvPTppjzUr+bhKS1k9mpF9Lv5asJ6LrkOKuKl7jc=; fh=9jpBg71BIPTM/gsgRK/7SqoJvR4XtC8YGRenDo0pMi0=; b=Z/bjwSdoDUqkfeYby/TUHe4RWtb6qYA9uK7IOWCBnTX2OmgiVr7enSPxNpeoeifARF lKBppNaJYvxUdhnfimUiAWnPahgOGyKGaO2JavYN/TPPYdqZwJ6YP6nfS4/OKh2JrWeN xIsB4uLyNxklpdFazyOZYd+SRj8VVr76kW21vm+U1HGUWlWXsWgGTdIT9MC7n5ttRkVt CLDXluNCJmJfDegO+/z8nYewoCpNolbhNcCBLciQIvwyFlA8H/KEj4P+De984agYsUbL +bm2R39PkiVGYSPyQ5UbuOoQiJ0UWQSVOvTYLU47PxEv3Z1aF3CAwsciq/s6H/UeFxSj DGDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=KHqsrjgD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id js8-20020a17090b148800b00286a1497c76si2007991pjb.21.2023.12.04.03.57.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 03:57:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=KHqsrjgD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id E65DD8059D84; Mon, 4 Dec 2023 03:57:31 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232503AbjLDL5P (ORCPT + 99 others); Mon, 4 Dec 2023 06:57:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231389AbjLDL5G (ORCPT ); Mon, 4 Dec 2023 06:57:06 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A300187 for ; Mon, 4 Dec 2023 03:57:12 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d9a541b720aso3192416276.0 for ; Mon, 04 Dec 2023 03:57:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701691031; x=1702295831; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QGbDvPTppjzUr+bhKS1k9mpF9Lv5asJ6LrkOKuKl7jc=; b=KHqsrjgD1n/xuR3sqARtpi6FU3ScBJyxAtmtYLcfCH9IhjBthoj2TCaq3neiRWLToG KpeLiuZqNw6IfMDYNB32L2ODLstNg74+hQ52IDi6WjK16UlQelOh2YTMwUz/HYzK/24E py8mWSRJn8eh7Mi08iVksoSm83CBI/ywTkOup4ZImZmeyIII5ex8J8NAYoZ6t2KszWL/ n9JFMrq34lPyYvoyHALxi08qxuIwcSUaQ30CMm+ZnpDw+m4fB4cB3e5SfgJmw+090Yzz 8xxU3gunWVWgzc5bAAdDeq9N63uyQscnt7KF1cmXiSh21qtiHAOdXPffQC3jhyTvuShe i42A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701691031; x=1702295831; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QGbDvPTppjzUr+bhKS1k9mpF9Lv5asJ6LrkOKuKl7jc=; b=qHx5Bz2/Hv3CIbhdoR3zMYQvcvDHt1cb0itkgnjwCMOPSeBwToDN9NSXtM50qp2CxS eAQKCeI5Lp3Y1hPhEaMogcAoKNMrR0TfJhI/S9ach2TkTwfVTph+XcE7ZMs/2XcC51wy udGm+gqr33/FdLyuUyMxMlTE3x1LikPB+/RCcATpdGCNTvJ5hXM+XPhqH8RFDDORj3wO EW9q7Elb9iJgwuLZU9VV7MXA9m50DvQ/pRYuP0b8k8owRUjl9W9yZtosM44ZT80+DZ5Z Tc6/SuYssMpKAA6bjMz5mIYSL7BD4YRfA7aUQg3SfM6z2JqVzo8+QhSeZ4xzDgoA08kg zILQ== X-Gm-Message-State: AOJu0YyCf90Dt9yk7+qf/P2vGqcQKEmoETwEsu/mOC6SzolLkubBQXHw eqn1JXFEy2rlWRLenTJv3j6Fi51SeTByBgM= X-Received: from aliceryhl2.c.googlers.com ([fda3:e722:ac3:cc00:68:949d:c0a8:572]) (user=aliceryhl job=sendgmr) by 2002:a25:3d05:0:b0:d9b:e3f6:c8c6 with SMTP id k5-20020a253d05000000b00d9be3f6c8c6mr936462yba.4.1701691031701; Mon, 04 Dec 2023 03:57:11 -0800 (PST) Date: Mon, 4 Dec 2023 11:57:08 +0000 In-Reply-To: <20231201172212.1813387-18-cmllamas@google.com> Mime-Version: 1.0 References: <20231201172212.1813387-18-cmllamas@google.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Message-ID: <20231204115708.40838-1-aliceryhl@google.com> Subject: Re: [PATCH v2 17/28] binder: malloc new_buffer outside of locks From: Alice Ryhl To: cmllamas@google.com Cc: arve@android.com, brauner@kernel.org, gregkh@linuxfoundation.org, joel@joelfernandes.org, kernel-team@android.com, linux-kernel@vger.kernel.org, maco@android.com, surenb@google.com, tkjos@android.com, Alice Ryhl Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 04 Dec 2023 03:57:32 -0800 (PST) > Preallocate new_buffer before acquiring the alloc->mutex and hand it > down to binder_alloc_new_buf_locked(). The new buffer will be used in > the vast majority of requests (measured at 98.2% in field data). The > buffer is discarded otherwise. This change is required in preparation > for transitioning alloc->mutex into a spinlock in subsequent commits. > > Signed-off-by: Carlos Llamas Reviewed-by: Alice Ryhl