Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2651179rdb; Mon, 4 Dec 2023 03:58:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGg1e5Uxyvn5wgM3I6zp5T3ELDfu/eMh+nW7H6qll6niRFsnKCSJWs+NBloDmC3HDl8oz5o X-Received: by 2002:a05:6a20:8f91:b0:18f:97c:8a39 with SMTP id k17-20020a056a208f9100b0018f097c8a39mr3489450pzj.100.1701691092500; Mon, 04 Dec 2023 03:58:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701691092; cv=none; d=google.com; s=arc-20160816; b=FixJZHNfGNY2ZLm9ILUb5wiFBMujirrcSOnlbzN2f7dsXd29F3sgJegBdmgFMMpCNv DKUqupxklx7GfDHHRFK52u7TYrcUp5OB0cKBnkZAPVjEX8bdv563awKqTlTJQppWSbuO 1/TnzlOl957sqT91IdG9ibNdsL/EIvAbyDwB8B/KvmG3btBiImZ25IwouzCZsCZKfu19 ys6/2JvZ5dcJRGKbgeqSPQlNVO/hug4BvS81wN4CaB5dVlxBPuud2OdGk+42Mr5iOzaC V0Pp/XaAZgZHOKEGh84WYw0V8d2Wxh6a4ehUDL1N8nBvNZm0cuIZKNV4d7JjLzQf78v5 4Crg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=4y4PXLMbbM5gC9PlYGmfvYBH1e0YhV18QBtSChJHwEY=; fh=9jpBg71BIPTM/gsgRK/7SqoJvR4XtC8YGRenDo0pMi0=; b=GSjPh5gRsAABquGaGPR68WOIfY1MvfH28LSrAKOu5Ks8KKT7NZxe4eZbjRgkvPzzXl xy1yOq93xDN3JrcKQR/lJA02a5D5DhfWfTRetN/2xbV9mJjndB+EMYPkHh3jxIQ5Rhgz VtvxAYMxr7ubyjucgMNmvffFDN3n2KsIgug52fZ7J0MyfhALunv3Bk6flYNQPcvV38gN vbqgvxd5bB3O2VhkCHC5QlrMWGzfW3xK7RlCIs/ypVhTdP97OXnfFKPBUb/5fjRloueB bSG61krsWz9f8Gqj7jhIDfEbapnfLKH85kMyXThlLdFbGxowt97+GKc78NXNxOF2Jcoz KWRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=hzDZMS0k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id nb12-20020a17090b35cc00b00285b3a3f2f0si8335849pjb.181.2023.12.04.03.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 03:58:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=hzDZMS0k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 89032805C3C5; Mon, 4 Dec 2023 03:58:10 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235361AbjLDL5q (ORCPT + 99 others); Mon, 4 Dec 2023 06:57:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233193AbjLDL5Z (ORCPT ); Mon, 4 Dec 2023 06:57:25 -0500 Received: from mail-lf1-x149.google.com (mail-lf1-x149.google.com [IPv6:2a00:1450:4864:20::149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 914A8D60 for ; Mon, 4 Dec 2023 03:57:24 -0800 (PST) Received: by mail-lf1-x149.google.com with SMTP id 2adb3069b0e04-50bf87fcb29so690258e87.1 for ; Mon, 04 Dec 2023 03:57:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701691042; x=1702295842; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4y4PXLMbbM5gC9PlYGmfvYBH1e0YhV18QBtSChJHwEY=; b=hzDZMS0kR45DnDxoay+U3NZuJ+V3WTRrltNajA/wD8jPQsQoyms5uXJZaYs9vxO2eR 2CHyfNWMHKEVccbI7FCKuGLKFACr2unu0TOvKKYOADCDmy3T62WVHYAMFG1vs9elGP1N KDD5sKVpja8d7DjbQkmmSm6qWLdol8yGgUqlmeN2IqGQ6cf6p/SLnXS1nqyAcjtSGF5S 9cmUMhyJpOs07p7AcNH/zBt/A2lttXENJJNEwesX+dZhI9kgEG2Mj2vbcNEUVgscL38I gwPwx1mwXMVCbwuvaoGuqRnNO3ir1WaMP3iXcXYUCDcL9hTfdH/VcPHS+wSITv9pkVFA ATfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701691042; x=1702295842; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4y4PXLMbbM5gC9PlYGmfvYBH1e0YhV18QBtSChJHwEY=; b=e+5aKGEO11IDlEdStRMwqeQNhi+rwQ1ZgqOgi0RPM5mC/WaGnxM7HPy7smPYO2FIOY ru+9LfonvASKCSkgVnl5oHz632K/6xtQnjDG4bhRNsVT3t1xTVOOvDGxIrHEQrlFd+96 ZfBtS7aJenTN+HdXgDsbj8G/Fh4Y2qdVUKmDlgKbe2riu8OnTHirMz+z8TivbEdGgDEE tvEOdP6j7one7Os3OVDlLVr5dKLYoykIJCcUrW4v08Hcssc1thBeSmGOUbcRT+xBlKGq iW3xwZwp4HYpw5xB3I8+11rQYoDGWsGt/7LTylBtr8s0bqQRk5tRlyimT88O2iAK2IWg 9zzg== X-Gm-Message-State: AOJu0YwjwqHRqpwoqsMT5gV277BR4CGJ47CGMzH+B0h5w7BWX3gMj5J9 J7PUDw0SC5enSINuI/pyiJFCIfGxY96/KVk= X-Received: from aliceryhl2.c.googlers.com ([fda3:e722:ac3:cc00:68:949d:c0a8:572]) (user=aliceryhl job=sendgmr) by 2002:ac2:446c:0:b0:50b:e8ef:5553 with SMTP id y12-20020ac2446c000000b0050be8ef5553mr59361lfl.12.1701691042763; Mon, 04 Dec 2023 03:57:22 -0800 (PST) Date: Mon, 4 Dec 2023 11:57:19 +0000 In-Reply-To: <20231201172212.1813387-22-cmllamas@google.com> Mime-Version: 1.0 References: <20231201172212.1813387-22-cmllamas@google.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Message-ID: <20231204115719.41739-1-aliceryhl@google.com> Subject: Re: [PATCH v2 21/28] binder: make oversized buffer code more readable From: Alice Ryhl To: cmllamas@google.com Cc: arve@android.com, brauner@kernel.org, gregkh@linuxfoundation.org, joel@joelfernandes.org, kernel-team@android.com, linux-kernel@vger.kernel.org, maco@android.com, surenb@google.com, tkjos@android.com, Alice Ryhl Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 04 Dec 2023 03:58:10 -0800 (PST) > The sections in binder_alloc_new_buf_locked() dealing with oversized > buffers are scattered which makes them difficult to read. Instead, > consolidate this code into a single block to improve readability. > > No functional change here. > > Signed-off-by: Carlos Llamas Tricky, but looks ok. Reviewed-by: Alice Ryhl