Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2651861rdb; Mon, 4 Dec 2023 03:59:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFJTVvU3lCZZNNNKYjdCKUZoXLv6hZqvicwmmWkKpC4Tnh6Sq7Zt3qogWbc55GbjYyezPpG X-Received: by 2002:a05:6a20:7346:b0:18f:97c:4f3f with SMTP id v6-20020a056a20734600b0018f097c4f3fmr2016295pzc.75.1701691191375; Mon, 04 Dec 2023 03:59:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701691191; cv=none; d=google.com; s=arc-20160816; b=GFl8NycAMpM4WWvMJxWAjOOD4Amg34Zj8kohPGelvrGlpRyx+yeuAQLNJjtaODneR+ 05JHbnX60wXzg1wPQa7G5594H+vqTQjuyB8OZhW/egHOoCOjutlHMyNJ6L1mVnH247sB i1mRBAD/3WYToVG+RUUMiznGUmwSttZ6AbIxtfWs5JppYA9sPJSkYaQ1IxUqvbEwe2sd cR9O/wLO6yDMwWDn2yH+ygeh/xIf9pmN4mAUWj1NftrzLl0lbdpogp//hOpMWtfp6c9t lH87p2YJOmqOP8+uzm0ONE+eFm0ESjGM0ucqGWBgU1VbqJxDgbUFRfN5sosSIxcittWK Hb9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=Cbtwwv9tSK+nbMZceLLk+rFtyGZZTNEqHzjoCTb4mMQ=; fh=FbPogvlm7tfxQc4XAVmeNjh4o11cCqjQ4OseRljU7oM=; b=LzHeUh4BGDXhRPXq3jwE5OSBne/rhato40H2NIzeNRMZVcI9BFQwNRm8W3xgod6v9R Fzg+FDXRHzppa2NifRQvSHShXjZ6vIMnRAXi+TLXiYlChcqimyDioN6cmimVUXFYO8E7 7OHHFPv0aBn0UjnaaFN0XaDzmcHu64PXnVd7ltKkh4T+ZlexE5dv5rvNymbrle3gKZrY KFafNojKSqoVTRLX6NEsxVrJkqrO2B/nDTH/VyPj//3Vqy3bkIvgGgWqyr8DCm/PDuJ9 Onrtl1hzZmo2ucpV/WZdqjy0eDtosC8B7nseOqTHKC1KwOh9+nmLhGF+sAXCNsQO90Fb W2zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=TfZq2tQV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id bw39-20020a056a0204a700b005c65fcca231si3979520pgb.18.2023.12.04.03.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 03:59:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=TfZq2tQV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id CAA9380A7323; Mon, 4 Dec 2023 03:59:45 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232243AbjLDL7M (ORCPT + 99 others); Mon, 4 Dec 2023 06:59:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235343AbjLDL6c (ORCPT ); Mon, 4 Dec 2023 06:58:32 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93C39D49 for ; Mon, 4 Dec 2023 03:57:46 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-daf702bde7eso1917625276.3 for ; Mon, 04 Dec 2023 03:57:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1701691065; x=1702295865; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=Cbtwwv9tSK+nbMZceLLk+rFtyGZZTNEqHzjoCTb4mMQ=; b=TfZq2tQVVm3gVMV+dTb7vv/Y3POnm6Kb6+mxKz+mDJSnkA42zPPfLm5+gqNWmoYSdm It/WLPpvqZw8GOuyXl2v+SZAZQPws3pO7IHta+5XgCr6dVirZoRnBd3ivpMNr/l/XYEr srgXjuF5Cq6YtySc29Dls4F24m5blioyd6DcGRdde/fisq2H4OuY33wvHdqvkQydP4Vy 3bL6EkNYNElRZTd4tKOQy7qGnYbUgZK/L+/btI7yi/UNgFC4N3Fcnjp7E+d9aJE9k4+2 U6rHmnzAB6VYqMeP4gPD6K/R09nRPW/9cMUGJR2bT51wasFZz92gkI78sZYHvfQYpiMs A5Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701691065; x=1702295865; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cbtwwv9tSK+nbMZceLLk+rFtyGZZTNEqHzjoCTb4mMQ=; b=rGLZ6LplkKg/ArAXN4P31THQ1yMvyWCjd1bHrdHEMqX+zY7fz3fEWbpckVlruUoAqd XBAF9udxyB+Wzllczus+Z/zjc2c++WLzCMWAhgPFMeLxSyoddkeH2PXGibKKmYQG9iEM i26oGcvwWomWGNgJTevbVFjfMPT6dzO72O9NzggQaxI/aQv7P4voaA5iLyetwddNkXVQ nwxBykCJsDAldVro8y+DDS/O5IPmIj43CZpmWHf9eE1TmdUcAOII9WFTA9NF2UFzCRAS MGHAY3qXxo560mNwSWXhkFIawufp3irXnXxQwnRM1R5HuqUjnJxjSZ6RnBi1AqjPutnL EQag== X-Gm-Message-State: AOJu0Yz03pWP1zIzN/VqOm2PT3N9ZJA/3GEipLfTHCzckmlZSOw/H2Js tggKhFffjbhDqh3T5x5/kV2R5yEAM2jo3xg= X-Received: from aliceryhl2.c.googlers.com ([fda3:e722:ac3:cc00:68:949d:c0a8:572]) (user=aliceryhl job=sendgmr) by 2002:a25:74c4:0:b0:db5:4692:3aaf with SMTP id p187-20020a2574c4000000b00db546923aafmr286253ybc.6.1701691065607; Mon, 04 Dec 2023 03:57:45 -0800 (PST) Date: Mon, 4 Dec 2023 11:57:42 +0000 In-Reply-To: <20231201172212.1813387-28-cmllamas@google.com> Mime-Version: 1.0 References: <20231201172212.1813387-28-cmllamas@google.com> X-Mailer: git-send-email 2.43.0.rc2.451.g8631bc7472-goog Message-ID: <20231204115743.43597-1-aliceryhl@google.com> Subject: [PATCH v2 27/28] binder: reverse locking order in shrinker callback From: Alice Ryhl To: cmllamas@google.com Cc: arve@android.com, brauner@kernel.org, gregkh@linuxfoundation.org, joel@joelfernandes.org, kernel-team@android.com, linux-kernel@vger.kernel.org, maco@android.com, surenb@google.com, tkjos@android.com Content-Type: text/plain; charset="utf-8" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 04 Dec 2023 03:59:46 -0800 (PST) > + trace_binder_unmap_kernel_start(alloc, index); > + > + page_to_free = page->page_ptr; > + page->page_ptr = NULL; > + > + trace_binder_unmap_kernel_end(alloc, index); What are these trace calls used for? Previously they wrapped the call to __free_page, and happened after the `trace_binder_unmap_user_*` calls. I'm guessing they should be moved down to wrap the call to __free_page. Alice