Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <beanhuo@iokpp.de>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "mani@kernel.org" <mani@kernel.org>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "thomas@t-8ch.de" <thomas@t-8ch.de>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mikebi@micron.com" <mikebi@micron.com>,
        "lporzio@micron.com" <lporzio@micron.com>
Subject: RE: [PATCH v3 2/3] scsi: ufs: core: Add UFS RTC support
Thread-Topic: [PATCH v3 2/3] scsi: ufs: core: Add UFS RTC support
Thread-Index: AQHaJTkKGJCMMiwoCEWzpUFDJD5+pLCZCRfg
Date:   Mon, 4 Dec 2023 12:13:45 +0000
Message-ID: <DM6PR04MB657594BADE76428806210D3AFC86A@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20231202160227.766529-1-beanhuo@iokpp.de>
 <20231202160227.766529-3-beanhuo@iokpp.de>
In-Reply-To: <20231202160227.766529-3-beanhuo@iokpp.de>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?f50Wpbz24sjz1atofR3iLNus3HIIDGgzCPQFmaRNekLy1ZI4s2oliDT2Ijdk?=
 =?us-ascii?Q?U2VQrj/WLKWR1saJssFMtSJDZyyje8Dq7aIdIE7Vu4nWn+NprYqUzKk3qFjc?=
 =?us-ascii?Q?C+BVfzpN06GWxfM2+YM/R0NZiPF21b5Idat5ROicKp8LT0EmwSMkhAG/khyA?=
 =?us-ascii?Q?C3G4kLzhZetJ2pxEGBHr+K2vcyaEXN6UkVThJuujJCJxSz6KnccGUUsnM1Wf?=
 =?us-ascii?Q?1mna+h+ul7MMMjzsJaYyMtFi6+adcWRA6WMflzswC7qKSf1CfO5Q8X3AT3UY?=
 =?us-ascii?Q?SlzvizPg4GBwpeTkBMe3MwJUaL8HNc3Zn2/p6p3OMqO82c/pQMTRQjve3Xjc?=
 =?us-ascii?Q?yHWxvTy7V2r4VR1Eywj9EnxvP+BGQx+5qbf8JjonY0jIq3zsB/D9LpZBJwls?=
 =?us-ascii?Q?rFGXmHp+op9lXUgrn+s4IbC6VwlF35B7h+h2WxXMO/CQG9yJNM01EKr5IztX?=
 =?us-ascii?Q?YE3buMM21yLyI7AIPWlpnkjcCOhYlpSO5kdLp6H3cIvoxQlG63KpnHiifjhL?=
 =?us-ascii?Q?TLH4Y1J6M77wmsqKXKp9GVtbg9YG+LbJ1GT/R1p2yEsmtQD4hqXUHRItXniY?=
 =?us-ascii?Q?U4w/GjNPtCoOlsv3RnOLzDK7ZS4v5EVp9v4BJBiYgRDGXHiVVfp9o+QMDiHF?=
 =?us-ascii?Q?KzXM2VoAl54hzUlm6LE1GliS67CkGNEGlv5iWS9qqc/S6ggcgekTAfvkL1T0?=
 =?us-ascii?Q?N1A504dcoYSfBOpxxCgaUOJhqJRMNohUWx3q/OofLKganWv/DfWWJ60H/IgQ?=
 =?us-ascii?Q?oYI7nctdp7HzxgUm1vX8SgUKf9wz82QpGOu8A/D68PX0UDAh3l/aWLg4yiJ4?=
 =?us-ascii?Q?dMwB2zp9KNwSDPvte9c1h/ElZA3ol9tlkECcasEgVZg0OVxxwOUJl5yMbrEs?=
 =?us-ascii?Q?hyV1sTI7EDh48h84+YsDkzZjgpl655Q23QJN//SIdAnqPRPrOq2v3roPXr5y?=
 =?us-ascii?Q?6i8SoRcpgQ8RWdLDmN4u/eBXe6hYCptYxZzBHnZMIX0DdoeZmsrp7jgUYRmx?=
 =?us-ascii?Q?52uRDh7XneCiyoEZSykWuq2KxL5gu4hzE0VAOSDCkQPS9yD/0z0tj2Mbpi/x?=
 =?us-ascii?Q?jxlBnv2akQh6dqQcqUmmN1byCpZT0tSns2feNpZOmo4c0kiJyJCVMyiR5XYf?=
 =?us-ascii?Q?00L46/g8xvLOBe2tKDunpLHc1VQnHWlHIWPaAcvFXOU/AmoJ+Rd4ICDJMZML?=
 =?us-ascii?Q?1mMvcxspR4XmgyT5mg7tcM2A7DOgtJwDJCLT/Tdh4jmPFaJG2CJ6NyKV8iAe?=
 =?us-ascii?Q?uDxxZOlBU2qmX7ItnVNCmVGYJbJtb93i9G5mLbPqjrmrZvpiefGDKtPospqb?=
 =?us-ascii?Q?KkCJ7CrL8ajbJM4CNarX+rvt8s3ruyhNtzgq3zQBFJbdGQedZP7I8Nl/wCN5?=
 =?us-ascii?Q?GE+seVlgERzTVOQ8D9LLYYd5UKG6gk3zwV15jD+fknIwoe0MX2AAwvAjhlpT?=
 =?us-ascii?Q?2yuBXYce/YMG8izUntWxIaw6D2pbYBC/fuTTq9HtY736j3MuJORNZWl0n1ci?=
 =?us-ascii?Q?F0uNkrQmvSprSpsQHx6mNPmkH4UZTwI/5nJgF5eu1stT+ZNPZYlbLf5z1nHB?=
 =?us-ascii?Q?jStl9v/TKztuSPeKCtDkp+YNNRw2mbOzXPiK2ivA?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?KvCzokIiKaSrrVLf1f9Z36WDVTp1hVcgN2Gj40aVeKHlZFe3n2g1nXJHkg98?=
 =?us-ascii?Q?TL572/XaRBIslHo3m42hSuZoUDUzOIANmkXjr14yvVjkJd/psPJWOTedDqZ9?=
 =?us-ascii?Q?WzMGUEZFfAy9gIRmVHlO6GWHwDKrfqAdAm9gTkSQlUCIFQXTUrYYckd4tRdV?=
 =?us-ascii?Q?hPDtZ3r9ZcBXw8B3kib5xRcowR4i2zx57Xr9z4De21eom8mYH/a26MMelP6c?=
 =?us-ascii?Q?fH3uw5+RYAe2vcCniEp2Vsa7AF4T+u30EvT/5R1VP0HvlLjsY7v6PLRrG+MI?=
 =?us-ascii?Q?17gz6/Wtts341Vao7oE9aT9OimPeF1s+qSLErDOc7MaaGD3Vfei2/GGQUFoI?=
 =?us-ascii?Q?xUEUR0A5bdCMyE/xN3a5LCLkFC3NnbCnZs4SEKeuJLm86lovDkzNpIK8VusD?=
 =?us-ascii?Q?6bXR7YCBPoxr7rGJyJecimxdrjPGzZ/mRuh2/SlaPkzF5ur1YwUsGyr1Pg/o?=
 =?us-ascii?Q?Kx+zgSB7l6ZZy6ai0odF6udK6IDTNFzkIe09lWk7BJVfHRnlPmv0MkpHJ/am?=
 =?us-ascii?Q?4HB7IrB4a1iiSzuWQjPc1x+Eo8rfEGBvBuuhE3WBfLE6ORRho4CgH7NGq7uF?=
 =?us-ascii?Q?XXdH2xYhkMBr8Eqv5Mmaip3R6QutyjzgQrgqU93DmV+kKy+6TYJHEnKwuLO5?=
 =?us-ascii?Q?dX/lVI+hJTvdHN+48R12DjR5fnwBIANRWjLwFWOFRDOj33EzRvaTT4o3Nb5J?=
 =?us-ascii?Q?MwuwJQxHEcFLuNbFBIKhpw2v1MFaqNf3+7dAYR1dE5/vtaBl7685daqqPX/w?=
 =?us-ascii?Q?emucKaBn1QuXtEQbPjRnS5iUZBFoeFAnn9H5kJ1/ECnE6jl3Qr9mXaB481Oz?=
 =?us-ascii?Q?/2xXoDXfvW1BpXbDkB53pP3l/EBPm16zzycYdzQ0L0MPa6bV9VkxRccQjJDV?=
 =?us-ascii?Q?HJJmqx5XYZ+URAov/SahfM0lQywdEuiHMkcjqX6CVC2yK/OAs7qA33/hDTKX?=
 =?us-ascii?Q?N8P0kKMbEjzloSQIkkaJkT1XR9ZQOghtvgfjUbmcqA7maTijYAzrk2whVYwz?=
 =?us-ascii?Q?LkoeStHd8hhSGW3CZBxhVBIBMyBRU+qpHwsyk5izPOlxpX0=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7db68d2e-0096-4907-d98e-08dbf4c276f6
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 12:13:45.9336
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: eLJSUZoJBDWSthW7V588O/gda2vhqM01q/+gCFiAMQz1j8espRaF5hI9fmvmEAZ3xv4nb4gsVjmCGNxD4Gal2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7772
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 04:14:08 -0800 (PST)

> +static void  ufs_init_rtc(struct ufs_hba *hba, u8 *desc_buf) {
> +       struct ufs_dev_info *dev_info =3D &hba->dev_info;
> +       u16 periodic_rtc_update =3D
> +get_unaligned_be16(&desc_buf[DEVICE_DESC_PARAM_FRQ_RTC]);
> +
> +       if (periodic_rtc_update & UFS_RTC_TIME_BASELINE) {
Is it allowed to ignore the update period as depicted by wPeriodicRTCUpdate=
?
And choose a different update period, e.g. 10 seconds instead?
If yes - then It deserve a comment IMO.

Thanks,
Avri

> +               dev_info->rtc_type =3D UFS_RTC_ABSOLUTE;
> +               /*
> +                * The concept of measuring time in Linux as the number o=
f seconds
> elapsed since
> +                * 00:00:00 UTC on January 1, 1970, and UFS ABS RTC is el=
apsed
> from January 1st
> +                * 2010 00:00, here we need to adjust ABS baseline.
> +                */
> +               dev_info->rtc_time_baseline =3D mktime64(2010, 1, 1, 0, 0=
, 0) -
> +                                                       mktime64(1970, 1,=
 1, 0, 0, 0);
> +       } else {
> +               dev_info->rtc_type =3D UFS_RTC_RELATIVE;
> +               dev_info->rtc_time_baseline =3D 0;
> +       }
> +
> +       INIT_DELAYED_WORK(&hba->ufs_rtc_update_work, ufshcd_rtc_work);
> }
> +
>  static int ufs_get_device_desc(struct ufs_hba *hba)  {
>         int err;
> @@ -8241,6 +8310,8 @@ static int ufs_get_device_desc(struct ufs_hba
> *hba)
>=20
>         ufshcd_temp_notif_probe(hba, desc_buf);
>=20
> +       ufs_init_rtc(hba, desc_buf);
> +
>         if (hba->ext_iid_sup)
>                 ufshcd_ext_iid_probe(hba, desc_buf);
>=20
> @@ -8794,6 +8865,8 @@ static int ufshcd_device_init(struct ufs_hba *hba,
> bool init_dev_params)
>         ufshcd_force_reset_auto_bkops(hba);
>=20
>         ufshcd_set_timestamp_attr(hba);
> +       schedule_delayed_work(&hba->ufs_rtc_update_work,
> +
> + msecs_to_jiffies(UFS_RTC_UPDATE_INTERVAL_MS));
>=20
>         /* Gear up to HS gear if supported */
>         if (hba->max_pwr_info.is_valid) { @@ -9750,6 +9823,8 @@ static in=
t
> __ufshcd_wl_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
>         ret =3D ufshcd_vops_suspend(hba, pm_op, POST_CHANGE);
>         if (ret)
>                 goto set_link_active;
> +
> +       cancel_delayed_work_sync(&hba->ufs_rtc_update_work);
>         goto out;
>=20
>  set_link_active:
> @@ -9844,6 +9919,8 @@ static int __ufshcd_wl_resume(struct ufs_hba
> *hba, enum ufs_pm_op pm_op)
>                 if (ret)
>                         goto set_old_link_state;
>                 ufshcd_set_timestamp_attr(hba);
> +               schedule_delayed_work(&hba->ufs_rtc_update_work,
> +
> + msecs_to_jiffies(UFS_RTC_UPDATE_INTERVAL_MS));
>         }
>=20
>         if (ufshcd_keep_autobkops_enabled_except_suspend(hba))
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h index
> e77ab1786856..8022d267fe8a 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -14,6 +14,7 @@
>  #include <linux/bitops.h>
>  #include <linux/types.h>
>  #include <uapi/scsi/scsi_bsg_ufs.h>
> +#include <linux/time64.h>
>=20
>  /*
>   * Using static_assert() is not allowed in UAPI header files. Hence the =
check
> @@ -551,6 +552,15 @@ struct ufs_vreg_info {
>         struct ufs_vreg *vdd_hba;
>  };
>=20
> +/*
> + * UFS device descriptor wPeriodicRTCUpdate bit9 defines RTC time
> baseline.
> + */
> +#define UFS_RTC_TIME_BASELINE BIT(9)
> +enum ufs_rtc_time {
> +       UFS_RTC_RELATIVE,
> +       UFS_RTC_ABSOLUTE
> +};
> +
>  struct ufs_dev_info {
>         bool    f_power_on_wp_en;
>         /* Keeps information if any of the LU is power on write protected=
 */ @@
> -578,6 +588,10 @@ struct ufs_dev_info {
>=20
>         /* UFS EXT_IID Enable */
>         bool    b_ext_iid_en;
> +
> +       /* UFS RTC */
> +       enum ufs_rtc_time rtc_type;
> +       time64_t rtc_time_baseline;
>  };
>=20
>  /*
> diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h index
> 7f0b2c5599cd..7bdda92fcb1c 100644
> --- a/include/ufs/ufshcd.h
> +++ b/include/ufs/ufshcd.h
> @@ -911,6 +911,8 @@ enum ufshcd_mcq_opr {
>   * @mcq_base: Multi circular queue registers base address
>   * @uhq: array of supported hardware queues
>   * @dev_cmd_queue: Queue for issuing device management commands
> + * @mcq_opr: MCQ operation and runtime registers
> + * @ufs_rtc_update_work: A work for UFS RTC periodic update
>   */
>  struct ufs_hba {
>         void __iomem *mmio_base;
> @@ -1071,6 +1073,8 @@ struct ufs_hba {
>         struct ufs_hw_queue *uhq;
>         struct ufs_hw_queue *dev_cmd_queue;
>         struct ufshcd_mcq_opr_info_t mcq_opr[OPR_MAX];
> +
> +       struct delayed_work ufs_rtc_update_work;
>  };
>=20
>  /**
> --
> 2.34.1
>=20