Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Bean Huo <beanhuo@iokpp.de>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "mani@kernel.org" <mani@kernel.org>,
        "quic_cang@quicinc.com" <quic_cang@quicinc.com>,
        "quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "thomas@t-8ch.de" <thomas@t-8ch.de>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mikebi@micron.com" <mikebi@micron.com>,
        "lporzio@micron.com" <lporzio@micron.com>
Subject: RE: [PATCH v3 2/3] scsi: ufs: core: Add UFS RTC support
Thread-Topic: [PATCH v3 2/3] scsi: ufs: core: Add UFS RTC support
Thread-Index: AQHaJTkKGJCMMiwoCEWzpUFDJD5+pLCZCRfggAAFs7A=
Date:   Mon, 4 Dec 2023 12:23:42 +0000
Message-ID: <DM6PR04MB657587A7051D5B70F8B39D72FC86A@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20231202160227.766529-1-beanhuo@iokpp.de>
 <20231202160227.766529-3-beanhuo@iokpp.de>
 <DM6PR04MB657594BADE76428806210D3AFC86A@DM6PR04MB6575.namprd04.prod.outlook.com>
In-Reply-To: <DM6PR04MB657594BADE76428806210D3AFC86A@DM6PR04MB6575.namprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cWwKGzzazTooFUVmetsdYs6vYFNnpKoTds4Gcsiq18NJtWG6Uxf+HFlYBdCg?=
 =?us-ascii?Q?VdNs33egpG3J2mfGFec5WbHCUE+yIz0OLJD71g+sfEPSev3GVcrRMuiASCCE?=
 =?us-ascii?Q?G8rWnJaqqblh0oAh848uEAKzg2qZFwm+c3EgV6u7fPiZs5Qi71MhF/Ci71RO?=
 =?us-ascii?Q?UZ1+p7VoRlployASn6nieEeyvnKVfbi94fTuA3NYaDQGvQIu0fGp1Rc33Lri?=
 =?us-ascii?Q?BqunlWQ9FX2tIwF5CDjvCD17EDyDJ8Wu0WC7bIhtJEksBf6xIKxJKB2s9dL2?=
 =?us-ascii?Q?mHIYi6yCi/Oe/bm4za6lVtKwux0L6tek5fcaorh/zVeVQ8Ych9DuIw1hfjLB?=
 =?us-ascii?Q?wB2G1McEKwa0cL1IjaLASt9qJWXujEza8rfVtaFTY9hBu+lBV1HbtBBiCwgC?=
 =?us-ascii?Q?g4zRlY5Nxrb1g5/dBHWuUpg+axePv6i+eYiBLSgJJbuqcUW0A3oNJOqN8Awv?=
 =?us-ascii?Q?0/GzPasY92S/dK54fXb+zFyi5SoEeZ/0LruuRnea3V7bjR6lXwaIUoSLrTMn?=
 =?us-ascii?Q?TXSRJpcz05ivyYI0xD2W9oQujXECdlgxI42wZt0gfJ2OBXnvovFv0pgzrXVp?=
 =?us-ascii?Q?+PzOV+6ghIgi5lvui6P0yEKZ2E8civCK/bXnA9kjHKfMds2iQmRGbD9xcpHu?=
 =?us-ascii?Q?WhtZlpwFU15LvD3HRZwk62r7r1eQ1Tb0sAuV/CCNPg9BsGpOc8eaDPoSXztS?=
 =?us-ascii?Q?pqJZJOfYUJkld0wm0GAv/NflkHdVEbYMlRtQnnlrydoBbF7JJ7un7T+ZIB98?=
 =?us-ascii?Q?sCeOzNm6gglwhnL+V8dLvCs9qnJjhvISxubplZQKws9SbONoCCxVo5IKxWpQ?=
 =?us-ascii?Q?DO+/EWf4s5b13NOEo5zxVXnChfujJ7TIMH6ocAxoaRoMC352Xg42OhmNu7ym?=
 =?us-ascii?Q?5ZTDlxiZOdagTPDlhlkv4qLQVzOf4YPf28eeebBrV5GZSM6pIQWMn/5kJNbo?=
 =?us-ascii?Q?/bjYJVr7yIJQFhByVsCCSc8D5p7xwtQxzZ0YD6Y2xWkB1cET+kib26nzgKtx?=
 =?us-ascii?Q?mjhzCCHYT8+mvKOdytrs8U10N6RYRL83W2A9wFfjebbt7bWqtmQG5FbpabEF?=
 =?us-ascii?Q?ivB6804kpuBNIBSh+4Fy7MeBlcTVtlQpoefBV8NYHHvqpGWBP2qGSDn7e1XK?=
 =?us-ascii?Q?T5oIhqLdQWyvup8VnkGeaDoLWgZzlFVGdyJUgp/6gw0bggnEBzZVGA/tkad6?=
 =?us-ascii?Q?3bKkJMNVJmZptd6yb+bbh3qmoTuVW7WtVcSYu8vGsaSWO0Cesrjx94vMsBzn?=
 =?us-ascii?Q?wh72956RT0yLs8UrKFr73uczcw1kAL0IIK5kVpUzlNLBP+0RbOLwVZ4z+WmD?=
 =?us-ascii?Q?cIbrExYsqagcx4s5fzSl1XfYANVYF9EBRIJ+8XCFua2oyFPDh3p/pqwe/w88?=
 =?us-ascii?Q?WyFCQE4hbJFlzS0DtNrYd2dJ/45/lDL2nzffxsPK300NDIC0ijN1hxJuqgJ4?=
 =?us-ascii?Q?gsW8ThjwI7x0RPntRWLTsw3FzS3Xtt8NmrgUJnUEOs2YiRlhK1t/4O2m0ApB?=
 =?us-ascii?Q?A1CuZ3VFZZlNSbusaGw+kWGtjr9eUwrywI7NnxVd3cG3L7SKBIQYipvUmHBy?=
 =?us-ascii?Q?fz5vA2zkLUrOf3LMetKFvC2qWmKd3tWrW4/QGrOY?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?jdRywnAYsk3aE19VKKyJK7Nn0sT6u+2zpVDyIECz/Pw4ZQJ7WPbtnlsO/Ys+?=
 =?us-ascii?Q?sb4oaFHIR3FZelLkrqtVMH/MFaMbqXdGIqtaEQcJ316F9mJWAuhcl2x5hK1x?=
 =?us-ascii?Q?q7dhZ27iNlYdoCo1K7+mHPM1mToY6H7tvSO98434wLvut1HvwIy0+gR3xXnr?=
 =?us-ascii?Q?Sd+yxrjbj2kPsa6rPrYlKTVmsh7wkZ2fTK3zmj4GHDbSbp3y14bjkGAnQVQ+?=
 =?us-ascii?Q?03zCQyS6esImePs3Ze14UUhfkdtZJPbj8Zgb4IE3e7hhq16JeJnssb39gjvL?=
 =?us-ascii?Q?PYYHkTyfTdGT6MfwGAPvGWE9jpmXbvrQ4Y78ix0NyUcMKslnXo82UkmOkQIY?=
 =?us-ascii?Q?zSgqO6A4E1rHINU6onm3DHZjKP92uO152f+pTihKnttJaw33O68Nv78V+0YC?=
 =?us-ascii?Q?iy1URQ9nYe/OwYv9bqzAqSiDpTAz+VFY7Yj11vw9FgUm1ActdyYlOM+kH7n9?=
 =?us-ascii?Q?GGpj/IbQNN8HtibTnrofeIdNGy90WQD0HtMdqWCMYPYMqjWnDMLTe/sLvDvA?=
 =?us-ascii?Q?vVBfR+cBZa6VTmWdsVnp6rWBQKLcpMt31Ogd7sa/mrgm/VGMUufhfYMlfYtK?=
 =?us-ascii?Q?v1gMlXw+PBzQpAaglxGoPPdRWwX68TXJN6VfvR42xDUQZAtSrmtWoVpIx+au?=
 =?us-ascii?Q?qlTNf7anfEZyo7T1jVXHJ1tywcS5LTP6Ai5cXMPG3IS7qF4UUuTLNHB+2pYW?=
 =?us-ascii?Q?1UIUU6Ty1mBZ9S/mB1SlZVeCTzFASdf8XBTLSrXeQNxJdaRnTTyo57oTJpfh?=
 =?us-ascii?Q?pq2nn+XgQ52kEI4L82j5cc74Y52On5IBTbZWZqEyCo8GQOEO/qY1PTaSCHL1?=
 =?us-ascii?Q?aHeKSF5ZyFk0ZM2NjezQIZIqOWTCstJ+3Nz15kaeSBoiTw/ySjSher5gcj/c?=
 =?us-ascii?Q?PpM9r7Cm+Nc+Pi3by/QhPHYaIK2n0elBlQScUjuskC4Aipw+5BUgRay/kJS3?=
 =?us-ascii?Q?02pphNC8pQE6ihUVgkfhOEGHx6xcAeb+45QRVjt5VAOoCMEsKzYHqujyFsXV?=
 =?us-ascii?Q?YnkyVvbQBb+BIpvmDj45MEjEy9MzHjfI3Bm8Fx282yS21x4=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bf487f5-1650-4148-54a8-08dbf4c3daa4
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2023 12:23:42.6751
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3v++FQgBiwqxxpYbe64CTV7/POMOumJvczIUCSfZn+a9UB3fAziKkwa8hkofvdvutUkUNP2VjH4Tuo3vxXV2Ow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB7102
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 04 Dec 2023 04:23:57 -0800 (PST)

>=20
> > +static void  ufs_init_rtc(struct ufs_hba *hba, u8 *desc_buf) {
> > +       struct ufs_dev_info *dev_info =3D &hba->dev_info;
> > +       u16 periodic_rtc_update =3D
> > +get_unaligned_be16(&desc_buf[DEVICE_DESC_PARAM_FRQ_RTC]);
> > +
> > +       if (periodic_rtc_update & UFS_RTC_TIME_BASELINE) {
> Is it allowed to ignore the update period as depicted by
> wPeriodicRTCUpdate?
> And choose a different update period, e.g. 10 seconds instead?
> If yes - then It deserve a comment IMO.
Oh - the comment is in the 3rd patch.
Sorry - please ignore.

Thanks,
Avri

>=20
> Thanks,
> Avri
>=20
> > +               dev_info->rtc_type =3D UFS_RTC_ABSOLUTE;
> > +               /*
> > +                * The concept of measuring time in Linux as the
> > + number of seconds
> > elapsed since
> > +                * 00:00:00 UTC on January 1, 1970, and UFS ABS RTC is
> > + elapsed
> > from January 1st
> > +                * 2010 00:00, here we need to adjust ABS baseline.
> > +                */
> > +               dev_info->rtc_time_baseline =3D mktime64(2010, 1, 1, 0,=
 0, 0) -
> > +                                                       mktime64(1970, =
1, 1, 0, 0, 0);
> > +       } else {
> > +               dev_info->rtc_type =3D UFS_RTC_RELATIVE;
> > +               dev_info->rtc_time_baseline =3D 0;
> > +       }
> > +
> > +       INIT_DELAYED_WORK(&hba->ufs_rtc_update_work,
> ufshcd_rtc_work);
> > }
> > +
> >  static int ufs_get_device_desc(struct ufs_hba *hba)  {
> >         int err;
> > @@ -8241,6 +8310,8 @@ static int ufs_get_device_desc(struct ufs_hba
> > *hba)
> >
> >         ufshcd_temp_notif_probe(hba, desc_buf);
> >
> > +       ufs_init_rtc(hba, desc_buf);
> > +
> >         if (hba->ext_iid_sup)
> >                 ufshcd_ext_iid_probe(hba, desc_buf);
> >
> > @@ -8794,6 +8865,8 @@ static int ufshcd_device_init(struct ufs_hba
> > *hba, bool init_dev_params)
> >         ufshcd_force_reset_auto_bkops(hba);
> >
> >         ufshcd_set_timestamp_attr(hba);
> > +       schedule_delayed_work(&hba->ufs_rtc_update_work,
> > +
> > + msecs_to_jiffies(UFS_RTC_UPDATE_INTERVAL_MS));
> >
> >         /* Gear up to HS gear if supported */
> >         if (hba->max_pwr_info.is_valid) { @@ -9750,6 +9823,8 @@ static
> > int __ufshcd_wl_suspend(struct ufs_hba *hba, enum ufs_pm_op pm_op)
> >         ret =3D ufshcd_vops_suspend(hba, pm_op, POST_CHANGE);
> >         if (ret)
> >                 goto set_link_active;
> > +
> > +       cancel_delayed_work_sync(&hba->ufs_rtc_update_work);
> >         goto out;
> >
> >  set_link_active:
> > @@ -9844,6 +9919,8 @@ static int __ufshcd_wl_resume(struct ufs_hba
> > *hba, enum ufs_pm_op pm_op)
> >                 if (ret)
> >                         goto set_old_link_state;
> >                 ufshcd_set_timestamp_attr(hba);
> > +               schedule_delayed_work(&hba->ufs_rtc_update_work,
> > +
> > + msecs_to_jiffies(UFS_RTC_UPDATE_INTERVAL_MS));
> >         }
> >
> >         if (ufshcd_keep_autobkops_enabled_except_suspend(hba))
> > diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h index
> > e77ab1786856..8022d267fe8a 100644
> > --- a/include/ufs/ufs.h
> > +++ b/include/ufs/ufs.h
> > @@ -14,6 +14,7 @@
> >  #include <linux/bitops.h>
> >  #include <linux/types.h>
> >  #include <uapi/scsi/scsi_bsg_ufs.h>
> > +#include <linux/time64.h>
> >
> >  /*
> >   * Using static_assert() is not allowed in UAPI header files. Hence
> > the check @@ -551,6 +552,15 @@ struct ufs_vreg_info {
> >         struct ufs_vreg *vdd_hba;
> >  };
> >
> > +/*
> > + * UFS device descriptor wPeriodicRTCUpdate bit9 defines RTC time
> > baseline.
> > + */
> > +#define UFS_RTC_TIME_BASELINE BIT(9)
> > +enum ufs_rtc_time {
> > +       UFS_RTC_RELATIVE,
> > +       UFS_RTC_ABSOLUTE
> > +};
> > +
> >  struct ufs_dev_info {
> >         bool    f_power_on_wp_en;
> >         /* Keeps information if any of the LU is power on write
> > protected */ @@
> > -578,6 +588,10 @@ struct ufs_dev_info {
> >
> >         /* UFS EXT_IID Enable */
> >         bool    b_ext_iid_en;
> > +
> > +       /* UFS RTC */
> > +       enum ufs_rtc_time rtc_type;
> > +       time64_t rtc_time_baseline;
> >  };
> >
> >  /*
> > diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h index
> > 7f0b2c5599cd..7bdda92fcb1c 100644
> > --- a/include/ufs/ufshcd.h
> > +++ b/include/ufs/ufshcd.h
> > @@ -911,6 +911,8 @@ enum ufshcd_mcq_opr {
> >   * @mcq_base: Multi circular queue registers base address
> >   * @uhq: array of supported hardware queues
> >   * @dev_cmd_queue: Queue for issuing device management commands
> > + * @mcq_opr: MCQ operation and runtime registers
> > + * @ufs_rtc_update_work: A work for UFS RTC periodic update
> >   */
> >  struct ufs_hba {
> >         void __iomem *mmio_base;
> > @@ -1071,6 +1073,8 @@ struct ufs_hba {
> >         struct ufs_hw_queue *uhq;
> >         struct ufs_hw_queue *dev_cmd_queue;
> >         struct ufshcd_mcq_opr_info_t mcq_opr[OPR_MAX];
> > +
> > +       struct delayed_work ufs_rtc_update_work;
> >  };
> >
> >  /**
> > --
> > 2.34.1
> >