Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2669944rdb; Mon, 4 Dec 2023 04:31:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IGlBYgtSTH118AiOcDuynIdYfecQe/qix0YmcbvcXeyi5ounIko7IDumw/GZxEVoRQd8SGg X-Received: by 2002:a17:90a:be12:b0:286:6cc0:b901 with SMTP id a18-20020a17090abe1200b002866cc0b901mr1099192pjs.56.1701693060174; Mon, 04 Dec 2023 04:31:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701693060; cv=none; d=google.com; s=arc-20160816; b=z/1pOF5ASsn3un06mcWEEJ6u4DZoLbA57Qi/KpsICVry90Y/q/EfOzHx5xErPQQc9I +U9DJDynW5Xp0nzdsCunV/2Nf17peIjjoWv9X6dix0Gzsr+5UNJMGn9MgGvWulu/p7Nt RjQeD2UOn/jlh13MbIKKCAoJQbbZIVRgfZ6GEn/X2dAYOZulHDTvPuCeycdna0h+F0Se 4NpN81ddp4TmO1oPyVmbF2PzB5qVdMBxGtf7PI8fR6lTG1viT5tyC3A7V4TfUdl1V7GP xN2e0/T/XDf9NxpimwmpCkov6Q5d4ZM6RKaKSZCHIyPlk43YcQvhpBKwJU/z0jmBIpI/ GpcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=+wF7MXWAUSpg+pspOUmXJ/w80e+9840yfukQzDgoCN4=; fh=qNyugCWiCNfN4GHyMo+1DJIbyDe6xXup0HwJu5fQsIc=; b=HdH0uV5K6B4mnZOyyIozpS7JGQbTt/8dvkU+M+YQH1Tj1bZwSNvI4ozKVlL2iy51AG Iy/yUKUt5EYsmWdhqj28A0dvRZW5o9dyiabe3mNLKEOSeI9DxiTxVdTuC7kjVd96NxgG Eu9rv+S9Ork8IWdIU/tN7EwiaaKZFOiOPBLtyM9Hiy4I8oK02uyeOXmB5YOcThveDVur iYF5uo0EM1V8iJeiak5xk0GRb/Nt7/uoLLFlCz3vkWbIMZsixgysaBa4c4vsDVHx1MXv EjJumNPA4C/PfWG4Qaw3NgdbV8K9xq6zvbOhbaKnGDq2Q8ejX0z8/YGpen5wbwgsJ5T0 6X8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VwNBAhM3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id j6-20020a17090a318600b00286b5ae24e3si1417691pjb.114.2023.12.04.04.30.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 04:31:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VwNBAhM3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 4DAB580965AA; Mon, 4 Dec 2023 04:30:45 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235394AbjLDMaY (ORCPT + 99 others); Mon, 4 Dec 2023 07:30:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235415AbjLDMaS (ORCPT ); Mon, 4 Dec 2023 07:30:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45D8B116 for ; Mon, 4 Dec 2023 04:30:25 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPS id CF709C433C8; Mon, 4 Dec 2023 12:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701693024; bh=Scnnbxct6A0XPzh5s73Wc9TuJRZ1k4HhysjpASGiM/M=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=VwNBAhM3Q1gjAVS8rMJVe7C3EGqC71Xb41c+pR4K4W2naiCy4nJh46gxiocwEGbKB OuscaGrW9kFb0SgGYGGcERJV3JbEqfNQVxgUYC5ZH/0EgMbdBmyxA8snNBagLAfRcT F8UxarbIUQ/YUctZZq+hwmpZK37/xXqKqOvCcxy1AQKppTcn10wDB0CUqrFpysLVGt v9zKu8p8SKS4MuskqiZjHjL2v1x8z1FLHho1DmfpAQ5m+CbrYqWCCC8hKnQGj8FhSZ +adRCFwQVUfAgS2gfGVEAm3RwON6SObRutdLZrRBVrgYz+QjCzmxktZw7+njTU6rgB UzCDo1VWusPMQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id B154CDD4EEF; Mon, 4 Dec 2023 12:30:24 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v3 1/5] r8152: Hold the rtnl_lock for all of reset From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170169302472.7913.15839516677330615990.git-patchwork-notify@kernel.org> Date: Mon, 04 Dec 2023 12:30:24 +0000 References: <20231129132521.net.v3.1.I77097aa9ec01aeca1b3c75fde4ba5007a17fdf76@changeid> In-Reply-To: <20231129132521.net.v3.1.I77097aa9ec01aeca1b3c75fde4ba5007a17fdf76@changeid> To: Doug Anderson Cc: kuba@kernel.org, hayeswang@realtek.com, davem@davemloft.net, linux-usb@vger.kernel.org, grundler@chromium.org, laura.nao@collabora.com, ecgh@chromium.org, stern@rowland.harvard.edu, horms@kernel.org, bjorn@mork.no, edumazet@google.com, pabeni@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 04:30:45 -0800 (PST) Hello: This series was applied to netdev/net.git (main) by David S. Miller : On Wed, 29 Nov 2023 13:25:20 -0800 you wrote: > As of commit d9962b0d4202 ("r8152: Block future register access if > register access fails") there is a race condition that can happen > between the USB device reset thread and napi_enable() (not) getting > called during rtl8152_open(). Specifically: > * While rtl8152_open() is running we get a register access error > that's _not_ -ENODEV and queue up a USB reset. > * rtl8152_open() exits before calling napi_enable() due to any reason > (including usb_submit_urb() returning an error). > > [...] Here is the summary with links: - [net,v3,1/5] r8152: Hold the rtnl_lock for all of reset https://git.kernel.org/netdev/net/c/e62adaeecdc6 - [net,v3,2/5] r8152: Add RTL8152_INACCESSIBLE checks to more loops https://git.kernel.org/netdev/net/c/32a574c7e268 - [net,v3,3/5] r8152: Add RTL8152_INACCESSIBLE to r8156b_wait_loading_flash() https://git.kernel.org/netdev/net/c/8a67b47fced9 - [net,v3,4/5] r8152: Add RTL8152_INACCESSIBLE to r8153_pre_firmware_1() https://git.kernel.org/netdev/net/c/8c53a7bd7065 - [net,v3,5/5] r8152: Add RTL8152_INACCESSIBLE to r8153_aldps_en() https://git.kernel.org/netdev/net/c/79321a793945 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html