Date: Sun, 2 Dec 2007 13:57:34 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: bbpetkov@yahoo.de
Cc: yme@gollum.tnic, Lucy McCoy <lucy@keyspan.com>,
       Andrew Morton <akpm@linux-foundation.org>, greg@kroah.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] keyspan: init termios properly
Message-ID: <20071202135734.323428c5@the-village.bc.nu>
In-Reply-To: <20071202080340.GB6528@gollum.tnic>
References: <46954.192.168.1.71.1195161016.webmail@192.168.1.71>
	<20071118131130.GA3991@gollum.tnic>
	<20071126141852.a609cdb6.akpm@linux-foundation.org>
	<20071130054500.GB17350@gollum.tnic>
	<4750471F.5050007@keyspan.com>
	<20071202080340.GB6528@gollum.tnic>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1104
Lines: 24

On Sun, 2 Dec 2007 09:03:40 +0100
Borislav Petkov <yme@gollum.tnic> wrote:

> On Fri, Nov 30, 2007 at 09:23:43AM -0800, Lucy McCoy wrote:
> > Hi All,
> >
> > I've been too busy to get to this but i'd rather not use the code fragment 
> > i sent Boris to try.  It would be better to go ahead with the tty setup if 
> > the pointer is not NULL, otherwise use the defaults and not reference the 
> > NULL pointer. I'll see if I can get to this today.
> you might also want to take a look at usa90_indat_callback() - there is
> port->tty accessed again and this time it kills the machine completely when
> something is sent over the serial line from the other end (through minicom, for
> example). Oops is at
> 
> http://www.screenshots.cc/view_image/ab9a1837/cimg00772.jpg

Change it to if (tty && urb->actual_length) in that function and it'll
probably cure it
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/