Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2674129rdb; Mon, 4 Dec 2023 04:38:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IFprw72k6hFN/QVBXTu+c7iFQhySDfHiCTnGlkxNLeediGofJd7FVbUrDs3+jNKk6SDjIFH X-Received: by 2002:a05:6a00:cd6:b0:6ce:4c61:69d1 with SMTP id b22-20020a056a000cd600b006ce4c6169d1mr2372947pfv.24.1701693513731; Mon, 04 Dec 2023 04:38:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701693513; cv=none; d=google.com; s=arc-20160816; b=Plshz5VKrPeoQEffemohu+pduyhoNqO93Tt0lZ3H8heNGQXEyrhGgM5m+UtD9M89I2 58+oJZScZz4J9cbhUrUNPwWLJSsL0pqLJTJbu5a0H4uykiBDA3UPep91CgBLWJ86dBuR wqk2PKicC8+gD4GWUYG+dj7e4klTIteG0/UCci6bLYPDk4ago3EOcArt+06LvJ3QPGri 7TMhugFMwwu6AwmX+h50m8AF92rcDsbu1f+/hV3TyUlx+Y16hxPg2+/2Rj/9Q4Rf0GY6 e/RlElhdzxOlOjAotvOjId3OzKSPJtU9d29hPQHBftvAUYyiIKiAUXzcNC3mw9obw6q7 1ing== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yqaR6ErWHcshvm8N6QI3ct1mVUW7AZz/LWvjQ4StwVk=; fh=g+WKNGTtRgmm5xFYqKmJQg7ayjElOLBYhuQk/wPMegc=; b=endi7bvyQ2+cEzG1Pze9EmAPOLEvCyRHvqWx1n6kC1dictK87K5kZ2TyqPxs4aonGZ MNA9nuEXW4p75CmvfThoFI8xkas1GkSejs5Ufd1NeP7piQUJ4ae4su69lbVCwn3sQOb6 qhPn2lUUNOYjMabG3YsPjhxSVkUqh4wskoJE5vxfxmk2eK/va7absqc4VReJA26sDY7U MDxZxOMwoOVzSoQQK9Ys+6gWm7qQOPgwCdhs+NYG7fxmFZbpyrWfT6tRQgXfaJXycGh/ opUtaKEFM3PglPHraN64BeNNPjElNtK8bF7i08iYtTNr1IpDnPnkgImCr3utkptDraTV VLkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fNDZesLD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id l3-20020a656803000000b005c680fbab22si2209020pgt.509.2023.12.04.04.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 04:38:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fNDZesLD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id B45A780952FC; Mon, 4 Dec 2023 04:38:30 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231691AbjLDMiR (ORCPT + 99 others); Mon, 4 Dec 2023 07:38:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229711AbjLDMiQ (ORCPT ); Mon, 4 Dec 2023 07:38:16 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 751FFC3 for ; Mon, 4 Dec 2023 04:38:22 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F30EFC433C9; Mon, 4 Dec 2023 12:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701693502; bh=yqaR6ErWHcshvm8N6QI3ct1mVUW7AZz/LWvjQ4StwVk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fNDZesLDtBLB2L1RV/aHfUQjfHfL4TVTLkgiDAJCuUT/8/odnkovPAHHSudBFPJ2c Cc5WI3rpUcAhe9RZXTngZR8E6Tu64WSzuASNeEqMRQAqRUNquXNdfRWnP67md/QWhk dIsplNbK5pioHaVQVzH2zV90KfGZ/wq+++awwYCFUwFNLkZnzK5fiBTyf6LJq+KmTy qJR/94hvBpFEbyg4R6ydXqNOQ93QiAD29Ipbe34GoVij7Tgl0gLI4H6CnznFFSwhIu jzEMCEUJ12DVEEqEyHEXY78rjIgAExBR3PHvkUzP16G9yGOcDARkipIckP5JjLlMgJ cVeere0t9pmwQ== Date: Mon, 4 Dec 2023 12:38:16 +0000 From: Mark Brown To: Kunwu Chan Cc: pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com, daniel.baluta@nxp.com, kai.vehmanen@linux.intel.com, perex@perex.cz, tiwai@suse.com, chao.song@intel.com, kunwu.chan@hotmail.com, sound-open-firmware@alsa-project.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: SOF: Fix null pointer dereference in sof_pci_probe Message-ID: <7ddeea58-f5d8-415c-8c07-c34be04d6a9c@sirena.org.uk> References: <20231123155424.1275919-1-chentao@kylinos.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="d0eSK/GLwNSV2WiC" Content-Disposition: inline In-Reply-To: <20231123155424.1275919-1-chentao@kylinos.cn> X-Cookie: no maintenance: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 04 Dec 2023 04:38:30 -0800 (PST) --d0eSK/GLwNSV2WiC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Nov 23, 2023 at 11:54:24PM +0800, Kunwu Chan wrote: > devm_kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. In addition to the issues others mentioned this doesn't apply against current code, please check and resend. --d0eSK/GLwNSV2WiC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVtyDcACgkQJNaLcl1U h9AkMgf+L+6WbJTiUIc2x5NzzC90SYhe4VZkSX5nDk0tim8631mq3u/Aw5PYWYlQ J/9yRTpDiNAhPHYBNBQPFPw5h+OtXs+9kvhmsOZUim018b7sohjzXr9Y0p8C4yAB zWL72CrBEGjPyw/jZlUQYsPl2Jfeuudj/MQwVKbtuXeLgbJbAdpmjTV3dOqaELXw SHENzHmSVx4GZlvNVVi4u2IO24v09WrjM+HpJRW/amFmSwq+jV2A1cnt/LZpDbrO p2rAlxXqOnjy1ciPBhHFhZ63js4ciuvpKYZa6bSBkyH6+zNzT+WViYnrKqwLLqYD QFByAyqvfoNzyEqIPZcRtevmf+5QMA== =8sV2 -----END PGP SIGNATURE----- --d0eSK/GLwNSV2WiC--