Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2681181rdb; Mon, 4 Dec 2023 04:52:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IEpZXFHT0orm147xhpU75q3J5M9lYl5wDkwkaV41b7drW7klkN22OG0CAST0cAg8e9Bf1X8 X-Received: by 2002:a05:6a20:734e:b0:18c:19d1:5e91 with SMTP id v14-20020a056a20734e00b0018c19d15e91mr1694408pzc.16.1701694327002; Mon, 04 Dec 2023 04:52:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701694326; cv=none; d=google.com; s=arc-20160816; b=F+ff9ZJUf8rKHwp/8y9IIvdMyFZFY9fD+CWVz5zSzucs7vK7ATR8IptuLJHnHG5UfA 83BrAurSdY97RmQG5KNzSYDAWq6A21d7u3xacvOGzSJVoCZWSa/nRdKxK5JCvzg2g1Ef Cum0f74UfAndQBQqsTcyqrhiVhFwhZoP2r02QCgahLh5sGHx89xPIbFrI2QqZQPZ3tUi 1Ygo1Zbf7MRHt5ivBzYgHcCn3DnqvPLlDf0OTT4XAchY9VYDnc6Vk5e/yBRNSCHsEpha +WCuhj6M6DMhcBjW3g7elF1A6VjSCYOEhpoTllofpH9H72Px3bs44ih+MwkYxeWgB6jP ndgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=EEw3h2YUHuW5XoBG49Zvl5vXb1rAUV8TebUrTrGdEVw=; fh=Kj0bc5DGVzUy6aJv53rhc1pTvzS/XhH1F1APuY6c3Yk=; b=Ewk3i3u+AWDMkQN7fW2i/RFePRAw5GfHVkZE1gDQsbV2Dk7Plrd9dDdPSUJvY72ftd 8Fw8iHW6xxou4PPcKdVFB3/W1DImyec4IAg7bzuAfYHkVtYo9uKGMvgRAplHRDUKxk8P VVLniCg89cEOWo9IPjotvn2vd0c5em9jUD4fw84mMQVs9q/oRjssnJJNla9LnopJX3X+ idzD9E1CtDe7l5irV2NUHLgg1xL2IqIDSQxPRVzUga4A0mlEGyVDFAHnsckYfwhf94Y4 Cr4Ku8N1IywiapP0g7A/McUB5ljpPm01PpdjdN2kl3VEOc56pA4M8jEvzG6T0k7WacjB q9Og== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id fj8-20020a056a003a0800b0069014d63f21si7953957pfb.148.2023.12.04.04.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 04:52:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 8BBEA8096A40; Mon, 4 Dec 2023 04:52:04 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233215AbjLDMvp (ORCPT + 99 others); Mon, 4 Dec 2023 07:51:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229711AbjLDMvn (ORCPT ); Mon, 4 Dec 2023 07:51:43 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 794F3A7 for ; Mon, 4 Dec 2023 04:51:50 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rA8Q8-00039O-JD; Mon, 04 Dec 2023 13:51:32 +0100 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rA8Q7-00DWSS-Ow; Mon, 04 Dec 2023 13:51:31 +0100 Received: from ore by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1rA8Q7-005E36-Lu; Mon, 04 Dec 2023 13:51:31 +0100 Date: Mon, 4 Dec 2023 13:51:31 +0100 From: Oleksij Rempel To: Kory Maincent Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Dent Project Subject: Re: [PATCH net-next v2 3/8] net: pse-pd: Introduce PSE types enumeration Message-ID: <20231204125131.GE981228@pengutronix.de> References: <20231201-feature_poe-v2-0-56d8cac607fa@bootlin.com> <20231201-feature_poe-v2-3-56d8cac607fa@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20231201-feature_poe-v2-3-56d8cac607fa@bootlin.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 04 Dec 2023 04:52:04 -0800 (PST) On Fri, Dec 01, 2023 at 06:10:25PM +0100, Kory Maincent wrote: > +u32 pse_get_types(struct pse_control *psec); I would add here some helper function. Something like: pse_has_podl() or pse_has_c33() -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |