Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231115121338.22959-1-francesco@dolcini.it> <20231115121338.22959-2-francesco@dolcini.it>
In-Reply-To: <20231115121338.22959-2-francesco@dolcini.it>
From:   Robert Foss <rfoss@kernel.org>
Date:   Mon, 4 Dec 2023 13:59:16 +0100
Message-ID: <CAN6tsi7MNdG1Z3RW17gbOvUYbwc3=YrG4NnrW=XLF+GyvHk3MQ@mail.gmail.com>
Subject: Re: [PATCH v1 1/3] drm/bridge: lt8912b: Add suspend/resume support
To:     Francesco Dolcini <francesco@dolcini.it>
Cc:     Adrien Grassein <adrien.grassein@gmail.com>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Stefan Eichenberger <stefan.eichenberger@toradex.com>,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        Francesco Dolcini <francesco.dolcini@toradex.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Nov 15, 2023 at 1:14=E2=80=AFPM Francesco Dolcini <francesco@dolcin=
i.it> wrote:
>
> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
>
> Add support for suspend and resume. The lt8912b will power off when
> going into suspend and power on when resuming.
>
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> ---
>  drivers/gpu/drm/bridge/lontium-lt8912b.c | 28 ++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/b=
ridge/lontium-lt8912b.c
> index 03532efb893b..097ab04234b7 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> @@ -634,6 +634,33 @@ static const struct drm_bridge_funcs lt8912_bridge_f=
uncs =3D {
>         .get_edid =3D lt8912_bridge_get_edid,
>  };
>
> +static int lt8912_bridge_resume(struct device *dev)
> +{
> +       struct lt8912 *lt =3D dev_get_drvdata(dev);
> +       int ret;
> +
> +       ret =3D lt8912_hard_power_on(lt);
> +       if (ret)
> +               return ret;
> +
> +       ret =3D lt8912_soft_power_on(lt);
> +       if (ret)
> +               return ret;
> +
> +       return lt8912_video_on(lt);
> +}
> +
> +static int lt8912_bridge_suspend(struct device *dev)
> +{
> +       struct lt8912 *lt =3D dev_get_drvdata(dev);
> +
> +       lt8912_hard_power_off(lt);
> +
> +       return 0;
> +}
> +
> +static DEFINE_SIMPLE_DEV_PM_OPS(lt8912_bridge_pm_ops, lt8912_bridge_susp=
end, lt8912_bridge_resume);
> +
>  static int lt8912_parse_dt(struct lt8912 *lt)
>  {
>         struct gpio_desc *gp_reset;
> @@ -770,6 +797,7 @@ static struct i2c_driver lt8912_i2c_driver =3D {
>         .driver =3D {
>                 .name =3D "lt8912",
>                 .of_match_table =3D lt8912_dt_match,
> +               .pm =3D pm_sleep_ptr(&lt8912_bridge_pm_ops),
>         },
>         .probe =3D lt8912_probe,
>         .remove =3D lt8912_remove,
> --
> 2.25.1
>

Reviewed-by: Robert Foss <rfoss@kernel.org>